Pali Rohár 51f4965d77 ppp: Fix generating ifname when empty IFLA_IFNAME is specified ... [ Upstream commit 2459dcb96b ] IFLA_IFNAME is nul-term string which means that IFLA_IFNAME buffer can be larger than length of string which contains. Function __rtnl_newlink() generates new own ifname if either IFLA_IFNAME was not specified at all or userspace passed empty nul-term string. It is expected that if userspace does not specify ifname for new ppp netdev then kernel generates one in format "ppp<id>" where id matches to the ppp unit id which can be later obtained by PPPIOCGUNIT ioctl. And it works in this way if IFLA_IFNAME is not specified at all. But it does not work when IFLA_IFNAME is specified with empty string. So fix this logic also for empty IFLA_IFNAME in ppp_nl_newlink() function and correctly generates ifname based on ppp unit identifier if userspace did not provided preferred ifname. Without this patch when IFLA_IFNAME was specified with empty string then kernel created a new ppp interface in format "ppp<id>" but id did not match ppp unit id returned by PPPIOCGUNIT ioctl. In this case id was some number generated by __rtnl_newlink() function. Signed-off-by: Pali Rohár <pali@kernel.org> Fixes: bb8082f691 ("ppp: build ifname using unit identifier for rtnl based devices") Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org>		2021-08-18 08:59:10 +02:00
..
bsd_comp.c
Kconfig	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
Makefile
ppp_async.c	tty: convert tty_ldisc_ops 'read()' function to take a kernel pointer	2021-03-04 11:37:36 +01:00
ppp_deflate.c
ppp_generic.c	ppp: Fix generating ifname when empty IFLA_IFNAME is specified	2021-08-18 08:59:10 +02:00
ppp_mppe.c	mm, treewide: rename kzfree() to kfree_sensitive()	2020-08-07 11:33:22 -07:00
ppp_mppe.h
ppp_synctty.c	tty: convert tty_ldisc_ops 'read()' function to take a kernel pointer	2021-03-04 11:37:36 +01:00
pppoe.c	net: make ->{get,set}sockopt in proto_ops optional	2020-07-19 18:16:41 -07:00
pppox.c
pptp.c	net: make ->{get,set}sockopt in proto_ops optional	2020-07-19 18:16:41 -07:00