Lyude Paul 2b84fd62aa igb: Free IRQs when device is hotplugged ... commit 888f229314 upstream. Recently I got a Caldigit TS3 Thunderbolt 3 dock, and noticed that upon hotplugging my kernel would immediately crash due to igb: [ 680.825801] kernel BUG at drivers/pci/msi.c:352! [ 680.828388] invalid opcode: 0000 [#1] SMP [ 680.829194] Modules linked in: igb(O) thunderbolt i2c_algo_bit joydev vfat fat btusb btrtl btbcm btintel bluetooth ecdh_generic hp_wmi sparse_keymap rfkill wmi_bmof iTCO_wdt intel_rapl x86_pkg_temp_thermal coretemp crc32_pclmul snd_pcm rtsx_pci_ms mei_me snd_timer memstick snd pcspkr mei soundcore i2c_i801 tpm_tis psmouse shpchp wmi tpm_tis_core tpm video hp_wireless acpi_pad rtsx_pci_sdmmc mmc_core crc32c_intel serio_raw rtsx_pci mfd_core xhci_pci xhci_hcd i2c_hid i2c_core [last unloaded: igb] [ 680.831085] CPU: 1 PID: 78 Comm: kworker/u16:1 Tainted: G O 4.15.0-rc3Lyude-Test+ #6 [ 680.831596] Hardware name: HP HP ZBook Studio G4/826B, BIOS P71 Ver. 01.03 06/09/2017 [ 680.832168] Workqueue: kacpi_hotplug acpi_hotplug_work_fn [ 680.832687] RIP: 0010:free_msi_irqs+0x180/0x1b0 [ 680.833271] RSP: 0018:ffffc9000030fbf0 EFLAGS: 00010286 [ 680.833761] RAX: ffff8803405f9c00 RBX: ffff88033e3d2e40 RCX: 000000000000002c [ 680.834278] RDX: 0000000000000000 RSI: 00000000000000ac RDI: ffff880340be2178 [ 680.834832] RBP: 0000000000000000 R08: ffff880340be1ff0 R09: ffff8803405f9c00 [ 680.835342] R10: 0000000000000000 R11: 0000000000000040 R12: ffff88033d63a298 [ 680.835822] R13: ffff88033d63a000 R14: 0000000000000060 R15: ffff880341959000 [ 680.836332] FS: 0000000000000000(0000) GS:ffff88034f440000(0000) knlGS:0000000000000000 [ 680.836817] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 680.837360] CR2: 000055e64044afdf CR3: 0000000001c09002 CR4: 00000000003606e0 [ 680.837954] Call Trace: [ 680.838853] pci_disable_msix+0xce/0xf0 [ 680.839616] igb_reset_interrupt_capability+0x5d/0x60 [igb] [ 680.840278] igb_remove+0x9d/0x110 [igb] [ 680.840764] pci_device_remove+0x36/0xb0 [ 680.841279] device_release_driver_internal+0x157/0x220 [ 680.841739] pci_stop_bus_device+0x7d/0xa0 [ 680.842255] pci_stop_bus_device+0x2b/0xa0 [ 680.842722] pci_stop_bus_device+0x3d/0xa0 [ 680.843189] pci_stop_and_remove_bus_device+0xe/0x20 [ 680.843627] trim_stale_devices+0xf3/0x140 [ 680.844086] trim_stale_devices+0x94/0x140 [ 680.844532] trim_stale_devices+0xa6/0x140 [ 680.845031] ? get_slot_status+0x90/0xc0 [ 680.845536] acpiphp_check_bridge.part.5+0xfe/0x140 [ 680.846021] acpiphp_hotplug_notify+0x175/0x200 [ 680.846581] ? free_bridge+0x100/0x100 [ 680.847113] acpi_device_hotplug+0x8a/0x490 [ 680.847535] acpi_hotplug_work_fn+0x1a/0x30 [ 680.848076] process_one_work+0x182/0x3a0 [ 680.848543] worker_thread+0x2e/0x380 [ 680.848963] ? process_one_work+0x3a0/0x3a0 [ 680.849373] kthread+0x111/0x130 [ 680.849776] ? kthread_create_worker_on_cpu+0x50/0x50 [ 680.850188] ret_from_fork+0x1f/0x30 [ 680.850601] Code: 43 14 85 c0 0f 84 d5 fe ff ff 31 ed eb 0f 83 c5 01 39 6b 14 0f 86 c5 fe ff ff 8b 7b 10 01 ef e8 b7 e4 d2 ff 48 83 78 70 00 74 e3 <0f> 0b 49 8d b5 a0 00 00 00 e8 62 6f d3 ff e9 c7 fe ff ff 48 8b [ 680.851497] RIP: free_msi_irqs+0x180/0x1b0 RSP: ffffc9000030fbf0 As it turns out, normally the freeing of IRQs that would fix this is called inside of the scope of __igb_close(). However, since the device is already gone by the point we try to unregister the netdevice from the driver due to a hotplug we end up seeing that the netif isn't present and thus, forget to free any of the device IRQs. So: make sure that if we're in the process of dismantling the netdev, we always allow __igb_close() to be called so that IRQs may be freed normally. Additionally, only allow igb_close() to be called from __igb_close() if it hasn't already been called for the given adapter. Signed-off-by: Lyude Paul <lyude@redhat.com> Fixes: 9474933caf ("igb: close/suspend race in netif_device_detach") Cc: Todd Fujinaka <todd.fujinaka@intel.com> Cc: Stephen Hemminger <stephen@networkplumber.org> Tested-by: Aaron Brown <aaron.f.brown@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2018-02-03 17:04:26 +01:00
..
accessibility
acpi	ACPICA: Namespace: fix operand cache leak	2018-01-31 12:06:10 +01:00
amba
android	ANDROID: binder: fix proc->tsk check.	2017-08-30 10:19:26 +02:00
ata	libata: apply MAX_SEC_1024 to all LITEON EP1 series devices	2018-01-23 19:50:16 +01:00
atm	atm: horizon: Fix irq release error	2017-12-16 10:33:55 +01:00
auxdisplay
base	drivers: base: cacheinfo: fix boot error message when acpi is enabled	2018-01-31 12:06:08 +01:00
bcma	bcma: use (get|put)_device when probing/removing device driver	2017-03-12 06:37:30 +01:00
block	loop: fix concurrent lo_open/lo_release	2018-02-03 17:04:24 +01:00
bluetooth	Revert "Bluetooth: btusb: driver to enable the usb-wakeup feature"	2017-12-25 14:22:15 +01:00
bus	sunxi-rsb: Include OF based modalias in device uevent	2018-01-10 09:27:09 +01:00
cdrom
char	hwrng: core - sleep interruptible in read	2018-01-17 09:35:28 +01:00
clk	clk: tegra: Fix cclk_lp divisor register	2017-12-20 10:04:59 +01:00
clocksource	clockevents/drivers/cs5535: Improve resilience to spurious interrupts	2017-10-27 10:23:17 +02:00
connector
cpufreq	cpufreq: CPPC: add ACPI_PROCESSOR dependency	2017-10-21 17:09:06 +02:00
cpuidle	cpuidle: fix broadcast control when broadcast can not be entered	2017-12-25 14:22:15 +01:00
crypto	crypto: n2 - cure use after free	2018-01-10 09:27:08 +01:00
dca
devfreq
dio
dma	dmaengine: ti-dma-crossbar: Correct am335x/am43xx mux value type	2017-12-20 10:04:58 +01:00
dma-buf
edac	EDAC, i5000, i5400: Fix definition of NRECMEMB register	2017-12-16 10:33:54 +01:00
eisa
extcon	extcon: palmas: Check the parent instance to prevent the NULL	2017-11-21 09:21:18 +01:00
firewire	firewire: net: fix fragmented datagram_size off-by-one	2016-11-10 16:36:35 +01:00
firmware	efi/esrt: Cleanup bad memory map log messages	2017-12-20 10:04:56 +01:00
fmc
fpga
gpio	gpio: ath79: add missing MODULE_DESCRIPTION/LICENSE	2018-02-03 17:04:26 +01:00
gpu	drm/vmwgfx: Potential off by one in vmw_view_add()	2018-01-17 09:35:30 +01:00
hid	HID: xinmo: fix for out of range for THT 2P arcade controller.	2017-12-25 14:22:12 +01:00
hsi
hv	x86/retpoline/hyperv: Convert assembler indirect jumps	2018-01-23 19:50:13 +01:00
hwmon	hwmon: (asus_atk0110) fix uninitialized data access	2017-12-25 14:22:12 +01:00
hwspinlock
hwtracing	intel_th: pci: Add Gemini Lake support	2017-12-20 10:04:54 +01:00
i2c	i2c: riic: fix restart condition	2017-12-16 10:33:53 +01:00
ide
idle	intel_idle: Support for Intel Xeon Phi Processor x200 Product Family	2016-09-15 08:27:46 +02:00
iio	iio: light: fix improper return value	2017-11-30 08:37:27 +00:00
infiniband	IB/srpt: Disable RDMA access by the initiator	2018-01-17 09:35:24 +01:00
input	Input: trackpoint - force 3 buttons if 0 button is reported	2018-01-31 12:06:11 +01:00
iommu	iommu/arm-smmu-v3: Don't free page table ops twice	2018-01-17 09:35:25 +01:00
ipack
irqchip	irqchip/crossbar: Fix incorrect type of register size	2017-12-16 10:33:52 +01:00
isdn	isdn: kcapi: avoid uninitialized data	2017-12-25 14:22:13 +01:00
leds	leds: ktd2692: avoid harmless maybe-uninitialized warning	2017-05-14 13:32:55 +02:00
lguest
lightnvm	lightnvm: put bio before return	2016-09-24 10:07:35 +02:00
macintosh
mailbox	mailbox: handle empty message in tx_tick	2017-08-06 19:19:41 -07:00
mcb
md	dm thin metadata: THIN_MAX_CONCURRENT_LOCKS should be 6	2018-01-23 19:50:17 +01:00
media	usbvision fix overflow of interfaces array	2018-01-17 09:35:27 +01:00
memory	ARM: OMAP2+: gpmc-onenand: propagate error on initialization failure	2017-12-16 10:33:51 +01:00
memstick	memstick: rtsx_usb_ms: Manage runtime PM when accessing the device	2016-10-28 03:01:35 -04:00
message
mfd	mfd: twl6040: Fix child-node lookup	2018-01-02 20:33:20 +01:00
misc	cxl: Check if vphb exists before iterating over AFU devices	2017-12-25 14:22:08 +01:00
mmc	mmc: sdhci-of-esdhc: add/remove some quirks according to vendor version	2018-01-31 12:06:09 +01:00
mtd	mtd: nand: denali_pci: add missing MODULE_DESCRIPTION/AUTHOR/LICENSE	2018-02-03 17:04:26 +01:00
net	igb: Free IRQs when device is hotplugged	2018-02-03 17:04:26 +01:00
nfc	nfc: fdp: fix NULL pointer dereference	2017-08-06 19:19:40 -07:00
ntb	ntb_transport: fix bug calculating num_qps_mw	2017-08-30 10:19:29 +02:00
nubus
nvdimm	libnvdimm, namespace: make 'resource' attribute only readable by root	2017-11-30 08:37:23 +00:00
nvme	nvme: Fix memory order on async queue deletion	2017-11-24 08:32:25 +01:00
nvmem	nvmem: imx-ocotp: Fix wrong register size	2017-08-06 19:19:46 -07:00
of	of: device: Export of_device_{get_modalias, uvent_modalias} to modules	2017-07-27 15:06:09 -07:00
oprofile
parisc	parisc: Hide Diva-built-in serial aux and graphics card	2018-01-02 20:33:20 +01:00
parport	parisc, parport_gsc: Fixes for printk continuation lines	2017-06-17 06:39:37 +02:00
pci	PCI: layerscape: Fix MSG TLP drop setting	2018-01-31 12:06:08 +01:00
pcmcia
perf	drivers/perf: arm_pmu: Fix leak in error path	2016-10-07 15:23:41 +02:00
phy	phy: work around 'phys' references to usb-nop-xceiv devices	2018-01-23 19:50:16 +01:00
pinctrl	pinctrl: st: add irq_request/release_resources callbacks	2017-12-25 14:22:11 +01:00
platform	platform/x86: hp-wmi: Do not shadow error values	2017-11-15 17:13:11 +01:00
pnp
power	power: reset: zx-reboot: add missing MODULE_DESCRIPTION/AUTHOR/LICENSE	2018-02-03 17:04:25 +01:00
powercap
pps
ps3
ptp
pwm	pwm: pca9685: Fix period change with same duty cycle	2017-03-15 09:57:14 +08:00
rapidio
ras
regulator	regulator: fan53555: fix I2C device ids	2017-11-02 09:40:50 +01:00
remoteproc
reset
rpmsg
rtc	rtc: set the alarm to the next expiring timer	2017-12-25 14:22:15 +01:00
s390	s390/qeth: no ETH header for outbound AF_IUCV	2017-12-25 14:22:12 +01:00
sbus
scsi	scsi: libiscsi: fix shifting of DID_REQUEUE host byte	2018-01-31 12:06:11 +01:00
sfi
sh
sn
soc	soc: qcom/spm: shut up uninitialized variable warning	2016-09-24 10:07:42 +02:00
spi	spi: xilinx: Detect stall with Unknown commands	2018-01-02 20:33:21 +01:00
spmi	spmi: Include OF based modalias in device uevent	2017-07-27 15:06:10 -07:00
ssb	ssb: Fix error routine when fallback SPROM fails	2017-01-09 08:07:42 +01:00
staging	staging: android: ashmem: fix a race condition in ASHMEM_SET_SIZE ioctl	2018-01-17 09:35:32 +01:00
target	target: Avoid early CMD_T_PRE_EXECUTE failures during ABORT_TASK	2018-01-17 09:35:31 +01:00
tc
thermal	thermal: hisilicon: Handle return value of clk_prepare_enable	2017-12-25 14:22:15 +01:00
thunderbolt
tty	sysrq: Fix warning in sysrq generated crash.	2018-01-17 09:35:28 +01:00
uio	uio: fix dmem_region_start computation	2016-10-31 04:13:59 -06:00
usb	usbip: prevent leaking socket pointer address in messages	2018-01-31 12:06:12 +01:00
uwb	uwb: ensure that endpoint is interrupt	2017-10-12 11:27:35 +02:00
vfio	vfio-pci: Handle error from pci_iomap	2017-08-06 19:19:46 -07:00
vhost	fix a page leak in vhost_scsi_iov_to_sgl() error recovery	2017-11-30 08:37:22 +00:00
video	backlight: pwm_bl: Fix overflow condition	2017-12-25 14:22:13 +01:00
virt
virtio	virtio: release virtio index when fail to device_register	2017-12-16 10:33:48 +01:00
vlynq
vme	vme: Fix wrong pointer utilization in ca91cx42_slave_get	2017-01-19 20:17:21 +01:00
w1	w1: ds2490: USB transfer buffers need to be DMAable	2017-03-12 06:37:29 +01:00
watchdog	watchdog: kempld: fix gcc-4.3 build	2017-10-21 17:09:04 +02:00
xen	xen: xenbus driver must not accept invalid transaction ids	2017-11-30 08:37:28 +00:00
zorro
Kconfig
Makefile	usb: Make sure usb/phy/of gets built-in	2017-05-20 14:26:59 +02:00