linux-uconsole/drivers/firmware/google
Stephen Boyd 1da803c62b firmware: coreboot: Unmap ioregion after device population
[ Upstream commit 20edec3882 ]

Both callers of coreboot_table_init() ioremap the pointer that comes in
but they don't unmap the memory on failure. Both of them also fail probe
immediately with the return value of coreboot_table_init(), leaking a
mapping when it fails. The mapping isn't necessary at all after devices
are populated either, so we can just drop the mapping here when we exit
the function. Let's do that to simplify the code a bit and plug the leak.

Cc: Wei-Ning Huang <wnhuang@chromium.org>
Cc: Julius Werner <jwerner@chromium.org>
Cc: Brian Norris <briannorris@chromium.org>
Cc: Samuel Holland <samuel@sholland.org>
Fixes: 570d30c282 ("firmware: coreboot: Expose the coreboot table as a bus")
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Julius Werner <jwerner@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2018-11-13 11:08:37 -08:00
..
coreboot_table-acpi.c firmware: coreboot: Expose the coreboot table as a bus 2018-04-23 13:37:19 +02:00
coreboot_table-of.c firmware: coreboot: Expose the coreboot table as a bus 2018-04-23 13:37:19 +02:00
coreboot_table.c firmware: coreboot: Unmap ioregion after device population 2018-11-13 11:08:37 -08:00
coreboot_table.h firmware: coreboot: Add coreboot framebuffer driver 2018-04-23 13:37:19 +02:00
framebuffer-coreboot.c firmware: coreboot: Add coreboot framebuffer driver 2018-04-23 13:37:19 +02:00
gsmi.c dmi: Mark all struct dmi_system_id instances const 2017-09-14 11:59:30 +02:00
Kconfig firmware: coreboot: Add coreboot framebuffer driver 2018-04-23 13:37:19 +02:00
Makefile firmware: coreboot: Add coreboot framebuffer driver 2018-04-23 13:37:19 +02:00
memconsole-coreboot.c firmware: memconsole: Probe via coreboot bus 2018-04-23 13:37:19 +02:00
memconsole-x86-legacy.c dmi: Mark all struct dmi_system_id instances const 2017-09-14 11:59:30 +02:00
memconsole.c firmware: google: memconsole: Make memconsole interface more flexible 2017-05-18 16:59:06 +02:00
memconsole.h firmware: google: memconsole: Make memconsole interface more flexible 2017-05-18 16:59:06 +02:00
vpd.c firmware: vpd: Fix section enabled flag on vpd_section_destroy 2018-08-02 10:34:12 +02:00
vpd_decode.c firmware: Google VPD: import lib_vpd source files 2017-04-18 18:04:45 +02:00
vpd_decode.h firmware: Google VPD: import lib_vpd source files 2017-04-18 18:04:45 +02:00