Yoshihiro Shimoda 5c9dc6379f phy: renesas: rcar-gen3-usb2: fix imbalance powered flag ... The powered flag should be set for any other phys anyway. Also the flag should be locked by the channel. Otherwise, after we have revised the device tree for the usb phy, the following warning happened during a second system suspend. And if the driver doesn't lock the flag, an imbalance is possible when enabling the regulator during system resume. So, this patch fixes the issues. < The warning > [ 56.026531] unbalanced disables for USB20_VBUS0 [ 56.031108] WARNING: CPU: 3 PID: 513 at drivers/regulator/core.c:2593 _regula tor_disable+0xe0/0x1c0 [ 56.040146] Modules linked in: rcar_du_drm rcar_lvds drm_kms_helper drm drm_p anel_orientation_quirks vsp1 videobuf2_vmalloc videobuf2_dma_contig videobuf2_me mops videobuf2_v4l2 videobuf2_common videodev snd_soc_rcar renesas_usbhs snd_soc _audio_graph_card media snd_soc_simple_card_utils crct10dif_ce renesas_usb3 snd_ soc_ak4613 rcar_fcp pwm_rcar usb_dmac phy_rcar_gen3_usb3 pwm_bl ipv6 [ 56.074047] CPU: 3 PID: 513 Comm: kworker/u16:19 Not tainted 5.2.0-rc3-00001- g5f20a19 #6 [ 56.082129] Hardware name: Renesas Salvator-X board based on r8a7795 ES2.0+ ( DT) [ 56.089524] Workqueue: events_unbound async_run_entry_fn [ 56.094832] pstate: 40000005 (nZcv daif -PAN -UAO) [ 56.099617] pc : _regulator_disable+0xe0/0x1c0 [ 56.104054] lr : _regulator_disable+0xe0/0x1c0 [ 56.108489] sp : ffff0000121c3ae0 [ 56.111796] x29: ffff0000121c3ae0 x28: 0000000000000000 [ 56.117102] x27: 0000000000000000 x26: ffff000010fe0e60 [ 56.122407] x25: 0000000000000002 x24: 0000000000000001 [ 56.127712] x23: 0000000000000002 x22: ffff8006f99d4000 [ 56.133017] x21: ffff8006f99cc000 x20: ffff8006f9846800 [ 56.138322] x19: ffff8006f9846800 x18: ffffffffffffffff [ 56.143626] x17: 0000000000000000 x16: 0000000000000000 [ 56.148931] x15: ffff0000112f96c8 x14: ffff0000921c37f7 [ 56.154235] x13: ffff0000121c3805 x12: ffff000011312000 [ 56.159540] x11: 0000000005f5e0ff x10: ffff0000112f9f20 [ 56.164844] x9 : ffff0000112d3018 x8 : 00000000000001ad [ 56.170149] x7 : 00000000ffffffcc x6 : ffff8006ff768180 [ 56.175453] x5 : ffff8006ff768180 x4 : 0000000000000000 [ 56.180758] x3 : ffff8006ff76ef10 x2 : ffff8006ff768180 [ 56.186062] x1 : 3d2eccbaead8fb00 x0 : 0000000000000000 [ 56.191367] Call trace: [ 56.193808] _regulator_disable+0xe0/0x1c0 [ 56.197899] regulator_disable+0x40/0x78 [ 56.201820] rcar_gen3_phy_usb2_power_off+0x3c/0x50 [ 56.206692] phy_power_off+0x48/0xd8 [ 56.210263] usb_phy_roothub_power_off+0x30/0x50 [ 56.214873] usb_phy_roothub_suspend+0x1c/0x50 [ 56.219311] hcd_bus_suspend+0x13c/0x168 [ 56.223226] generic_suspend+0x4c/0x58 [ 56.226969] usb_suspend_both+0x1ac/0x238 [ 56.230972] usb_suspend+0xcc/0x170 [ 56.234455] usb_dev_suspend+0x10/0x18 [ 56.238199] dpm_run_callback.isra.6+0x20/0x68 [ 56.242635] __device_suspend+0x110/0x308 [ 56.246637] async_suspend+0x24/0xa8 [ 56.250205] async_run_entry_fn+0x40/0xf8 [ 56.254210] process_one_work+0x1e0/0x320 [ 56.258211] worker_thread+0x40/0x450 [ 56.261867] kthread+0x124/0x128 [ 56.265094] ret_from_fork+0x10/0x18 [ 56.268661] ---[ end trace 86d7ec5de5c517af ]--- [ 56.273290] phy phy-ee080200.usb-phy.10: phy poweroff failed --> -5 Reported-by: Geert Uytterhoeven <geert+renesas@glider.be> Fixes: 549b6b55b0 ("phy: renesas: rcar-gen3-usb2: enable/disable independent irqs") Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Tested-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Simon Horman <horms+renesas@verge.net.au> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>		2019-06-21 10:51:58 +05:30
..
allwinner	phy: for 5.1-rc	2019-04-25 11:27:48 +02:00
amlogic	phy: phy-meson-gxl-usb2: get optional clock by devm_clk_get_optional()	2019-04-17 14:13:16 +05:30
broadcom	phy: usb: phy-brcm-usb: Fix platform_no_drv_owner.cocci warnings	2019-06-20 14:13:59 +05:30
cadence	phy: Add Cadence D-PHY support	2019-02-07 11:11:06 +05:30
freescale	phy: fsl-imx8mq-usb: add support for VBUS power control	2019-04-18 22:08:25 +05:30
hisilicon	phy: Add usb phy support for hi3660 Soc of Hisilicon	2019-04-18 22:08:25 +05:30
lantiq	phy: lantiq: Fix compile warning	2018-09-26 13:09:39 +05:30
marvell	phy: fix platform_no_drv_owner.cocci warnings	2019-04-17 12:06:02 +05:30
mediatek	scsi: phy: mediatek: fix typo in author's email address	2019-04-18 22:08:25 +05:30
motorola	phy: mapphone-mdm6600: add gpiolib dependency	2019-04-17 12:06:02 +05:30
mscc	phy: ocelot-serdes: Add support for SERDES6G muxing	2019-04-18 22:08:25 +05:30
qualcomm	phy: qcom-qmp: Drop useless msm8998_pciephy_cfg setting	2019-06-21 10:51:58 +05:30
ralink	phy: add 'depends on HAS_IOMEM' to fix unmet dependency	2018-03-16 13:40:45 +05:30
renesas	phy: renesas: rcar-gen3-usb2: fix imbalance powered flag	2019-06-21 10:51:58 +05:30
rockchip	USB/PHY patches for 5.2-rc1	2019-05-08 10:03:52 -07:00
samsung	phy: samsung: Use struct_size() in devm_kzalloc()	2019-06-20 14:13:57 +05:30
socionext	phy: socionext: get optional clock by devm_clk_get_optional()	2019-04-17 14:13:15 +05:30
st	phy: stm32: fix usbphyc static checker and checkpatch warnings	2018-05-20 21:51:25 +05:30
tegra	phy: tegra: xusb: Add Tegra186 support	2019-04-17 14:12:47 +05:30
ti	phy: ti: am654-serdes: Make serdes_am654_xlate() static	2019-06-21 10:51:14 +05:30
Kconfig	phy: dphy: Add configuration helpers	2018-12-12 10:01:51 +05:30
Makefile	phy: dphy: Add configuration helpers	2018-12-12 10:01:51 +05:30
phy-core-mipi-dphy.c	phy: dphy: Change units of wakeup and init parameters	2019-02-07 11:11:05 +05:30
phy-core.c	phy: core: Invoke pm_runtime_get_*/pm_runtime_put_* before invoking reset callback	2019-04-17 14:13:17 +05:30
phy-lpc18xx-usb-otg.c	phy: lpc18xx-usb-otg: error handling in lpc18xx_usb_otg_phy_power_on()	2018-03-16 13:40:42 +05:30
phy-pistachio-usb.c	PHY: Add driver for Pistachio USB2.0 PHY	2015-06-21 21:53:38 +02:00
phy-xgene.c	phy: xgene: rename "enum phy_mode" to "enum xgene_phy_mode"	2016-07-04 17:19:21 +05:30