forge/linux-uconsole
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions

netfilter: nftables: fix a warning message in nf_tables_commit_audit_collect()

Browse source 
commit dadf33c9f6 upstream.

The first argument of a WARN_ONCE() is a condition.  This WARN_ONCE()
will only print the table name, and is potentially problematic if the
table name has a %s in it.

Fixes: c520292f29 ("audit: log nftables configuration change events once per table")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Paul Moore <paul@paul-moore.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Dan Carpenter 2021-04-02 14:45:44 +03:00 • committed by Greg Kroah-Hartman
commit f3d0db3b43
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
net/netfilter/nf_tables_api.c
View file

@ -7828,7 +7828,7 @@ static void nf_tables_commit_audit_collect(struct list_head *adl,
if (adp->table == table)
goto found;
}
WARN_ONCE("table=%s not expected in commit list", table->name);
WARN_ONCE(1, "table=%s not expected in commit list", table->name);
return;
found:
adp->entries++;