forge/linux-uconsole
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions

UPSTREAM: modpost: turn static exports into error

Browse source 
Using EXPORT_SYMBOL*() on static functions is fundamentally wrong.
Modpost currently reports that as a warning, but clearly this is not a
pattern we should allow, and all in-tree occurences should have been
fixed by now. So, promote the warn() message to error() to make sure
this never happens again.

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Matthias Maennich <maennich@google.com>
Signed-off-by: Quentin Perret <qperret@google.com>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

Bug: 176428324
Change-Id: I0084ff44b38e68ac2e2ed1818a7cc1bd09cfb58c
(cherry picked from commit b9ed847b5a)
Signed-off-by: Melody Olvera <molvera@codeaurora.org>
This commit is contained in:
Quentin Perret 2020-12-01 16:52:22 +00:00
commit ef84e87362
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
scripts/mod/modpost.c
View file

@ -2645,9 +2645,9 @@ int main(int argc, char **argv)
for (s = symbolhash[n]; s; s = s->next) {
if (s->is_static)
warn("\"%s\" [%s] is a static %s\n",
s->name, s->module->name,
export_str(s->export));
error("\"%s\" [%s] is a static %s\n",
s->name, s->module->name,
export_str(s->export));
}
}