forge/linux-uconsole
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions

watchdog: dw_wdt: fix overflow issue in dw_wdt_top_in_seconds

Browse source 
If top is 15, (1 << (16 + top)) may be negative.

Change-Id: I76e4a603a54f093e64a4b266008570e3afcdb35a
Signed-off-by: Huibin Hong <huibin.hong@rock-chips.com>
This commit is contained in:
Huibin Hong 2017-07-27 20:27:09 +08:00 • committed by Huang, Tao
commit e8b7cbd64a
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
drivers/watchdog/dw_wdt.c
View file

@ -81,7 +81,9 @@ static inline int dw_wdt_top_in_seconds(unsigned top)
* There are 16 possible timeout values in 0..15 where the number of
* cycles is 2 ^ (16 + i) and the watchdog counts down.
*/
return (1 << (16 + top)) / clk_get_rate(dw_wdt.clk);
unsigned int cycles = 1 << (16 + top);
return cycles / clk_get_rate(dw_wdt.clk);
}
static int dw_wdt_get_top(void)