forge/linux-uconsole
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions

staging: comedi: ni_stc.h: remove unreachable code in RTSI_Output_Bit()

Browse source 
All the callers of this function check the 'channel' number with
num_configurable_rtsi_channels(). This check can never occure.
Remove it.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
H Hartley Sweeten 2015-05-01 14:59:13 -07:00 • committed by Greg Kroah-Hartman
commit e2bdb0d833
1 changed files with 0 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
drivers/staging/comedi/drivers/ni_stc.h
View file

@ -352,10 +352,6 @@ static inline unsigned RTSI_Output_Bit(unsigned channel, int is_mseries)
base_bit_shift = 9;
max_channel = 6;
}
if (channel > max_channel) {
pr_err("%s: bug, invalid RTSI_channel=%i\n", __func__, channel);
return 0;
}
return 1 << (base_bit_shift + channel);
}