forge/linux-uconsole
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions

BACKPORT: f2fs: do not submit NEW_ADDR to read node block

Browse source 
After the below patch, give cp is errored, we drop dirty node pages. This
can give NEW_ADDR to read node pages. Don't do WARN_ON() which gives
generic/475 failure.

Fixes: 28607bf3aa ("f2fs: drop dirty node pages when cp is in error status")
Reviewed-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
(cherry picked from commit b7ec206173)
Change-Id: If991a70331933a64899864411d2b5d63ea5b3abf
This commit is contained in:
Jaegeuk Kim 2021-07-26 09:12:15 -07:00 • committed by Jaegeuk Kim
commit da05d408ee
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
fs/f2fs/node.c
View file

@ -1335,7 +1335,8 @@ static int read_node_page(struct page *page, int op_flags)
if (err) if (err)
return err; return err;
if (unlikely(ni.blk_addr == NULL_ADDR) || /* NEW_ADDR can be seen, after cp_error drops some dirty node pages */
if (unlikely(ni.blk_addr == NULL_ADDR || ni.blk_addr == NEW_ADDR) ||
is_sbi_flag_set(sbi, SBI_IS_SHUTDOWN)) { is_sbi_flag_set(sbi, SBI_IS_SHUTDOWN)) {
ClearPageUptodate(page); ClearPageUptodate(page);
return -ENOENT; return -ENOENT;