forge/linux-uconsole
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions

coredump: Remove the WARN_ON in dump_vma_snapshot

Browse source 
commit 49c1866348 upstream.

The condition is impossible and to the best of my knowledge has never
triggered.

We are in deep trouble if that conditions happens and we walk past
the end of our allocated array.

So delete the WARN_ON and the code that makes it look like the kernel
can handle the case of walking past the end of it's vma_meta array.

Reviewed-by: Jann Horn <jannh@google.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Eric W. Biederman 2022-03-08 13:01:19 -06:00 • committed by Greg Kroah-Hartman
commit b043ae637a
1 changed files with 0 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

6
fs/coredump.c
View file

@ -1128,12 +1128,6 @@ static bool dump_vma_snapshot(struct coredump_params *cprm)
mmap_write_unlock(mm);
if (WARN_ON(i != cprm->vma_count)) {
kvfree(cprm->vma_meta);
return false;
}
for (i = 0; i < cprm->vma_count; i++) {
struct core_vma_metadata *m = cprm->vma_meta + i;