forge/linux-uconsole
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions

staging: comedi: s526: define the DAC (analog output) control register and bits

Browse source 
Define this register and its bits and remove the magic numbers.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
H Hartley Sweeten 2015-08-17 16:58:14 -07:00 • committed by Greg Kroah-Hartman
commit abbb648909
1 changed files with 8 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

12
drivers/staging/comedi/drivers/s526.c
View file

@ -56,7 +56,10 @@
#define S526_WDOG_INVERTED BIT(4)
#define S526_WDOG_ENA BIT(3)
#define S526_WDOG_INTERVAL(x) (((x) & 0x7) << 0)
#define REG_DAC 0x04
#define S526_AO_CTRL_REG 0x04
#define S526_AO_CTRL_RESET BIT(3)
#define S526_AO_CTRL_CHAN(x) (((x) & 0x3) << 1)
#define S526_AO_CTRL_START BIT(0)
#define REG_ADC 0x06
#define REG_ADD 0x08
#define REG_DIO 0x0A
@ -452,16 +455,17 @@ static int s526_ao_insn_write(struct comedi_device *dev,
unsigned int *data)
{
unsigned int chan = CR_CHAN(insn->chanspec);
unsigned int ctrl = S526_AO_CTRL_CHAN(chan);
unsigned int val = s->readback[chan];
int i;
outw(chan << 1, dev->iobase + REG_DAC);
outw(ctrl, dev->iobase + S526_AO_CTRL_REG);
ctrl |= S526_AO_CTRL_START;
for (i = 0; i < insn->n; i++) {
val = data[i];
outw(val, dev->iobase + REG_ADD);
/* starts the D/A conversion */
outw((chan << 1) | 1, dev->iobase + REG_DAC);
outw(ctrl, dev->iobase + S526_AO_CTRL_REG);
}
s->readback[chan] = val;