forge/linux-uconsole
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions

staging: comedi: rtd520: remove RtdDacRange macro

Browse source 
This macro uses the 'devpriv' macro which relies on a local variable
having a specific name. Plus it's just a wrapper around a simple
'writew'. Remove the macro.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
H Hartley Sweeten 2012-07-10 17:10:27 -07:00 • committed by Greg Kroah-Hartman
commit 9db311d1c2
1 changed files with 2 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

8
drivers/staging/comedi/drivers/rtd520.c
View file

@ -406,11 +406,6 @@ struct rtdPrivate {
/* Macros to access registers */
/* Set DAC output type and range */
#define RtdDacRange(dev, n, v) \
writew((v) & 7, devpriv->las0 \
+(((n) == 0) ? LAS0_DAC1_CTRL : LAS0_DAC2_CTRL))
/* Reset DAC FIFO */
#define RtdDacClearFifo(dev, n) \
writel(0, devpriv->las0+(((n) == 0) ? LAS0_DAC1_RESET : \
@ -1538,7 +1533,8 @@ static int rtd_ao_winsn(struct comedi_device *dev,
int range = CR_RANGE(insn->chanspec);
/* Configure the output range (table index matches the range values) */
RtdDacRange(dev, chan, range);
writew(range & 7, devpriv->las0 +
((chan == 0) ? LAS0_DAC1_CTRL : LAS0_DAC2_CTRL));
/* Writing a list of values to an AO channel is probably not
* very useful, but that's how the interface is defined. */