forge/linux-uconsole
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions

selftests/bpf: Fix fclose/pclose mismatch in test_progs

Browse source 
[ Upstream commit f48ad69097 ]

Make sure to use pclose() to properly close the pipe opened by popen().

Fixes: 81f77fd0de ("bpf: add selftest for stackmap with BPF_F_STACK_BUILD_ID")
Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
Acked-by: Martin KaFai Lau <kafai@fb.com>
Link: https://lore.kernel.org/bpf/20211026143409.42666-1-andrea.righi@canonical.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Andrea Righi 2021-10-26 16:34:09 +02:00 • committed by Greg Kroah-Hartman
commit 8f3d88139d
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
tools/testing/selftests/bpf/test_progs.c
View file

@ -347,7 +347,7 @@ int extract_build_id(char *build_id, size_t size)
if (getline(&line, &len, fp) == -1)
goto err;
fclose(fp);
pclose(fp);
if (len > size)
len = size;
@ -356,7 +356,7 @@ int extract_build_id(char *build_id, size_t size)
free(line);
return 0;
err:
fclose(fp);
pclose(fp);
return -1;
}