forge/linux-uconsole
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions

niu: Fix missing unwind goto in niu_alloc_channels()

Browse source 
[ Upstream commit 8ce07be703 ]

Smatch reports: drivers/net/ethernet/sun/niu.c:4525
	niu_alloc_channels() warn: missing unwind goto?

If niu_rbr_fill() fails, then we are directly returning 'err' without
freeing the channels.

Fix this by changing direct return to a goto 'out_err'.

Fixes: a3138df9f2 ("[NIU]: Add Sun Neptune ethernet driver.")
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Harshit Mogalapalli 2023-04-05 23:31:18 -07:00 • committed by Greg Kroah-Hartman
commit 8a1fdb3545
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
drivers/net/ethernet/sun/niu.c
View file

@ -4503,7 +4503,7 @@ static int niu_alloc_channels(struct niu *np)
err = niu_rbr_fill(np, rp, GFP_KERNEL); err = niu_rbr_fill(np, rp, GFP_KERNEL);
if (err) if (err)
return err; goto out_err;
} }
tx_rings = kcalloc(num_tx_rings, sizeof(struct tx_ring_info), tx_rings = kcalloc(num_tx_rings, sizeof(struct tx_ring_info),