forge/linux-uconsole
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions

selftests/resctrl: Fix compilation issues for other global variables

Browse source 
[ Upstream commit 896016d2ad ]

Reinette reported following compilation issue on Fedora 32, gcc version
10.1.1

/usr/bin/ld: resctrl_tests.o:<src_dir>/resctrl.h:65: multiple definition
of `bm_pid'; cache.o:<src_dir>/resctrl.h:65: first defined here

Other variables are ppid, tests_run, llc_occup_path, is_amd. Compiler
isn't happy because these variables are defined globally in two .c files
but are not declared as extern.

To fix issues for the global variables, declare them as extern.

Chang Log:
- Split this patch from v4's patch 1 (Shuah).

Reported-by: Reinette Chatre <reinette.chatre@intel.com>
Tested-by: Babu Moger <babu.moger@amd.com>
Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Fenghua Yu 2021-03-17 02:22:37 +00:00 • committed by Greg Kroah-Hartman
commit 6ef95f0b80
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
tools/testing/selftests/resctrl/resctrl.h
View file

@ -62,11 +62,11 @@ struct resctrl_val_param {
int (*setup)(int num, ...);
};
pid_t bm_pid, ppid;
int tests_run;
extern pid_t bm_pid, ppid;
extern int tests_run;
char llc_occup_path[1024];
bool is_amd;
extern char llc_occup_path[1024];
extern bool is_amd;
bool check_resctrlfs_support(void);
int filter_dmesg(void);