forge/linux-uconsole
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions

staging: wilc1000: remove goto from wlan_initialize_threads

Browse source 
This patch remove goto feature from wlan_initialize_threads function.
Goto feature is 'wilc->close=0' & return result.
So, remove goto feature and it was replaced with the return value directly,
as well as removed unused ret variable.
Also, execute 'wilc->close=0' before return.

Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Leo Kim 2015-11-05 14:36:33 +09:00 • committed by Greg Kroah-Hartman
commit 6bc72c5ac7
1 changed files with 2 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

9
drivers/staging/wilc1000/linux_wlan.c
View file

@ -911,7 +911,6 @@ int wlan_initialize_threads(struct net_device *dev)
{
perInterface_wlan_t *nic;
struct wilc *wilc;
int ret = 0;
nic = netdev_priv(dev);
wilc = nic->wilc;
@ -922,16 +921,12 @@ int wlan_initialize_threads(struct net_device *dev)
"K_TXQ_TASK");
if (!wilc->txq_thread) {
PRINT_ER("couldn't create TXQ thread\n");
ret = -ENOBUFS;
goto _fail_2;
wilc->close = 0;
return -ENOBUFS;
}
down(&wilc->txq_thread_started);
return 0;
_fail_2:
wilc->close = 0;
return ret;
}
static void wlan_deinitialize_threads(struct net_device *dev)