forge/linux-uconsole
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions

staging: comedi: fl512: tidy up fl512_ao_insn_write()

Browse source 
Tidy up this function. Only save the last value written for readback.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
H Hartley Sweeten 2014-03-13 10:09:59 -07:00 • committed by Greg Kroah-Hartman
commit 3ecbbb56cb
1 changed files with 13 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

23
drivers/staging/comedi/drivers/fl512.c
View file

@ -76,20 +76,21 @@ static int fl512_ao_insn_write(struct comedi_device *dev,
unsigned int *data)
{
struct fl512_private *devpriv = dev->private;
int n;
int chan = CR_CHAN(insn->chanspec); /* get chan to write */
unsigned int chan = CR_CHAN(insn->chanspec);
unsigned int val = devpriv->ao_readback[chan];
int i;
for (n = 0; n < insn->n; n++) { /* write n data set */
/* write low byte */
outb(data[n] & 0x0ff, dev->iobase + FL512_AO_DATA_REG(chan));
/* write high byte */
outb((data[n] & 0xf00) >> 8,
dev->iobase + FL512_AO_DATA_REG(chan));
for (i = 0; i < insn->n; i++) {
val = data[i];
/* write LSB, MSB then trigger conversion */
outb(val & 0x0ff, dev->iobase + FL512_AO_DATA_REG(chan));
outb((val >> 8) & 0xf, dev->iobase + FL512_AO_DATA_REG(chan));
inb(dev->iobase + FL512_AO_TRIG_REG(chan));
devpriv->ao_readback[chan] = data[n];
}
return n;
devpriv->ao_readback[chan] = val;
return insn->n;
}
static int fl512_ao_insn_read(struct comedi_device *dev,