forge/linux-uconsole
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions

usb: typec: ucsi: Acknowledge the GET_ERROR_STATUS command completion

Browse source 
commit a7dc438b5e upstream.

We found PPM will not send any notification after it report error status
and OPM issue GET_ERROR_STATUS command to read the details about error.

According UCSI spec, PPM may clear the Error Status Data after the OPM
has acknowledged the command completion.

This change add operation to acknowledge the command completion from PPM.

Fixes: bdc62f2bae (usb: typec: ucsi: Simplified registration and I/O API)
Cc: <stable@vger.kernel.org> # 5.10
Signed-off-by: Jack Pham <quic_jackp@quicinc.com>
Signed-off-by: Linyu Yuan <quic_linyyuan@quicinc.com>
Link: https://lore.kernel.org/r/1658817949-4632-1-git-send-email-quic_linyyuan@quicinc.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Linyu Yuan 2022-07-26 14:45:49 +08:00 • committed by Greg Kroah-Hartman
commit 37c7fe9b31
1 changed files with 4 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
drivers/usb/typec/ucsi/ucsi.c
View file

@ -76,6 +76,10 @@ static int ucsi_read_error(struct ucsi *ucsi)
if (ret) if (ret)
return ret; return ret;
ret = ucsi_acknowledge_command(ucsi);
if (ret)
return ret;
switch (error) { switch (error) {
case UCSI_ERROR_INCOMPATIBLE_PARTNER: case UCSI_ERROR_INCOMPATIBLE_PARTNER:
return -EOPNOTSUPP; return -EOPNOTSUPP;