forge/linux-uconsole
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions

staging/lustre/o2iblnd: leak cmid in kiblnd_dev_need_failover

Browse source 
cmid created by kiblnd_dev_need_failover should always be destroyed,
however it is not the case in current implementation and we will leak
cmid when this function detected a device failover.

Signed-off-by: Liang Zhen <liang.zhen@intel.com>
Reviewed-on: http://review.whamcloud.com/14603
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6480
Reviewed-by: Isaac Huang <he.huang@intel.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Liang Zhen 2015-09-14 18:41:33 -04:00 • committed by Greg Kroah-Hartman
commit 199a0cc08d
1 changed files with 3 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

9
drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c
View file

@ -2228,13 +2228,10 @@ static int kiblnd_dev_need_failover(kib_dev_t *dev)
return rc;
}
if (dev->ibd_hdev->ibh_ibdev == cmid->device) {
/* don't need device failover */
rdma_destroy_id(cmid);
return 0;
}
rc = dev->ibd_hdev->ibh_ibdev != cmid->device; /* true for failover */
rdma_destroy_id(cmid);
return 1;
return rc;
}
int kiblnd_dev_failover(kib_dev_t *dev)