forge/linux-uconsole
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions

staging: comedi: quatech_daqp_cs: use comedi_offset_munge() in ao (*insn_write)

Browse source 
Use the comedi_offset_munge() helper to do the offset binary to two's
complement conversion when writing a new analog output value.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
H Hartley Sweeten 2015-10-05 14:22:51 -07:00 • committed by Greg Kroah-Hartman
commit 1271dd24c6
1 changed files with 3 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

8
drivers/staging/comedi/drivers/quatech_daqp_cs.c
View file

@ -655,11 +655,9 @@ static int daqp_ao_insn_write(struct comedi_device *dev,
s->readback[chan] = val;
val &= 0x0fff;
val ^= 0x0800; /* Flip the sign */
val |= (chan << 12);
outw(val, dev->iobase + DAQP_DA);
/* write the two's complement value to the channel */
outw((chan << 12) | comedi_offset_munge(s, val),
dev->iobase + DAQP_DA);
}
return insn->n;