forge/linux-uconsole
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions

staging: gdm72xx: return -EINVAL instead of BUG_ON for invalid data length

Browse source 
This patch changes gdm_usb_send() and gdm_sdio_send() to return -EINVAL instead
of calling BUG_ON if an invalid data length is passed to the functions.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Reported-by: Michalis Pappas <mpappas@fastmail.fm>
Signed-off-by: Ben Chan <benchan@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Ben Chan 2014-06-27 23:17:24 -07:00 • committed by Greg Kroah-Hartman
commit 0fbce84c6f
2 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
drivers/staging/gdm72xx/gdm_sdio.c
View file

@ -390,7 +390,8 @@ static int gdm_sdio_send(void *priv_dev, void *data, int len,
u16 cmd_evt;
unsigned long flags;
BUG_ON(len > TX_BUF_SIZE - TYPE_A_HEADER_SIZE);
if (len > TX_BUF_SIZE - TYPE_A_HEADER_SIZE)
return -EINVAL;
spin_lock_irqsave(&tx->lock, flags);

3
drivers/staging/gdm72xx/gdm_usb.c
View file

@ -312,7 +312,8 @@ static int gdm_usb_send(void *priv_dev, void *data, int len,
return -ENODEV;
}
BUG_ON(len > TX_BUF_SIZE - padding - 1);
if (len > TX_BUF_SIZE - padding - 1)
return -EINVAL;
spin_lock_irqsave(&tx->lock, flags);