For consistency drop & in front of every proc_handler. Explicity taking the address is unnecessary and it prevents optimizations like stubbing the proc_handlers to NULL. Cc: Alexey Dobriyan <adobriyan@gmail.com> Cc: Ingo Molnar <mingo@elte.hu> Cc: Joe Perches <joe@perches.com> Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
		
			
				
	
	
		
			231 lines
		
	
	
	
		
			5.7 KiB
			
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			231 lines
		
	
	
	
		
			5.7 KiB
			
		
	
	
	
		
			C
		
	
	
	
	
	
/*
 | 
						|
 * Copyright (c) 2001-2005 Silicon Graphics, Inc.
 | 
						|
 * All Rights Reserved.
 | 
						|
 *
 | 
						|
 * This program is free software; you can redistribute it and/or
 | 
						|
 * modify it under the terms of the GNU General Public License as
 | 
						|
 * published by the Free Software Foundation.
 | 
						|
 *
 | 
						|
 * This program is distributed in the hope that it would be useful,
 | 
						|
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 | 
						|
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 | 
						|
 * GNU General Public License for more details.
 | 
						|
 *
 | 
						|
 * You should have received a copy of the GNU General Public License
 | 
						|
 * along with this program; if not, write the Free Software Foundation,
 | 
						|
 * Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
 | 
						|
 */
 | 
						|
#include "xfs.h"
 | 
						|
#include <linux/sysctl.h>
 | 
						|
#include <linux/proc_fs.h>
 | 
						|
 | 
						|
static struct ctl_table_header *xfs_table_header;
 | 
						|
 | 
						|
#ifdef CONFIG_PROC_FS
 | 
						|
STATIC int
 | 
						|
xfs_stats_clear_proc_handler(
 | 
						|
	ctl_table	*ctl,
 | 
						|
	int		write,
 | 
						|
	void		__user *buffer,
 | 
						|
	size_t		*lenp,
 | 
						|
	loff_t		*ppos)
 | 
						|
{
 | 
						|
	int		c, ret, *valp = ctl->data;
 | 
						|
	__uint32_t	vn_active;
 | 
						|
 | 
						|
	ret = proc_dointvec_minmax(ctl, write, buffer, lenp, ppos);
 | 
						|
 | 
						|
	if (!ret && write && *valp) {
 | 
						|
		printk("XFS Clearing xfsstats\n");
 | 
						|
		for_each_possible_cpu(c) {
 | 
						|
			preempt_disable();
 | 
						|
			/* save vn_active, it's a universal truth! */
 | 
						|
			vn_active = per_cpu(xfsstats, c).vn_active;
 | 
						|
			memset(&per_cpu(xfsstats, c), 0,
 | 
						|
			       sizeof(struct xfsstats));
 | 
						|
			per_cpu(xfsstats, c).vn_active = vn_active;
 | 
						|
			preempt_enable();
 | 
						|
		}
 | 
						|
		xfs_stats_clear = 0;
 | 
						|
	}
 | 
						|
 | 
						|
	return ret;
 | 
						|
}
 | 
						|
#endif /* CONFIG_PROC_FS */
 | 
						|
 | 
						|
static ctl_table xfs_table[] = {
 | 
						|
	{
 | 
						|
		.procname	= "irix_sgid_inherit",
 | 
						|
		.data		= &xfs_params.sgid_inherit.val,
 | 
						|
		.maxlen		= sizeof(int),
 | 
						|
		.mode		= 0644,
 | 
						|
		.proc_handler	= proc_dointvec_minmax,
 | 
						|
		.extra1		= &xfs_params.sgid_inherit.min,
 | 
						|
		.extra2		= &xfs_params.sgid_inherit.max
 | 
						|
	},
 | 
						|
	{
 | 
						|
		.procname	= "irix_symlink_mode",
 | 
						|
		.data		= &xfs_params.symlink_mode.val,
 | 
						|
		.maxlen		= sizeof(int),
 | 
						|
		.mode		= 0644,
 | 
						|
		.proc_handler	= proc_dointvec_minmax,
 | 
						|
		.extra1		= &xfs_params.symlink_mode.min,
 | 
						|
		.extra2		= &xfs_params.symlink_mode.max
 | 
						|
	},
 | 
						|
	{
 | 
						|
		.procname	= "panic_mask",
 | 
						|
		.data		= &xfs_params.panic_mask.val,
 | 
						|
		.maxlen		= sizeof(int),
 | 
						|
		.mode		= 0644,
 | 
						|
		.proc_handler	= proc_dointvec_minmax,
 | 
						|
		.extra1		= &xfs_params.panic_mask.min,
 | 
						|
		.extra2		= &xfs_params.panic_mask.max
 | 
						|
	},
 | 
						|
 | 
						|
	{
 | 
						|
		.procname	= "error_level",
 | 
						|
		.data		= &xfs_params.error_level.val,
 | 
						|
		.maxlen		= sizeof(int),
 | 
						|
		.mode		= 0644,
 | 
						|
		.proc_handler	= proc_dointvec_minmax,
 | 
						|
		.extra1		= &xfs_params.error_level.min,
 | 
						|
		.extra2		= &xfs_params.error_level.max
 | 
						|
	},
 | 
						|
	{
 | 
						|
		.procname	= "xfssyncd_centisecs",
 | 
						|
		.data		= &xfs_params.syncd_timer.val,
 | 
						|
		.maxlen		= sizeof(int),
 | 
						|
		.mode		= 0644,
 | 
						|
		.proc_handler	= proc_dointvec_minmax,
 | 
						|
		.extra1		= &xfs_params.syncd_timer.min,
 | 
						|
		.extra2		= &xfs_params.syncd_timer.max
 | 
						|
	},
 | 
						|
	{
 | 
						|
		.procname	= "inherit_sync",
 | 
						|
		.data		= &xfs_params.inherit_sync.val,
 | 
						|
		.maxlen		= sizeof(int),
 | 
						|
		.mode		= 0644,
 | 
						|
		.proc_handler	= proc_dointvec_minmax,
 | 
						|
		.extra1		= &xfs_params.inherit_sync.min,
 | 
						|
		.extra2		= &xfs_params.inherit_sync.max
 | 
						|
	},
 | 
						|
	{
 | 
						|
		.procname	= "inherit_nodump",
 | 
						|
		.data		= &xfs_params.inherit_nodump.val,
 | 
						|
		.maxlen		= sizeof(int),
 | 
						|
		.mode		= 0644,
 | 
						|
		.proc_handler	= proc_dointvec_minmax,
 | 
						|
		.extra1		= &xfs_params.inherit_nodump.min,
 | 
						|
		.extra2		= &xfs_params.inherit_nodump.max
 | 
						|
	},
 | 
						|
	{
 | 
						|
		.procname	= "inherit_noatime",
 | 
						|
		.data		= &xfs_params.inherit_noatim.val,
 | 
						|
		.maxlen		= sizeof(int),
 | 
						|
		.mode		= 0644,
 | 
						|
		.proc_handler	= proc_dointvec_minmax,
 | 
						|
		.extra1		= &xfs_params.inherit_noatim.min,
 | 
						|
		.extra2		= &xfs_params.inherit_noatim.max
 | 
						|
	},
 | 
						|
	{
 | 
						|
		.procname	= "xfsbufd_centisecs",
 | 
						|
		.data		= &xfs_params.xfs_buf_timer.val,
 | 
						|
		.maxlen		= sizeof(int),
 | 
						|
		.mode		= 0644,
 | 
						|
		.proc_handler	= proc_dointvec_minmax,
 | 
						|
		.extra1		= &xfs_params.xfs_buf_timer.min,
 | 
						|
		.extra2		= &xfs_params.xfs_buf_timer.max
 | 
						|
	},
 | 
						|
	{
 | 
						|
		.procname	= "age_buffer_centisecs",
 | 
						|
		.data		= &xfs_params.xfs_buf_age.val,
 | 
						|
		.maxlen		= sizeof(int),
 | 
						|
		.mode		= 0644,
 | 
						|
		.proc_handler	= proc_dointvec_minmax,
 | 
						|
		.extra1		= &xfs_params.xfs_buf_age.min,
 | 
						|
		.extra2		= &xfs_params.xfs_buf_age.max
 | 
						|
	},
 | 
						|
	{
 | 
						|
		.procname	= "inherit_nosymlinks",
 | 
						|
		.data		= &xfs_params.inherit_nosym.val,
 | 
						|
		.maxlen		= sizeof(int),
 | 
						|
		.mode		= 0644,
 | 
						|
		.proc_handler	= proc_dointvec_minmax,
 | 
						|
		.extra1		= &xfs_params.inherit_nosym.min,
 | 
						|
		.extra2		= &xfs_params.inherit_nosym.max
 | 
						|
	},
 | 
						|
	{
 | 
						|
		.procname	= "rotorstep",
 | 
						|
		.data		= &xfs_params.rotorstep.val,
 | 
						|
		.maxlen		= sizeof(int),
 | 
						|
		.mode		= 0644,
 | 
						|
		.proc_handler	= proc_dointvec_minmax,
 | 
						|
		.extra1		= &xfs_params.rotorstep.min,
 | 
						|
		.extra2		= &xfs_params.rotorstep.max
 | 
						|
	},
 | 
						|
	{
 | 
						|
		.procname	= "inherit_nodefrag",
 | 
						|
		.data		= &xfs_params.inherit_nodfrg.val,
 | 
						|
		.maxlen		= sizeof(int),
 | 
						|
		.mode		= 0644,
 | 
						|
		.proc_handler	= proc_dointvec_minmax,
 | 
						|
		.extra1		= &xfs_params.inherit_nodfrg.min,
 | 
						|
		.extra2		= &xfs_params.inherit_nodfrg.max
 | 
						|
	},
 | 
						|
	{
 | 
						|
		.procname	= "filestream_centisecs",
 | 
						|
		.data		= &xfs_params.fstrm_timer.val,
 | 
						|
		.maxlen		= sizeof(int),
 | 
						|
		.mode		= 0644,
 | 
						|
		.proc_handler	= proc_dointvec_minmax,
 | 
						|
		.extra1		= &xfs_params.fstrm_timer.min,
 | 
						|
		.extra2		= &xfs_params.fstrm_timer.max,
 | 
						|
	},
 | 
						|
	/* please keep this the last entry */
 | 
						|
#ifdef CONFIG_PROC_FS
 | 
						|
	{
 | 
						|
		.procname	= "stats_clear",
 | 
						|
		.data		= &xfs_params.stats_clear.val,
 | 
						|
		.maxlen		= sizeof(int),
 | 
						|
		.mode		= 0644,
 | 
						|
		.proc_handler	= xfs_stats_clear_proc_handler,
 | 
						|
		.extra1		= &xfs_params.stats_clear.min,
 | 
						|
		.extra2		= &xfs_params.stats_clear.max
 | 
						|
	},
 | 
						|
#endif /* CONFIG_PROC_FS */
 | 
						|
 | 
						|
	{}
 | 
						|
};
 | 
						|
 | 
						|
static ctl_table xfs_dir_table[] = {
 | 
						|
	{
 | 
						|
		.procname	= "xfs",
 | 
						|
		.mode		= 0555,
 | 
						|
		.child		= xfs_table
 | 
						|
	},
 | 
						|
	{}
 | 
						|
};
 | 
						|
 | 
						|
static ctl_table xfs_root_table[] = {
 | 
						|
	{
 | 
						|
		.procname	= "fs",
 | 
						|
		.mode		= 0555,
 | 
						|
		.child		= xfs_dir_table
 | 
						|
	},
 | 
						|
	{}
 | 
						|
};
 | 
						|
 | 
						|
int
 | 
						|
xfs_sysctl_register(void)
 | 
						|
{
 | 
						|
	xfs_table_header = register_sysctl_table(xfs_root_table);
 | 
						|
	if (!xfs_table_header)
 | 
						|
		return -ENOMEM;
 | 
						|
	return 0;
 | 
						|
}
 | 
						|
 | 
						|
void
 | 
						|
xfs_sysctl_unregister(void)
 | 
						|
{
 | 
						|
	unregister_sysctl_table(xfs_table_header);
 | 
						|
}
 |