Smatch complainst that the call to mantis_evmgr_exit() dereferences "ca" but then we check it for NULL on the next line. I've moved the NULL check forward to avoid that. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
		
			
				
	
	
		
			210 lines
		
	
	
	
		
			5.7 KiB
			
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			210 lines
		
	
	
	
		
			5.7 KiB
			
		
	
	
	
		
			C
		
	
	
	
	
	
/*
 | 
						|
	Mantis PCI bridge driver
 | 
						|
 | 
						|
	Copyright (C) Manu Abraham (abraham.manu@gmail.com)
 | 
						|
 | 
						|
	This program is free software; you can redistribute it and/or modify
 | 
						|
	it under the terms of the GNU General Public License as published by
 | 
						|
	the Free Software Foundation; either version 2 of the License, or
 | 
						|
	(at your option) any later version.
 | 
						|
 | 
						|
	This program is distributed in the hope that it will be useful,
 | 
						|
	but WITHOUT ANY WARRANTY; without even the implied warranty of
 | 
						|
	MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 | 
						|
	GNU General Public License for more details.
 | 
						|
 | 
						|
	You should have received a copy of the GNU General Public License
 | 
						|
	along with this program; if not, write to the Free Software
 | 
						|
	Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
 | 
						|
*/
 | 
						|
 | 
						|
#include <linux/signal.h>
 | 
						|
#include <linux/slab.h>
 | 
						|
#include <linux/sched.h>
 | 
						|
#include <linux/interrupt.h>
 | 
						|
#include <asm/io.h>
 | 
						|
 | 
						|
#include "dmxdev.h"
 | 
						|
#include "dvbdev.h"
 | 
						|
#include "dvb_demux.h"
 | 
						|
#include "dvb_frontend.h"
 | 
						|
#include "dvb_net.h"
 | 
						|
 | 
						|
#include "mantis_common.h"
 | 
						|
#include "mantis_link.h"
 | 
						|
#include "mantis_hif.h"
 | 
						|
#include "mantis_reg.h"
 | 
						|
 | 
						|
#include "mantis_ca.h"
 | 
						|
 | 
						|
static int mantis_ca_read_attr_mem(struct dvb_ca_en50221 *en50221, int slot, int addr)
 | 
						|
{
 | 
						|
	struct mantis_ca *ca = en50221->data;
 | 
						|
	struct mantis_pci *mantis = ca->ca_priv;
 | 
						|
 | 
						|
	dprintk(MANTIS_DEBUG, 1, "Slot(%d): Request Attribute Mem Read", slot);
 | 
						|
 | 
						|
	if (slot != 0)
 | 
						|
		return -EINVAL;
 | 
						|
 | 
						|
	return mantis_hif_read_mem(ca, addr);
 | 
						|
}
 | 
						|
 | 
						|
static int mantis_ca_write_attr_mem(struct dvb_ca_en50221 *en50221, int slot, int addr, u8 data)
 | 
						|
{
 | 
						|
	struct mantis_ca *ca = en50221->data;
 | 
						|
	struct mantis_pci *mantis = ca->ca_priv;
 | 
						|
 | 
						|
	dprintk(MANTIS_DEBUG, 1, "Slot(%d): Request Attribute Mem Write", slot);
 | 
						|
 | 
						|
	if (slot != 0)
 | 
						|
		return -EINVAL;
 | 
						|
 | 
						|
	return mantis_hif_write_mem(ca, addr, data);
 | 
						|
}
 | 
						|
 | 
						|
static int mantis_ca_read_cam_ctl(struct dvb_ca_en50221 *en50221, int slot, u8 addr)
 | 
						|
{
 | 
						|
	struct mantis_ca *ca = en50221->data;
 | 
						|
	struct mantis_pci *mantis = ca->ca_priv;
 | 
						|
 | 
						|
	dprintk(MANTIS_DEBUG, 1, "Slot(%d): Request CAM control Read", slot);
 | 
						|
 | 
						|
	if (slot != 0)
 | 
						|
		return -EINVAL;
 | 
						|
 | 
						|
	return mantis_hif_read_iom(ca, addr);
 | 
						|
}
 | 
						|
 | 
						|
static int mantis_ca_write_cam_ctl(struct dvb_ca_en50221 *en50221, int slot, u8 addr, u8 data)
 | 
						|
{
 | 
						|
	struct mantis_ca *ca = en50221->data;
 | 
						|
	struct mantis_pci *mantis = ca->ca_priv;
 | 
						|
 | 
						|
	dprintk(MANTIS_DEBUG, 1, "Slot(%d): Request CAM control Write", slot);
 | 
						|
 | 
						|
	if (slot != 0)
 | 
						|
		return -EINVAL;
 | 
						|
 | 
						|
	return mantis_hif_write_iom(ca, addr, data);
 | 
						|
}
 | 
						|
 | 
						|
static int mantis_ca_slot_reset(struct dvb_ca_en50221 *en50221, int slot)
 | 
						|
{
 | 
						|
	struct mantis_ca *ca = en50221->data;
 | 
						|
	struct mantis_pci *mantis = ca->ca_priv;
 | 
						|
 | 
						|
	dprintk(MANTIS_DEBUG, 1, "Slot(%d): Slot RESET", slot);
 | 
						|
	udelay(500); /* Wait.. */
 | 
						|
	mmwrite(0xda, MANTIS_PCMCIA_RESET); /* Leading edge assert */
 | 
						|
	udelay(500);
 | 
						|
	mmwrite(0x00, MANTIS_PCMCIA_RESET); /* Trailing edge deassert */
 | 
						|
	msleep(1000);
 | 
						|
	dvb_ca_en50221_camready_irq(&ca->en50221, 0);
 | 
						|
 | 
						|
	return 0;
 | 
						|
}
 | 
						|
 | 
						|
static int mantis_ca_slot_shutdown(struct dvb_ca_en50221 *en50221, int slot)
 | 
						|
{
 | 
						|
	struct mantis_ca *ca = en50221->data;
 | 
						|
	struct mantis_pci *mantis = ca->ca_priv;
 | 
						|
 | 
						|
	dprintk(MANTIS_DEBUG, 1, "Slot(%d): Slot shutdown", slot);
 | 
						|
 | 
						|
	return 0;
 | 
						|
}
 | 
						|
 | 
						|
static int mantis_ts_control(struct dvb_ca_en50221 *en50221, int slot)
 | 
						|
{
 | 
						|
	struct mantis_ca *ca = en50221->data;
 | 
						|
	struct mantis_pci *mantis = ca->ca_priv;
 | 
						|
 | 
						|
	dprintk(MANTIS_DEBUG, 1, "Slot(%d): TS control", slot);
 | 
						|
/*	mantis_set_direction(mantis, 1); */ /* Enable TS through CAM */
 | 
						|
 | 
						|
	return 0;
 | 
						|
}
 | 
						|
 | 
						|
static int mantis_slot_status(struct dvb_ca_en50221 *en50221, int slot, int open)
 | 
						|
{
 | 
						|
	struct mantis_ca *ca = en50221->data;
 | 
						|
	struct mantis_pci *mantis = ca->ca_priv;
 | 
						|
 | 
						|
	dprintk(MANTIS_DEBUG, 1, "Slot(%d): Poll Slot status", slot);
 | 
						|
 | 
						|
	if (ca->slot_state == MODULE_INSERTED) {
 | 
						|
		dprintk(MANTIS_DEBUG, 1, "CA Module present and ready");
 | 
						|
		return DVB_CA_EN50221_POLL_CAM_PRESENT | DVB_CA_EN50221_POLL_CAM_READY;
 | 
						|
	} else {
 | 
						|
		dprintk(MANTIS_DEBUG, 1, "CA Module not present or not ready");
 | 
						|
	}
 | 
						|
 | 
						|
	return 0;
 | 
						|
}
 | 
						|
 | 
						|
int mantis_ca_init(struct mantis_pci *mantis)
 | 
						|
{
 | 
						|
	struct dvb_adapter *dvb_adapter	= &mantis->dvb_adapter;
 | 
						|
	struct mantis_ca *ca;
 | 
						|
	int ca_flags = 0, result;
 | 
						|
 | 
						|
	dprintk(MANTIS_DEBUG, 1, "Initializing Mantis CA");
 | 
						|
	ca = kzalloc(sizeof(struct mantis_ca), GFP_KERNEL);
 | 
						|
	if (!ca) {
 | 
						|
		dprintk(MANTIS_ERROR, 1, "Out of memory!, exiting ..");
 | 
						|
		result = -ENOMEM;
 | 
						|
		goto err;
 | 
						|
	}
 | 
						|
 | 
						|
	ca->ca_priv		= mantis;
 | 
						|
	mantis->mantis_ca	= ca;
 | 
						|
	ca_flags		= DVB_CA_EN50221_FLAG_IRQ_CAMCHANGE;
 | 
						|
	/* register CA interface */
 | 
						|
	ca->en50221.owner		= THIS_MODULE;
 | 
						|
	ca->en50221.read_attribute_mem	= mantis_ca_read_attr_mem;
 | 
						|
	ca->en50221.write_attribute_mem	= mantis_ca_write_attr_mem;
 | 
						|
	ca->en50221.read_cam_control	= mantis_ca_read_cam_ctl;
 | 
						|
	ca->en50221.write_cam_control	= mantis_ca_write_cam_ctl;
 | 
						|
	ca->en50221.slot_reset		= mantis_ca_slot_reset;
 | 
						|
	ca->en50221.slot_shutdown	= mantis_ca_slot_shutdown;
 | 
						|
	ca->en50221.slot_ts_enable	= mantis_ts_control;
 | 
						|
	ca->en50221.poll_slot_status	= mantis_slot_status;
 | 
						|
	ca->en50221.data		= ca;
 | 
						|
 | 
						|
	mutex_init(&ca->ca_lock);
 | 
						|
 | 
						|
	init_waitqueue_head(&ca->hif_data_wq);
 | 
						|
	init_waitqueue_head(&ca->hif_opdone_wq);
 | 
						|
	init_waitqueue_head(&ca->hif_write_wq);
 | 
						|
 | 
						|
	dprintk(MANTIS_ERROR, 1, "Registering EN50221 device");
 | 
						|
	result = dvb_ca_en50221_init(dvb_adapter, &ca->en50221, ca_flags, 1);
 | 
						|
	if (result != 0) {
 | 
						|
		dprintk(MANTIS_ERROR, 1, "EN50221: Initialization failed <%d>", result);
 | 
						|
		goto err;
 | 
						|
	}
 | 
						|
	dprintk(MANTIS_ERROR, 1, "Registered EN50221 device");
 | 
						|
	mantis_evmgr_init(ca);
 | 
						|
	return 0;
 | 
						|
err:
 | 
						|
	kfree(ca);
 | 
						|
	return result;
 | 
						|
}
 | 
						|
EXPORT_SYMBOL_GPL(mantis_ca_init);
 | 
						|
 | 
						|
void mantis_ca_exit(struct mantis_pci *mantis)
 | 
						|
{
 | 
						|
	struct mantis_ca *ca = mantis->mantis_ca;
 | 
						|
 | 
						|
	dprintk(MANTIS_DEBUG, 1, "Mantis CA exit");
 | 
						|
	if (!ca)
 | 
						|
		return;
 | 
						|
 | 
						|
	mantis_evmgr_exit(ca);
 | 
						|
	dprintk(MANTIS_ERROR, 1, "Unregistering EN50221 device");
 | 
						|
	dvb_ca_en50221_release(&ca->en50221);
 | 
						|
 | 
						|
	kfree(ca);
 | 
						|
}
 | 
						|
EXPORT_SYMBOL_GPL(mantis_ca_exit);
 |