The "runtime idle" helper routine, rpm_idle(), currently ignores return values from .runtime_idle() callbacks executed by it. However, it turns out that many subsystems use pm_generic_runtime_idle() which checks the return value of the driver's callback and executes pm_runtime_suspend() for the device unless that value is not 0. If that logic is moved to rpm_idle() instead, pm_generic_runtime_idle() can be dropped and its users will not need any .runtime_idle() callbacks any more. Moreover, the PCI, SCSI, and SATA subsystems' .runtime_idle() routines, pci_pm_runtime_idle(), scsi_runtime_idle(), and ata_port_runtime_idle(), respectively, as well as a few drivers' ones may be simplified if rpm_idle() calls rpm_suspend() after 0 has been returned by the .runtime_idle() callback executed by it. To reduce overall code bloat, make the changes described above. Tested-by: Mika Westerberg <mika.westerberg@linux.intel.com> Tested-by: Kevin Hilman <khilman@linaro.org> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Acked-by: Kevin Hilman <khilman@linaro.org> Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org> Acked-by: Alan Stern <stern@rowland.harvard.edu>
		
			
				
	
	
		
			65 lines
		
	
	
	
		
			1.4 KiB
			
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			65 lines
		
	
	
	
		
			1.4 KiB
			
		
	
	
	
		
			C
		
	
	
	
	
	
/*
 | 
						|
 * Runtime PM support code
 | 
						|
 *
 | 
						|
 *  Copyright (C) 2009-2010 Magnus Damm
 | 
						|
 *
 | 
						|
 * This file is subject to the terms and conditions of the GNU General Public
 | 
						|
 * License.  See the file "COPYING" in the main directory of this archive
 | 
						|
 * for more details.
 | 
						|
 */
 | 
						|
 | 
						|
#include <linux/init.h>
 | 
						|
#include <linux/kernel.h>
 | 
						|
#include <linux/io.h>
 | 
						|
#include <linux/pm_runtime.h>
 | 
						|
#include <linux/pm_domain.h>
 | 
						|
#include <linux/pm_clock.h>
 | 
						|
#include <linux/platform_device.h>
 | 
						|
#include <linux/clk.h>
 | 
						|
#include <linux/sh_clk.h>
 | 
						|
#include <linux/bitmap.h>
 | 
						|
#include <linux/slab.h>
 | 
						|
 | 
						|
#ifdef CONFIG_PM_RUNTIME
 | 
						|
 | 
						|
static int default_platform_runtime_idle(struct device *dev)
 | 
						|
{
 | 
						|
	/* suspend synchronously to disable clocks immediately */
 | 
						|
	return 0;
 | 
						|
}
 | 
						|
 | 
						|
static struct dev_pm_domain default_pm_domain = {
 | 
						|
	.ops = {
 | 
						|
		.runtime_suspend = pm_clk_suspend,
 | 
						|
		.runtime_resume = pm_clk_resume,
 | 
						|
		.runtime_idle = default_platform_runtime_idle,
 | 
						|
		USE_PLATFORM_PM_SLEEP_OPS
 | 
						|
	},
 | 
						|
};
 | 
						|
 | 
						|
#define DEFAULT_PM_DOMAIN_PTR	(&default_pm_domain)
 | 
						|
 | 
						|
#else
 | 
						|
 | 
						|
#define DEFAULT_PM_DOMAIN_PTR	NULL
 | 
						|
 | 
						|
#endif /* CONFIG_PM_RUNTIME */
 | 
						|
 | 
						|
static struct pm_clk_notifier_block platform_bus_notifier = {
 | 
						|
	.pm_domain = DEFAULT_PM_DOMAIN_PTR,
 | 
						|
	.con_ids = { NULL, },
 | 
						|
};
 | 
						|
 | 
						|
static int __init sh_pm_runtime_init(void)
 | 
						|
{
 | 
						|
	pm_clk_add_notifier(&platform_bus_type, &platform_bus_notifier);
 | 
						|
	return 0;
 | 
						|
}
 | 
						|
core_initcall(sh_pm_runtime_init);
 | 
						|
 | 
						|
static int __init sh_pm_runtime_late_init(void)
 | 
						|
{
 | 
						|
	pm_genpd_poweroff_unused();
 | 
						|
	return 0;
 | 
						|
}
 | 
						|
late_initcall(sh_pm_runtime_late_init);
 |