Randy Dunlap reported the following build error:
"When CONFIG_SMP=n, CONFIG_X86_MSR=m:
ERROR: "msrs_free" [drivers/edac/amd64_edac_mod.ko] undefined!
ERROR: "msrs_alloc" [drivers/edac/amd64_edac_mod.ko] undefined!"
This is due to the fact that <arch/x86/lib/msr.c> is conditioned on
CONFIG_SMP and in the UP case we have only the stubs in the header.
Fork off SMP functionality into a new file (msr-smp.c) and build
msrs_{alloc,free} unconditionally.
Reported-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Signed-off-by: Borislav Petkov <petkovbb@gmail.com>
LKML-Reference: <20091216231625.GD27228@liondog.tnic>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
		
	
			
		
			
				
	
	
		
			23 lines
		
	
	
	
		
			382 B
			
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			23 lines
		
	
	
	
		
			382 B
			
		
	
	
	
		
			C
		
	
	
	
	
	
#include <linux/module.h>
 | 
						|
#include <linux/preempt.h>
 | 
						|
#include <asm/msr.h>
 | 
						|
 | 
						|
struct msr *msrs_alloc(void)
 | 
						|
{
 | 
						|
	struct msr *msrs = NULL;
 | 
						|
 | 
						|
	msrs = alloc_percpu(struct msr);
 | 
						|
	if (!msrs) {
 | 
						|
		pr_warning("%s: error allocating msrs\n", __func__);
 | 
						|
		return NULL;
 | 
						|
	}
 | 
						|
 | 
						|
	return msrs;
 | 
						|
}
 | 
						|
EXPORT_SYMBOL(msrs_alloc);
 | 
						|
 | 
						|
void msrs_free(struct msr *msrs)
 | 
						|
{
 | 
						|
	free_percpu(msrs);
 | 
						|
}
 | 
						|
EXPORT_SYMBOL(msrs_free);
 |