 6ebbf2ce43
			
		
	
	
	6ebbf2ce43
	
	
	
		
			
			ARMv6 and greater introduced a new instruction ("bx") which can be used
to return from function calls.  Recent CPUs perform better when the
"bx lr" instruction is used rather than the "mov pc, lr" instruction,
and this sequence is strongly recommended to be used by the ARM
architecture manual (section A.4.1.1).
We provide a new macro "ret" with all its variants for the condition
code which will resolve to the appropriate instruction.
Rather than doing this piecemeal, and miss some instances, change all
the "mov pc" instances to use the new macro, with the exception of
the "movs" instruction and the kprobes code.  This allows us to detect
the "mov pc, lr" case and fix it up - and also gives us the possibility
of deploying this for other registers depending on the CPU selection.
Reported-by: Will Deacon <will.deacon@arm.com>
Tested-by: Stephen Warren <swarren@nvidia.com> # Tegra Jetson TK1
Tested-by: Robert Jarzmik <robert.jarzmik@free.fr> # mioa701_bootresume.S
Tested-by: Andrew Lunn <andrew@lunn.ch> # Kirkwood
Tested-by: Shawn Guo <shawn.guo@freescale.com>
Tested-by: Tony Lindgren <tony@atomide.com> # OMAPs
Tested-by: Gregory CLEMENT <gregory.clement@free-electrons.com> # Armada XP, 375, 385
Acked-by: Sekhar Nori <nsekhar@ti.com> # DaVinci
Acked-by: Christoffer Dall <christoffer.dall@linaro.org> # kvm/hyp
Acked-by: Haojian Zhuang <haojian.zhuang@gmail.com> # PXA3xx
Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> # Xen
Tested-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> # ARMv7M
Tested-by: Simon Horman <horms+renesas@verge.net.au> # Shmobile
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
		
	
			
		
			
				
	
	
		
			53 lines
		
	
	
	
		
			797 B
			
		
	
	
	
		
			ArmAsm
		
	
	
	
	
	
			
		
		
	
	
			53 lines
		
	
	
	
		
			797 B
			
		
	
	
	
		
			ArmAsm
		
	
	
	
	
	
| /*
 | |
|  *  linux/arch/arm/lib/ucmpdi2.S
 | |
|  *
 | |
|  *  Author:	Nicolas Pitre
 | |
|  *  Created:	Oct 19, 2005
 | |
|  *  Copyright:	Monta Vista Software, Inc.
 | |
|  *
 | |
|  *  This program is free software; you can redistribute it and/or modify
 | |
|  *  it under the terms of the GNU General Public License version 2 as
 | |
|  *  published by the Free Software Foundation.
 | |
|  */
 | |
| 
 | |
| #include <linux/linkage.h>
 | |
| #include <asm/assembler.h>
 | |
| 
 | |
| #ifdef __ARMEB__
 | |
| #define xh r0
 | |
| #define xl r1
 | |
| #define yh r2
 | |
| #define yl r3
 | |
| #else
 | |
| #define xl r0
 | |
| #define xh r1
 | |
| #define yl r2
 | |
| #define yh r3
 | |
| #endif
 | |
| 
 | |
| ENTRY(__ucmpdi2)
 | |
| 
 | |
| 	cmp	xh, yh
 | |
| 	cmpeq	xl, yl
 | |
| 	movlo	r0, #0
 | |
| 	moveq	r0, #1
 | |
| 	movhi	r0, #2
 | |
| 	ret	lr
 | |
| 
 | |
| ENDPROC(__ucmpdi2)
 | |
| 
 | |
| #ifdef CONFIG_AEABI
 | |
| 
 | |
| ENTRY(__aeabi_ulcmp)
 | |
| 
 | |
| 	cmp	xh, yh
 | |
| 	cmpeq	xl, yl
 | |
| 	movlo	r0, #-1
 | |
| 	moveq	r0, #0
 | |
| 	movhi	r0, #1
 | |
| 	ret	lr
 | |
| 
 | |
| ENDPROC(__aeabi_ulcmp)
 | |
| 
 | |
| #endif
 | |
| 
 |