b01aec9b2c
So first of all, this atomic_scrub() function's naming is bad. It looks like an atomic_t helper. Change it to edac_atomic_scrub(). The bigger problem is that this function is arch-specific and every new arch which doesn't necessarily need that functionality still needs to define it, otherwise EDAC doesn't compile. So instead of doing that and including arch-specific headers, have each arch define an EDAC_ATOMIC_SCRUB symbol which can be used in edac_mc.c for ifdeffery. Much cleaner. And we already are doing this with another symbol - EDAC_SUPPORT. This is also much cleaner than having CONFIG_EDAC enumerate all the arches which need/have EDAC support and drivers. This way I can kill the useless edac.h header in tile too. Acked-by: Ralf Baechle <ralf@linux-mips.org> Acked-by: Michael Ellerman <mpe@ellerman.id.au> Acked-by: Chris Metcalf <cmetcalf@ezchip.com> Acked-by: Ingo Molnar <mingo@kernel.org> Acked-by: Russell King <rmk+kernel@arm.linux.org.uk> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: Doug Thompson <dougthompson@xmission.com> Cc: linux-arm-kernel@lists.infradead.org Cc: linux-edac@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: linux-mips@linux-mips.org Cc: linuxppc-dev@lists.ozlabs.org Cc: "Maciej W. Rozycki" <macro@codesourcery.com> Cc: Markos Chandras <markos.chandras@imgtec.com> Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com> Cc: Paul Mackerras <paulus@samba.org> Cc: "Steven J. Hill" <Steven.Hill@imgtec.com> Cc: x86@kernel.org Signed-off-by: Borislav Petkov <bp@suse.de>
49 lines
1.5 KiB
C
49 lines
1.5 KiB
C
/*
|
|
* Copyright 2011 Calxeda, Inc.
|
|
* Based on PPC version Copyright 2007 MontaVista Software, Inc.
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify it
|
|
* under the terms and conditions of the GNU General Public License,
|
|
* version 2, as published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope it will be useful, but WITHOUT
|
|
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
|
|
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
|
|
* more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along with
|
|
* this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
#ifndef ASM_EDAC_H
|
|
#define ASM_EDAC_H
|
|
/*
|
|
* ECC atomic, DMA, SMP and interrupt safe scrub function.
|
|
* Implements the per arch edac_atomic_scrub() that EDAC use for software
|
|
* ECC scrubbing. It reads memory and then writes back the original
|
|
* value, allowing the hardware to detect and correct memory errors.
|
|
*/
|
|
|
|
static inline void edac_atomic_scrub(void *va, u32 size)
|
|
{
|
|
#if __LINUX_ARM_ARCH__ >= 6
|
|
unsigned int *virt_addr = va;
|
|
unsigned int temp, temp2;
|
|
unsigned int i;
|
|
|
|
for (i = 0; i < size / sizeof(*virt_addr); i++, virt_addr++) {
|
|
/* Very carefully read and write to memory atomically
|
|
* so we are interrupt, DMA and SMP safe.
|
|
*/
|
|
__asm__ __volatile__("\n"
|
|
"1: ldrex %0, [%2]\n"
|
|
" strex %1, %0, [%2]\n"
|
|
" teq %1, #0\n"
|
|
" bne 1b\n"
|
|
: "=&r"(temp), "=&r"(temp2)
|
|
: "r"(virt_addr)
|
|
: "cc");
|
|
}
|
|
#endif
|
|
}
|
|
|
|
#endif
|