2d45a02d01
->auto_asconf_splist is per namespace and mangled by functions like
sctp_setsockopt_auto_asconf() which doesn't guarantee any serialization.
Also, the call to inet_sk_copy_descendant() was backuping
->auto_asconf_list through the copy but was not honoring
->do_auto_asconf, which could lead to list corruption if it was
different between both sockets.
This commit thus fixes the list handling by using ->addr_wq_lock
spinlock to protect the list. A special handling is done upon socket
creation and destruction for that. Error handlig on sctp_init_sock()
will never return an error after having initialized asconf, so
sctp_destroy_sock() can be called without addrq_wq_lock. The lock now
will be take on sctp_close_sock(), before locking the socket, so we
don't do it in inverse order compared to sctp_addr_wq_timeout_handler().
Instead of taking the lock on sctp_sock_migrate() for copying and
restoring the list values, it's preferred to avoid rewritting it by
implementing sctp_copy_descendant().
Issue was found with a test application that kept flipping sysctl
default_auto_asconf on and off, but one could trigger it by issuing
simultaneous setsockopt() calls on multiple sockets or by
creating/destroying sockets fast enough. This is only triggerable
locally.
Fixes: 9f7d653b67 ("sctp: Add Auto-ASCONF support (core).")
Reported-by: Ji Jianwen <jiji@redhat.com>
Suggested-by: Neil Horman <nhorman@tuxdriver.com>
Suggested-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
135 lines
3.6 KiB
C
135 lines
3.6 KiB
C
#ifndef __NETNS_SCTP_H__
|
|
#define __NETNS_SCTP_H__
|
|
|
|
struct sock;
|
|
struct proc_dir_entry;
|
|
struct sctp_mib;
|
|
struct ctl_table_header;
|
|
|
|
struct netns_sctp {
|
|
DEFINE_SNMP_STAT(struct sctp_mib, sctp_statistics);
|
|
|
|
#ifdef CONFIG_PROC_FS
|
|
struct proc_dir_entry *proc_net_sctp;
|
|
#endif
|
|
#ifdef CONFIG_SYSCTL
|
|
struct ctl_table_header *sysctl_header;
|
|
#endif
|
|
/* This is the global socket data structure used for responding to
|
|
* the Out-of-the-blue (OOTB) packets. A control sock will be created
|
|
* for this socket at the initialization time.
|
|
*/
|
|
struct sock *ctl_sock;
|
|
|
|
/* This is the global local address list.
|
|
* We actively maintain this complete list of addresses on
|
|
* the system by catching address add/delete events.
|
|
*
|
|
* It is a list of sctp_sockaddr_entry.
|
|
*/
|
|
struct list_head local_addr_list;
|
|
struct list_head addr_waitq;
|
|
struct timer_list addr_wq_timer;
|
|
struct list_head auto_asconf_splist;
|
|
/* Lock that protects both addr_waitq and auto_asconf_splist */
|
|
spinlock_t addr_wq_lock;
|
|
|
|
/* Lock that protects the local_addr_list writers */
|
|
spinlock_t local_addr_lock;
|
|
|
|
/* RFC2960 Section 14. Suggested SCTP Protocol Parameter Values
|
|
*
|
|
* The following protocol parameters are RECOMMENDED:
|
|
*
|
|
* RTO.Initial - 3 seconds
|
|
* RTO.Min - 1 second
|
|
* RTO.Max - 60 seconds
|
|
* RTO.Alpha - 1/8 (3 when converted to right shifts.)
|
|
* RTO.Beta - 1/4 (2 when converted to right shifts.)
|
|
*/
|
|
unsigned int rto_initial;
|
|
unsigned int rto_min;
|
|
unsigned int rto_max;
|
|
|
|
/* Note: rto_alpha and rto_beta are really defined as inverse
|
|
* powers of two to facilitate integer operations.
|
|
*/
|
|
int rto_alpha;
|
|
int rto_beta;
|
|
|
|
/* Max.Burst - 4 */
|
|
int max_burst;
|
|
|
|
/* Whether Cookie Preservative is enabled(1) or not(0) */
|
|
int cookie_preserve_enable;
|
|
|
|
/* The namespace default hmac alg */
|
|
char *sctp_hmac_alg;
|
|
|
|
/* Valid.Cookie.Life - 60 seconds */
|
|
unsigned int valid_cookie_life;
|
|
|
|
/* Delayed SACK timeout 200ms default*/
|
|
unsigned int sack_timeout;
|
|
|
|
/* HB.interval - 30 seconds */
|
|
unsigned int hb_interval;
|
|
|
|
/* Association.Max.Retrans - 10 attempts
|
|
* Path.Max.Retrans - 5 attempts (per destination address)
|
|
* Max.Init.Retransmits - 8 attempts
|
|
*/
|
|
int max_retrans_association;
|
|
int max_retrans_path;
|
|
int max_retrans_init;
|
|
/* Potentially-Failed.Max.Retrans sysctl value
|
|
* taken from:
|
|
* http://tools.ietf.org/html/draft-nishida-tsvwg-sctp-failover-05
|
|
*/
|
|
int pf_retrans;
|
|
|
|
/*
|
|
* Policy for preforming sctp/socket accounting
|
|
* 0 - do socket level accounting, all assocs share sk_sndbuf
|
|
* 1 - do sctp accounting, each asoc may use sk_sndbuf bytes
|
|
*/
|
|
int sndbuf_policy;
|
|
|
|
/*
|
|
* Policy for preforming sctp/socket accounting
|
|
* 0 - do socket level accounting, all assocs share sk_rcvbuf
|
|
* 1 - do sctp accounting, each asoc may use sk_rcvbuf bytes
|
|
*/
|
|
int rcvbuf_policy;
|
|
|
|
int default_auto_asconf;
|
|
|
|
/* Flag to indicate if addip is enabled. */
|
|
int addip_enable;
|
|
int addip_noauth;
|
|
|
|
/* Flag to indicate if PR-SCTP is enabled. */
|
|
int prsctp_enable;
|
|
|
|
/* Flag to idicate if SCTP-AUTH is enabled */
|
|
int auth_enable;
|
|
|
|
/*
|
|
* Policy to control SCTP IPv4 address scoping
|
|
* 0 - Disable IPv4 address scoping
|
|
* 1 - Enable IPv4 address scoping
|
|
* 2 - Selectively allow only IPv4 private addresses
|
|
* 3 - Selectively allow only IPv4 link local address
|
|
*/
|
|
int scope_policy;
|
|
|
|
/* Threshold for rwnd update SACKS. Receive buffer shifted this many
|
|
* bits is an indicator of when to send and window update SACK.
|
|
*/
|
|
int rwnd_upd_shift;
|
|
|
|
/* Threshold for autoclose timeout, in seconds. */
|
|
unsigned long max_autoclose;
|
|
};
|
|
|
|
#endif /* __NETNS_SCTP_H__ */
|