Convert the driver to use the dvb_attach macro to avoid the hard dependency on the frontend drivers. The hard dependecy will result in loading a number of unused frontends, and unwanted automatic dereferencing. This fixes a bug where unloading the mantis driver will derefence any attached frontend twice, which will cause an oops if the same frontend is used by another driver. Signed-off-by: Bjørn Mork <bjorn@mork.no> Signed-off-by: Manu Abraham <manu@linuxtv.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
		
			
				
	
	
		
			187 lines
		
	
	
	
		
			4.4 KiB
			
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			187 lines
		
	
	
	
		
			4.4 KiB
			
		
	
	
	
		
			C
		
	
	
	
	
	
/*
 | 
						|
	Mantis VP-2033 driver
 | 
						|
 | 
						|
	Copyright (C) Manu Abraham (abraham.manu@gmail.com)
 | 
						|
 | 
						|
	This program is free software; you can redistribute it and/or modify
 | 
						|
	it under the terms of the GNU General Public License as published by
 | 
						|
	the Free Software Foundation; either version 2 of the License, or
 | 
						|
	(at your option) any later version.
 | 
						|
 | 
						|
	This program is distributed in the hope that it will be useful,
 | 
						|
	but WITHOUT ANY WARRANTY; without even the implied warranty of
 | 
						|
	MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 | 
						|
	GNU General Public License for more details.
 | 
						|
 | 
						|
	You should have received a copy of the GNU General Public License
 | 
						|
	along with this program; if not, write to the Free Software
 | 
						|
	Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
 | 
						|
*/
 | 
						|
 | 
						|
#include <linux/signal.h>
 | 
						|
#include <linux/sched.h>
 | 
						|
#include <linux/interrupt.h>
 | 
						|
 | 
						|
#include "dmxdev.h"
 | 
						|
#include "dvbdev.h"
 | 
						|
#include "dvb_demux.h"
 | 
						|
#include "dvb_frontend.h"
 | 
						|
#include "dvb_net.h"
 | 
						|
 | 
						|
#include "tda1002x.h"
 | 
						|
#include "mantis_common.h"
 | 
						|
#include "mantis_ioc.h"
 | 
						|
#include "mantis_dvb.h"
 | 
						|
#include "mantis_vp2033.h"
 | 
						|
 | 
						|
#define MANTIS_MODEL_NAME	"VP-2033"
 | 
						|
#define MANTIS_DEV_TYPE		"DVB-C"
 | 
						|
 | 
						|
struct tda1002x_config vp2033_tda1002x_cu1216_config = {
 | 
						|
	.demod_address = 0x18 >> 1,
 | 
						|
	.invert = 1,
 | 
						|
};
 | 
						|
 | 
						|
struct tda10023_config vp2033_tda10023_cu1216_config = {
 | 
						|
	.demod_address = 0x18 >> 1,
 | 
						|
	.invert = 1,
 | 
						|
};
 | 
						|
 | 
						|
static u8 read_pwm(struct mantis_pci *mantis)
 | 
						|
{
 | 
						|
	struct i2c_adapter *adapter = &mantis->adapter;
 | 
						|
 | 
						|
	u8 b = 0xff;
 | 
						|
	u8 pwm;
 | 
						|
	struct i2c_msg msg[] = {
 | 
						|
		{.addr = 0x50, .flags = 0, .buf = &b, .len = 1},
 | 
						|
		{.addr = 0x50, .flags = I2C_M_RD, .buf = &pwm, .len = 1}
 | 
						|
	};
 | 
						|
 | 
						|
	if ((i2c_transfer(adapter, msg, 2) != 2)
 | 
						|
	    || (pwm == 0xff))
 | 
						|
		pwm = 0x48;
 | 
						|
 | 
						|
	return pwm;
 | 
						|
}
 | 
						|
 | 
						|
static int tda1002x_cu1216_tuner_set(struct dvb_frontend *fe, struct dvb_frontend_parameters *params)
 | 
						|
{
 | 
						|
	struct mantis_pci *mantis = fe->dvb->priv;
 | 
						|
	struct i2c_adapter *adapter = &mantis->adapter;
 | 
						|
 | 
						|
	u8 buf[6];
 | 
						|
	struct i2c_msg msg = {.addr = 0x60, .flags = 0, .buf = buf, .len = sizeof(buf)};
 | 
						|
	int i;
 | 
						|
 | 
						|
#define CU1216_IF 36125000
 | 
						|
#define TUNER_MUL 62500
 | 
						|
 | 
						|
	u32 div = (params->frequency + CU1216_IF + TUNER_MUL / 2) / TUNER_MUL;
 | 
						|
 | 
						|
	buf[0] = (div >> 8) & 0x7f;
 | 
						|
	buf[1] = div & 0xff;
 | 
						|
	buf[2] = 0xce;
 | 
						|
	buf[3] = (params->frequency < 150000000 ? 0x01 :
 | 
						|
		  params->frequency < 445000000 ? 0x02 : 0x04);
 | 
						|
	buf[4] = 0xde;
 | 
						|
	buf[5] = 0x20;
 | 
						|
 | 
						|
	if (fe->ops.i2c_gate_ctrl)
 | 
						|
		fe->ops.i2c_gate_ctrl(fe, 1);
 | 
						|
 | 
						|
	if (i2c_transfer(adapter, &msg, 1) != 1)
 | 
						|
		return -EIO;
 | 
						|
 | 
						|
	/* wait for the pll lock */
 | 
						|
	msg.flags = I2C_M_RD;
 | 
						|
	msg.len = 1;
 | 
						|
	for (i = 0; i < 20; i++) {
 | 
						|
		if (fe->ops.i2c_gate_ctrl)
 | 
						|
			fe->ops.i2c_gate_ctrl(fe, 1);
 | 
						|
 | 
						|
		if (i2c_transfer(adapter, &msg, 1) == 1 && (buf[0] & 0x40))
 | 
						|
			break;
 | 
						|
 | 
						|
		msleep(10);
 | 
						|
	}
 | 
						|
 | 
						|
	/* switch the charge pump to the lower current */
 | 
						|
	msg.flags = 0;
 | 
						|
	msg.len = 2;
 | 
						|
	msg.buf = &buf[2];
 | 
						|
	buf[2] &= ~0x40;
 | 
						|
	if (fe->ops.i2c_gate_ctrl)
 | 
						|
		fe->ops.i2c_gate_ctrl(fe, 1);
 | 
						|
 | 
						|
	if (i2c_transfer(adapter, &msg, 1) != 1)
 | 
						|
		return -EIO;
 | 
						|
 | 
						|
	return 0;
 | 
						|
}
 | 
						|
 | 
						|
static int vp2033_frontend_init(struct mantis_pci *mantis, struct dvb_frontend *fe)
 | 
						|
{
 | 
						|
	struct i2c_adapter *adapter = &mantis->adapter;
 | 
						|
 | 
						|
	int err = 0;
 | 
						|
 | 
						|
	err = mantis_frontend_power(mantis, POWER_ON);
 | 
						|
	if (err == 0) {
 | 
						|
		mantis_frontend_soft_reset(mantis);
 | 
						|
		msleep(250);
 | 
						|
 | 
						|
		dprintk(MANTIS_ERROR, 1, "Probing for CU1216 (DVB-C)");
 | 
						|
		fe = dvb_attach(tda10021_attach, &vp2033_tda1002x_cu1216_config,
 | 
						|
				     adapter,
 | 
						|
				     read_pwm(mantis));
 | 
						|
 | 
						|
		if (fe) {
 | 
						|
			dprintk(MANTIS_ERROR, 1,
 | 
						|
				"found Philips CU1216 DVB-C frontend (TDA10021) @ 0x%02x",
 | 
						|
				vp2033_tda1002x_cu1216_config.demod_address);
 | 
						|
		} else {
 | 
						|
			fe = dvb_attach(tda10023_attach, &vp2033_tda10023_cu1216_config,
 | 
						|
					     adapter,
 | 
						|
					     read_pwm(mantis));
 | 
						|
 | 
						|
			if (fe) {
 | 
						|
				dprintk(MANTIS_ERROR, 1,
 | 
						|
					"found Philips CU1216 DVB-C frontend (TDA10023) @ 0x%02x",
 | 
						|
					vp2033_tda1002x_cu1216_config.demod_address);
 | 
						|
			}
 | 
						|
		}
 | 
						|
 | 
						|
		if (fe) {
 | 
						|
			fe->ops.tuner_ops.set_params = tda1002x_cu1216_tuner_set;
 | 
						|
			dprintk(MANTIS_ERROR, 1, "Mantis DVB-C Philips CU1216 frontend attach success");
 | 
						|
		} else {
 | 
						|
			return -1;
 | 
						|
		}
 | 
						|
	} else {
 | 
						|
		dprintk(MANTIS_ERROR, 1, "Frontend on <%s> POWER ON failed! <%d>",
 | 
						|
			adapter->name,
 | 
						|
			err);
 | 
						|
 | 
						|
		return -EIO;
 | 
						|
	}
 | 
						|
 | 
						|
	mantis->fe = fe;
 | 
						|
	dprintk(MANTIS_DEBUG, 1, "Done!");
 | 
						|
 | 
						|
	return 0;
 | 
						|
}
 | 
						|
 | 
						|
struct mantis_hwconfig vp2033_config = {
 | 
						|
	.model_name	= MANTIS_MODEL_NAME,
 | 
						|
	.dev_type	= MANTIS_DEV_TYPE,
 | 
						|
	.ts_size	= MANTIS_TS_204,
 | 
						|
 | 
						|
	.baud_rate	= MANTIS_BAUD_9600,
 | 
						|
	.parity		= MANTIS_PARITY_NONE,
 | 
						|
	.bytes		= 0,
 | 
						|
 | 
						|
	.frontend_init	= vp2033_frontend_init,
 | 
						|
	.power		= GPIF_A12,
 | 
						|
	.reset		= GPIF_A13,
 | 
						|
};
 |