Previously kvasprintf() allocation was being done through kmalloc(), thus producing an inaccurate trace report. This is a common problem: in order to get accurate callsite tracing, a lib/utils function shouldn't allocate kmalloc but instead use kmalloc_track_caller. Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com> Cc: Sam Ravnborg <sam@ravnborg.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
		
			
				
	
	
		
			45 lines
		
	
	
	
		
			717 B
			
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			45 lines
		
	
	
	
		
			717 B
			
		
	
	
	
		
			C
		
	
	
	
	
	
/*
 | 
						|
 *  linux/lib/kasprintf.c
 | 
						|
 *
 | 
						|
 *  Copyright (C) 1991, 1992  Linus Torvalds
 | 
						|
 */
 | 
						|
 | 
						|
#include <stdarg.h>
 | 
						|
#include <linux/export.h>
 | 
						|
#include <linux/slab.h>
 | 
						|
#include <linux/types.h>
 | 
						|
#include <linux/string.h>
 | 
						|
 | 
						|
/* Simplified asprintf. */
 | 
						|
char *kvasprintf(gfp_t gfp, const char *fmt, va_list ap)
 | 
						|
{
 | 
						|
	unsigned int len;
 | 
						|
	char *p;
 | 
						|
	va_list aq;
 | 
						|
 | 
						|
	va_copy(aq, ap);
 | 
						|
	len = vsnprintf(NULL, 0, fmt, aq);
 | 
						|
	va_end(aq);
 | 
						|
 | 
						|
	p = kmalloc_track_caller(len+1, gfp);
 | 
						|
	if (!p)
 | 
						|
		return NULL;
 | 
						|
 | 
						|
	vsnprintf(p, len+1, fmt, ap);
 | 
						|
 | 
						|
	return p;
 | 
						|
}
 | 
						|
EXPORT_SYMBOL(kvasprintf);
 | 
						|
 | 
						|
char *kasprintf(gfp_t gfp, const char *fmt, ...)
 | 
						|
{
 | 
						|
	va_list ap;
 | 
						|
	char *p;
 | 
						|
 | 
						|
	va_start(ap, fmt);
 | 
						|
	p = kvasprintf(gfp, fmt, ap);
 | 
						|
	va_end(ap);
 | 
						|
 | 
						|
	return p;
 | 
						|
}
 | 
						|
EXPORT_SYMBOL(kasprintf);
 |