While synchronizing what's in trace-cmd vs what's in perf, I came across a change that was made when entering the cfg80211 plugin into the tools/lib/traceevent directory. The function prototype went from: static unsigned long long process___le16_to_cpup(struct trace_seq *s, unsigned long long *args) to: static unsigned long long process___le16_to_cpup(struct trace_seq *s, unsigned long long *args) I can understand the line break after the long long, but there's no reason to keep args on a separate line. Signed-off-by: Steven Rostedt <rostedt@goodmis.org> Link: http://lkml.kernel.org/r/20140612194420.24073744@gandalf.local.home Signed-off-by: Jiri Olsa <jolsa@kernel.org>
		
			
				
	
	
		
			29 lines
		
	
	
	
		
			720 B
			
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			29 lines
		
	
	
	
		
			720 B
			
		
	
	
	
		
			C
		
	
	
	
	
	
#include <stdio.h>
 | 
						|
#include <string.h>
 | 
						|
#include <inttypes.h>
 | 
						|
#include <endian.h>
 | 
						|
#include "event-parse.h"
 | 
						|
 | 
						|
static unsigned long long
 | 
						|
process___le16_to_cpup(struct trace_seq *s, unsigned long long *args)
 | 
						|
{
 | 
						|
	uint16_t *val = (uint16_t *) (unsigned long) args[0];
 | 
						|
	return val ? (long long) le16toh(*val) : 0;
 | 
						|
}
 | 
						|
 | 
						|
int PEVENT_PLUGIN_LOADER(struct pevent *pevent)
 | 
						|
{
 | 
						|
	pevent_register_print_function(pevent,
 | 
						|
				       process___le16_to_cpup,
 | 
						|
				       PEVENT_FUNC_ARG_INT,
 | 
						|
				       "__le16_to_cpup",
 | 
						|
				       PEVENT_FUNC_ARG_PTR,
 | 
						|
				       PEVENT_FUNC_ARG_VOID);
 | 
						|
	return 0;
 | 
						|
}
 | 
						|
 | 
						|
void PEVENT_PLUGIN_UNLOADER(struct pevent *pevent)
 | 
						|
{
 | 
						|
	pevent_unregister_print_function(pevent, process___le16_to_cpup,
 | 
						|
					 "__le16_to_cpup");
 | 
						|
}
 |