If registering of one of them fails, all already registered drivers of this module will be unregistered. Use the new register/unregister functions in all drivers registering more than one driver. amd.c, realtek.c: Simplify: directly return registration result. Tested with broadcom.c All others compile-tested. Signed-off-by: Christian Hohnstaedt <chohnstaedt@innominate.com> Signed-off-by: David S. Miller <davem@davemloft.net>
		
			
				
	
	
		
			124 lines
		
	
	
	
		
			3.2 KiB
			
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			124 lines
		
	
	
	
		
			3.2 KiB
			
		
	
	
	
		
			C
		
	
	
	
	
	
/*
 | 
						|
 *	Driver for Broadcom 63xx SOCs integrated PHYs
 | 
						|
 *
 | 
						|
 *	This program is free software; you can redistribute it and/or
 | 
						|
 *	modify it under the terms of the GNU General Public License
 | 
						|
 *	as published by the Free Software Foundation; either version
 | 
						|
 *	2 of the License, or (at your option) any later version.
 | 
						|
 */
 | 
						|
#include <linux/module.h>
 | 
						|
#include <linux/phy.h>
 | 
						|
 | 
						|
#define MII_BCM63XX_IR		0x1a	/* interrupt register */
 | 
						|
#define MII_BCM63XX_IR_EN	0x4000	/* global interrupt enable */
 | 
						|
#define MII_BCM63XX_IR_DUPLEX	0x0800	/* duplex changed */
 | 
						|
#define MII_BCM63XX_IR_SPEED	0x0400	/* speed changed */
 | 
						|
#define MII_BCM63XX_IR_LINK	0x0200	/* link changed */
 | 
						|
#define MII_BCM63XX_IR_GMASK	0x0100	/* global interrupt mask */
 | 
						|
 | 
						|
MODULE_DESCRIPTION("Broadcom 63xx internal PHY driver");
 | 
						|
MODULE_AUTHOR("Maxime Bizon <mbizon@freebox.fr>");
 | 
						|
MODULE_LICENSE("GPL");
 | 
						|
 | 
						|
static int bcm63xx_config_init(struct phy_device *phydev)
 | 
						|
{
 | 
						|
	int reg, err;
 | 
						|
 | 
						|
	reg = phy_read(phydev, MII_BCM63XX_IR);
 | 
						|
	if (reg < 0)
 | 
						|
		return reg;
 | 
						|
 | 
						|
	/* Mask interrupts globally.  */
 | 
						|
	reg |= MII_BCM63XX_IR_GMASK;
 | 
						|
	err = phy_write(phydev, MII_BCM63XX_IR, reg);
 | 
						|
	if (err < 0)
 | 
						|
		return err;
 | 
						|
 | 
						|
	/* Unmask events we are interested in  */
 | 
						|
	reg = ~(MII_BCM63XX_IR_DUPLEX |
 | 
						|
		MII_BCM63XX_IR_SPEED |
 | 
						|
		MII_BCM63XX_IR_LINK) |
 | 
						|
		MII_BCM63XX_IR_EN;
 | 
						|
	return phy_write(phydev, MII_BCM63XX_IR, reg);
 | 
						|
}
 | 
						|
 | 
						|
static int bcm63xx_ack_interrupt(struct phy_device *phydev)
 | 
						|
{
 | 
						|
	int reg;
 | 
						|
 | 
						|
	/* Clear pending interrupts.  */
 | 
						|
	reg = phy_read(phydev, MII_BCM63XX_IR);
 | 
						|
	if (reg < 0)
 | 
						|
		return reg;
 | 
						|
 | 
						|
	return 0;
 | 
						|
}
 | 
						|
 | 
						|
static int bcm63xx_config_intr(struct phy_device *phydev)
 | 
						|
{
 | 
						|
	int reg, err;
 | 
						|
 | 
						|
	reg = phy_read(phydev, MII_BCM63XX_IR);
 | 
						|
	if (reg < 0)
 | 
						|
		return reg;
 | 
						|
 | 
						|
	if (phydev->interrupts == PHY_INTERRUPT_ENABLED)
 | 
						|
		reg &= ~MII_BCM63XX_IR_GMASK;
 | 
						|
	else
 | 
						|
		reg |= MII_BCM63XX_IR_GMASK;
 | 
						|
 | 
						|
	err = phy_write(phydev, MII_BCM63XX_IR, reg);
 | 
						|
	return err;
 | 
						|
}
 | 
						|
 | 
						|
static struct phy_driver bcm63xx_driver[] = {
 | 
						|
{
 | 
						|
	.phy_id		= 0x00406000,
 | 
						|
	.phy_id_mask	= 0xfffffc00,
 | 
						|
	.name		= "Broadcom BCM63XX (1)",
 | 
						|
	/* ASYM_PAUSE bit is marked RO in datasheet, so don't cheat */
 | 
						|
	.features	= (PHY_BASIC_FEATURES | SUPPORTED_Pause),
 | 
						|
	.flags		= PHY_HAS_INTERRUPT,
 | 
						|
	.config_init	= bcm63xx_config_init,
 | 
						|
	.config_aneg	= genphy_config_aneg,
 | 
						|
	.read_status	= genphy_read_status,
 | 
						|
	.ack_interrupt	= bcm63xx_ack_interrupt,
 | 
						|
	.config_intr	= bcm63xx_config_intr,
 | 
						|
	.driver		= { .owner = THIS_MODULE },
 | 
						|
}, {
 | 
						|
	/* same phy as above, with just a different OUI */
 | 
						|
	.phy_id		= 0x002bdc00,
 | 
						|
	.phy_id_mask	= 0xfffffc00,
 | 
						|
	.name		= "Broadcom BCM63XX (2)",
 | 
						|
	.features	= (PHY_BASIC_FEATURES | SUPPORTED_Pause),
 | 
						|
	.flags		= PHY_HAS_INTERRUPT,
 | 
						|
	.config_init	= bcm63xx_config_init,
 | 
						|
	.config_aneg	= genphy_config_aneg,
 | 
						|
	.read_status	= genphy_read_status,
 | 
						|
	.ack_interrupt	= bcm63xx_ack_interrupt,
 | 
						|
	.config_intr	= bcm63xx_config_intr,
 | 
						|
	.driver		= { .owner = THIS_MODULE },
 | 
						|
} };
 | 
						|
 | 
						|
static int __init bcm63xx_phy_init(void)
 | 
						|
{
 | 
						|
	return phy_drivers_register(bcm63xx_driver,
 | 
						|
		ARRAY_SIZE(bcm63xx_driver));
 | 
						|
}
 | 
						|
 | 
						|
static void __exit bcm63xx_phy_exit(void)
 | 
						|
{
 | 
						|
	phy_drivers_unregister(bcm63xx_driver,
 | 
						|
		ARRAY_SIZE(bcm63xx_driver));
 | 
						|
}
 | 
						|
 | 
						|
module_init(bcm63xx_phy_init);
 | 
						|
module_exit(bcm63xx_phy_exit);
 | 
						|
 | 
						|
static struct mdio_device_id __maybe_unused bcm63xx_tbl[] = {
 | 
						|
	{ 0x00406000, 0xfffffc00 },
 | 
						|
	{ 0x002bdc00, 0xfffffc00 },
 | 
						|
	{ }
 | 
						|
};
 | 
						|
 | 
						|
MODULE_DEVICE_TABLE(mdio, bcm63xx_tbl);
 |