The first 3 arguments of 'mtd_device_parse_register()' are pointers, but many callers pass '0' instead of 'NULL'. Fix this globally. Thanks to coccinelle for making it easy to do with the following semantic patch: @@ expression mtd, types, parser_data, parts, nr_parts; @@ ( -mtd_device_parse_register(mtd, 0, parser_data, parts, nr_parts) +mtd_device_parse_register(mtd, NULL, parser_data, parts, nr_parts) | -mtd_device_parse_register(mtd, types, 0, parts, nr_parts) +mtd_device_parse_register(mtd, types, NULL, parts, nr_parts) | -mtd_device_parse_register(mtd, types, parser_data, 0, nr_parts) +mtd_device_parse_register(mtd, types, parser_data, NULL, nr_parts) ) Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
		
			
				
	
	
		
			286 lines
		
	
	
	
		
			6.8 KiB
			
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			286 lines
		
	
	
	
		
			6.8 KiB
			
		
	
	
	
		
			C
		
	
	
	
	
	
/*
 | 
						|
 * Normal mappings of chips in physical memory
 | 
						|
 *
 | 
						|
 * Copyright (C) 2003 MontaVista Software Inc.
 | 
						|
 * Author: Jun Sun, jsun@mvista.com or jsun@junsun.net
 | 
						|
 *
 | 
						|
 * 031022 - [jsun] add run-time configure and partition setup
 | 
						|
 */
 | 
						|
 | 
						|
#include <linux/module.h>
 | 
						|
#include <linux/types.h>
 | 
						|
#include <linux/kernel.h>
 | 
						|
#include <linux/init.h>
 | 
						|
#include <linux/slab.h>
 | 
						|
#include <linux/device.h>
 | 
						|
#include <linux/platform_device.h>
 | 
						|
#include <linux/mtd/mtd.h>
 | 
						|
#include <linux/mtd/map.h>
 | 
						|
#include <linux/mtd/partitions.h>
 | 
						|
#include <linux/mtd/physmap.h>
 | 
						|
#include <linux/mtd/concat.h>
 | 
						|
#include <linux/io.h>
 | 
						|
 | 
						|
#define MAX_RESOURCES		4
 | 
						|
 | 
						|
struct physmap_flash_info {
 | 
						|
	struct mtd_info		*mtd[MAX_RESOURCES];
 | 
						|
	struct mtd_info		*cmtd;
 | 
						|
	struct map_info		map[MAX_RESOURCES];
 | 
						|
	spinlock_t		vpp_lock;
 | 
						|
	int			vpp_refcnt;
 | 
						|
};
 | 
						|
 | 
						|
static int physmap_flash_remove(struct platform_device *dev)
 | 
						|
{
 | 
						|
	struct physmap_flash_info *info;
 | 
						|
	struct physmap_flash_data *physmap_data;
 | 
						|
	int i;
 | 
						|
 | 
						|
	info = platform_get_drvdata(dev);
 | 
						|
	if (info == NULL)
 | 
						|
		return 0;
 | 
						|
	platform_set_drvdata(dev, NULL);
 | 
						|
 | 
						|
	physmap_data = dev->dev.platform_data;
 | 
						|
 | 
						|
	if (info->cmtd) {
 | 
						|
		mtd_device_unregister(info->cmtd);
 | 
						|
		if (info->cmtd != info->mtd[0])
 | 
						|
			mtd_concat_destroy(info->cmtd);
 | 
						|
	}
 | 
						|
 | 
						|
	for (i = 0; i < MAX_RESOURCES; i++) {
 | 
						|
		if (info->mtd[i] != NULL)
 | 
						|
			map_destroy(info->mtd[i]);
 | 
						|
	}
 | 
						|
 | 
						|
	if (physmap_data->exit)
 | 
						|
		physmap_data->exit(dev);
 | 
						|
 | 
						|
	return 0;
 | 
						|
}
 | 
						|
 | 
						|
static void physmap_set_vpp(struct map_info *map, int state)
 | 
						|
{
 | 
						|
	struct platform_device *pdev;
 | 
						|
	struct physmap_flash_data *physmap_data;
 | 
						|
	struct physmap_flash_info *info;
 | 
						|
	unsigned long flags;
 | 
						|
 | 
						|
	pdev = (struct platform_device *)map->map_priv_1;
 | 
						|
	physmap_data = pdev->dev.platform_data;
 | 
						|
 | 
						|
	if (!physmap_data->set_vpp)
 | 
						|
		return;
 | 
						|
 | 
						|
	info = platform_get_drvdata(pdev);
 | 
						|
 | 
						|
	spin_lock_irqsave(&info->vpp_lock, flags);
 | 
						|
	if (state) {
 | 
						|
		if (++info->vpp_refcnt == 1)    /* first nested 'on' */
 | 
						|
			physmap_data->set_vpp(pdev, 1);
 | 
						|
	} else {
 | 
						|
		if (--info->vpp_refcnt == 0)    /* last nested 'off' */
 | 
						|
			physmap_data->set_vpp(pdev, 0);
 | 
						|
	}
 | 
						|
	spin_unlock_irqrestore(&info->vpp_lock, flags);
 | 
						|
}
 | 
						|
 | 
						|
static const char *rom_probe_types[] = {
 | 
						|
					"cfi_probe",
 | 
						|
					"jedec_probe",
 | 
						|
					"qinfo_probe",
 | 
						|
					"map_rom",
 | 
						|
					NULL };
 | 
						|
static const char *part_probe_types[] = { "cmdlinepart", "RedBoot", "afs",
 | 
						|
					  NULL };
 | 
						|
 | 
						|
static int physmap_flash_probe(struct platform_device *dev)
 | 
						|
{
 | 
						|
	struct physmap_flash_data *physmap_data;
 | 
						|
	struct physmap_flash_info *info;
 | 
						|
	const char **probe_type;
 | 
						|
	const char **part_types;
 | 
						|
	int err = 0;
 | 
						|
	int i;
 | 
						|
	int devices_found = 0;
 | 
						|
 | 
						|
	physmap_data = dev->dev.platform_data;
 | 
						|
	if (physmap_data == NULL)
 | 
						|
		return -ENODEV;
 | 
						|
 | 
						|
	info = devm_kzalloc(&dev->dev, sizeof(struct physmap_flash_info),
 | 
						|
			    GFP_KERNEL);
 | 
						|
	if (info == NULL) {
 | 
						|
		err = -ENOMEM;
 | 
						|
		goto err_out;
 | 
						|
	}
 | 
						|
 | 
						|
	if (physmap_data->init) {
 | 
						|
		err = physmap_data->init(dev);
 | 
						|
		if (err)
 | 
						|
			goto err_out;
 | 
						|
	}
 | 
						|
 | 
						|
	platform_set_drvdata(dev, info);
 | 
						|
 | 
						|
	for (i = 0; i < dev->num_resources; i++) {
 | 
						|
		printk(KERN_NOTICE "physmap platform flash device: %.8llx at %.8llx\n",
 | 
						|
		       (unsigned long long)resource_size(&dev->resource[i]),
 | 
						|
		       (unsigned long long)dev->resource[i].start);
 | 
						|
 | 
						|
		if (!devm_request_mem_region(&dev->dev,
 | 
						|
			dev->resource[i].start,
 | 
						|
			resource_size(&dev->resource[i]),
 | 
						|
			dev_name(&dev->dev))) {
 | 
						|
			dev_err(&dev->dev, "Could not reserve memory region\n");
 | 
						|
			err = -ENOMEM;
 | 
						|
			goto err_out;
 | 
						|
		}
 | 
						|
 | 
						|
		info->map[i].name = dev_name(&dev->dev);
 | 
						|
		info->map[i].phys = dev->resource[i].start;
 | 
						|
		info->map[i].size = resource_size(&dev->resource[i]);
 | 
						|
		info->map[i].bankwidth = physmap_data->width;
 | 
						|
		info->map[i].set_vpp = physmap_set_vpp;
 | 
						|
		info->map[i].pfow_base = physmap_data->pfow_base;
 | 
						|
		info->map[i].map_priv_1 = (unsigned long)dev;
 | 
						|
 | 
						|
		info->map[i].virt = devm_ioremap(&dev->dev, info->map[i].phys,
 | 
						|
						 info->map[i].size);
 | 
						|
		if (info->map[i].virt == NULL) {
 | 
						|
			dev_err(&dev->dev, "Failed to ioremap flash region\n");
 | 
						|
			err = -EIO;
 | 
						|
			goto err_out;
 | 
						|
		}
 | 
						|
 | 
						|
		simple_map_init(&info->map[i]);
 | 
						|
 | 
						|
		probe_type = rom_probe_types;
 | 
						|
		if (physmap_data->probe_type == NULL) {
 | 
						|
			for (; info->mtd[i] == NULL && *probe_type != NULL; probe_type++)
 | 
						|
				info->mtd[i] = do_map_probe(*probe_type, &info->map[i]);
 | 
						|
		} else
 | 
						|
			info->mtd[i] = do_map_probe(physmap_data->probe_type, &info->map[i]);
 | 
						|
 | 
						|
		if (info->mtd[i] == NULL) {
 | 
						|
			dev_err(&dev->dev, "map_probe failed\n");
 | 
						|
			err = -ENXIO;
 | 
						|
			goto err_out;
 | 
						|
		} else {
 | 
						|
			devices_found++;
 | 
						|
		}
 | 
						|
		info->mtd[i]->owner = THIS_MODULE;
 | 
						|
		info->mtd[i]->dev.parent = &dev->dev;
 | 
						|
	}
 | 
						|
 | 
						|
	if (devices_found == 1) {
 | 
						|
		info->cmtd = info->mtd[0];
 | 
						|
	} else if (devices_found > 1) {
 | 
						|
		/*
 | 
						|
		 * We detected multiple devices. Concatenate them together.
 | 
						|
		 */
 | 
						|
		info->cmtd = mtd_concat_create(info->mtd, devices_found, dev_name(&dev->dev));
 | 
						|
		if (info->cmtd == NULL)
 | 
						|
			err = -ENXIO;
 | 
						|
	}
 | 
						|
	if (err)
 | 
						|
		goto err_out;
 | 
						|
 | 
						|
	spin_lock_init(&info->vpp_lock);
 | 
						|
 | 
						|
	part_types = physmap_data->part_probe_types ? : part_probe_types;
 | 
						|
 | 
						|
	mtd_device_parse_register(info->cmtd, part_types, NULL,
 | 
						|
				  physmap_data->parts, physmap_data->nr_parts);
 | 
						|
	return 0;
 | 
						|
 | 
						|
err_out:
 | 
						|
	physmap_flash_remove(dev);
 | 
						|
	return err;
 | 
						|
}
 | 
						|
 | 
						|
#ifdef CONFIG_PM
 | 
						|
static void physmap_flash_shutdown(struct platform_device *dev)
 | 
						|
{
 | 
						|
	struct physmap_flash_info *info = platform_get_drvdata(dev);
 | 
						|
	int i;
 | 
						|
 | 
						|
	for (i = 0; i < MAX_RESOURCES && info->mtd[i]; i++)
 | 
						|
		if (mtd_suspend(info->mtd[i]) == 0)
 | 
						|
			mtd_resume(info->mtd[i]);
 | 
						|
}
 | 
						|
#else
 | 
						|
#define physmap_flash_shutdown NULL
 | 
						|
#endif
 | 
						|
 | 
						|
static struct platform_driver physmap_flash_driver = {
 | 
						|
	.probe		= physmap_flash_probe,
 | 
						|
	.remove		= physmap_flash_remove,
 | 
						|
	.shutdown	= physmap_flash_shutdown,
 | 
						|
	.driver		= {
 | 
						|
		.name	= "physmap-flash",
 | 
						|
		.owner	= THIS_MODULE,
 | 
						|
	},
 | 
						|
};
 | 
						|
 | 
						|
 | 
						|
#ifdef CONFIG_MTD_PHYSMAP_COMPAT
 | 
						|
static struct physmap_flash_data physmap_flash_data = {
 | 
						|
	.width		= CONFIG_MTD_PHYSMAP_BANKWIDTH,
 | 
						|
};
 | 
						|
 | 
						|
static struct resource physmap_flash_resource = {
 | 
						|
	.start		= CONFIG_MTD_PHYSMAP_START,
 | 
						|
	.end		= CONFIG_MTD_PHYSMAP_START + CONFIG_MTD_PHYSMAP_LEN - 1,
 | 
						|
	.flags		= IORESOURCE_MEM,
 | 
						|
};
 | 
						|
 | 
						|
static struct platform_device physmap_flash = {
 | 
						|
	.name		= "physmap-flash",
 | 
						|
	.id		= 0,
 | 
						|
	.dev		= {
 | 
						|
		.platform_data	= &physmap_flash_data,
 | 
						|
	},
 | 
						|
	.num_resources	= 1,
 | 
						|
	.resource	= &physmap_flash_resource,
 | 
						|
};
 | 
						|
#endif
 | 
						|
 | 
						|
static int __init physmap_init(void)
 | 
						|
{
 | 
						|
	int err;
 | 
						|
 | 
						|
	err = platform_driver_register(&physmap_flash_driver);
 | 
						|
#ifdef CONFIG_MTD_PHYSMAP_COMPAT
 | 
						|
	if (err == 0) {
 | 
						|
		err = platform_device_register(&physmap_flash);
 | 
						|
		if (err)
 | 
						|
			platform_driver_unregister(&physmap_flash_driver);
 | 
						|
	}
 | 
						|
#endif
 | 
						|
 | 
						|
	return err;
 | 
						|
}
 | 
						|
 | 
						|
static void __exit physmap_exit(void)
 | 
						|
{
 | 
						|
#ifdef CONFIG_MTD_PHYSMAP_COMPAT
 | 
						|
	platform_device_unregister(&physmap_flash);
 | 
						|
#endif
 | 
						|
	platform_driver_unregister(&physmap_flash_driver);
 | 
						|
}
 | 
						|
 | 
						|
module_init(physmap_init);
 | 
						|
module_exit(physmap_exit);
 | 
						|
 | 
						|
MODULE_LICENSE("GPL");
 | 
						|
MODULE_AUTHOR("David Woodhouse <dwmw2@infradead.org>");
 | 
						|
MODULE_DESCRIPTION("Generic configurable MTD map driver");
 | 
						|
 | 
						|
/* legacy platform drivers can't hotplug or coldplg */
 | 
						|
#ifndef CONFIG_MTD_PHYSMAP_COMPAT
 | 
						|
/* work with hotplug and coldplug */
 | 
						|
MODULE_ALIAS("platform:physmap-flash");
 | 
						|
#endif
 |