drivers/net/wireless/ath/main.c:88 ath_printk() error: we previously assumed 'common->hw' could be null (see line 82) Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Sujith Manoharan <c_manoha@qca.qualcomm.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
		
			
				
	
	
		
			92 lines
		
	
	
	
		
			2.7 KiB
			
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			92 lines
		
	
	
	
		
			2.7 KiB
			
		
	
	
	
		
			C
		
	
	
	
	
	
/*
 | 
						|
 * Copyright (c) 2009 Atheros Communications Inc.
 | 
						|
 *
 | 
						|
 * Permission to use, copy, modify, and/or distribute this software for any
 | 
						|
 * purpose with or without fee is hereby granted, provided that the above
 | 
						|
 * copyright notice and this permission notice appear in all copies.
 | 
						|
 *
 | 
						|
 * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
 | 
						|
 * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
 | 
						|
 * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
 | 
						|
 * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
 | 
						|
 * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
 | 
						|
 * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
 | 
						|
 * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 | 
						|
 */
 | 
						|
 | 
						|
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
 | 
						|
 | 
						|
#include <linux/kernel.h>
 | 
						|
#include <linux/module.h>
 | 
						|
 | 
						|
#include "ath.h"
 | 
						|
#include "trace.h"
 | 
						|
 | 
						|
MODULE_AUTHOR("Atheros Communications");
 | 
						|
MODULE_DESCRIPTION("Shared library for Atheros wireless LAN cards.");
 | 
						|
MODULE_LICENSE("Dual BSD/GPL");
 | 
						|
 | 
						|
struct sk_buff *ath_rxbuf_alloc(struct ath_common *common,
 | 
						|
				u32 len,
 | 
						|
				gfp_t gfp_mask)
 | 
						|
{
 | 
						|
	struct sk_buff *skb;
 | 
						|
	u32 off;
 | 
						|
 | 
						|
	/*
 | 
						|
	 * Cache-line-align.  This is important (for the
 | 
						|
	 * 5210 at least) as not doing so causes bogus data
 | 
						|
	 * in rx'd frames.
 | 
						|
	 */
 | 
						|
 | 
						|
	/* Note: the kernel can allocate a value greater than
 | 
						|
	 * what we ask it to give us. We really only need 4 KB as that
 | 
						|
	 * is this hardware supports and in fact we need at least 3849
 | 
						|
	 * as that is the MAX AMSDU size this hardware supports.
 | 
						|
	 * Unfortunately this means we may get 8 KB here from the
 | 
						|
	 * kernel... and that is actually what is observed on some
 | 
						|
	 * systems :( */
 | 
						|
	skb = __dev_alloc_skb(len + common->cachelsz - 1, gfp_mask);
 | 
						|
	if (skb != NULL) {
 | 
						|
		off = ((unsigned long) skb->data) % common->cachelsz;
 | 
						|
		if (off != 0)
 | 
						|
			skb_reserve(skb, common->cachelsz - off);
 | 
						|
	} else {
 | 
						|
		pr_err("skbuff alloc of size %u failed\n", len);
 | 
						|
		return NULL;
 | 
						|
	}
 | 
						|
 | 
						|
	return skb;
 | 
						|
}
 | 
						|
EXPORT_SYMBOL(ath_rxbuf_alloc);
 | 
						|
 | 
						|
bool ath_is_mybeacon(struct ath_common *common, struct ieee80211_hdr *hdr)
 | 
						|
{
 | 
						|
	return ieee80211_is_beacon(hdr->frame_control) &&
 | 
						|
		!is_zero_ether_addr(common->curbssid) &&
 | 
						|
		ether_addr_equal_64bits(hdr->addr3, common->curbssid);
 | 
						|
}
 | 
						|
EXPORT_SYMBOL(ath_is_mybeacon);
 | 
						|
 | 
						|
void ath_printk(const char *level, const struct ath_common* common,
 | 
						|
		const char *fmt, ...)
 | 
						|
{
 | 
						|
	struct va_format vaf;
 | 
						|
	va_list args;
 | 
						|
 | 
						|
	va_start(args, fmt);
 | 
						|
 | 
						|
	vaf.fmt = fmt;
 | 
						|
	vaf.va = &args;
 | 
						|
 | 
						|
	if (common && common->hw && common->hw->wiphy) {
 | 
						|
		printk("%sath: %s: %pV",
 | 
						|
		       level, wiphy_name(common->hw->wiphy), &vaf);
 | 
						|
		trace_ath_log(common->hw->wiphy, &vaf);
 | 
						|
	} else {
 | 
						|
		printk("%sath: %pV", level, &vaf);
 | 
						|
	}
 | 
						|
 | 
						|
	va_end(args);
 | 
						|
}
 | 
						|
EXPORT_SYMBOL(ath_printk);
 |