In the UAPI header files, __BIG_ENDIAN and __LITTLE_ENDIAN must be compared against __BYTE_ORDER in preprocessor conditionals where these are exposed to userspace (that is they're not inside __KERNEL__ conditionals). However, in the main kernel the norm is to check for "defined(__XXX_ENDIAN)" rather than comparing against __BYTE_ORDER and this has incorrectly leaked into the userspace headers. The definition of struct stat64 in M32R's asm/stat.h is wrong in this way. Note that userspace will likely interpret the field order incorrectly as the big-endian variant on little-endian machines - depending on header inclusion order. [!!!] NOTE [!!!] This patch may adversely change the userspace API. It might be better to fix the ordering of st_blocks and __pad4 in struct stat64. Signed-off-by: David Howells <dhowells@redhat.com> Cc: Hirokazu Takata <takata@linux-m32r.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
		
			
				
	
	
		
			87 lines
		
	
	
	
		
			2 KiB
			
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			87 lines
		
	
	
	
		
			2 KiB
			
		
	
	
	
		
			C
		
	
	
	
	
	
#ifndef _ASM_M32R_STAT_H
 | 
						|
#define _ASM_M32R_STAT_H
 | 
						|
 | 
						|
#include <asm/byteorder.h>
 | 
						|
 | 
						|
struct __old_kernel_stat {
 | 
						|
	unsigned short st_dev;
 | 
						|
	unsigned short st_ino;
 | 
						|
	unsigned short st_mode;
 | 
						|
	unsigned short st_nlink;
 | 
						|
	unsigned short st_uid;
 | 
						|
	unsigned short st_gid;
 | 
						|
	unsigned short st_rdev;
 | 
						|
	unsigned long  st_size;
 | 
						|
	unsigned long  st_atime;
 | 
						|
	unsigned long  st_mtime;
 | 
						|
	unsigned long  st_ctime;
 | 
						|
};
 | 
						|
 | 
						|
#define STAT_HAVE_NSEC	1
 | 
						|
 | 
						|
struct stat {
 | 
						|
	unsigned short st_dev;
 | 
						|
	unsigned short __pad1;
 | 
						|
	unsigned long  st_ino;
 | 
						|
	unsigned short st_mode;
 | 
						|
	unsigned short st_nlink;
 | 
						|
	unsigned short st_uid;
 | 
						|
	unsigned short st_gid;
 | 
						|
	unsigned short st_rdev;
 | 
						|
	unsigned short __pad2;
 | 
						|
	unsigned long  st_size;
 | 
						|
	unsigned long  st_blksize;
 | 
						|
	unsigned long  st_blocks;
 | 
						|
	unsigned long  st_atime;
 | 
						|
	unsigned long  st_atime_nsec;
 | 
						|
	unsigned long  st_mtime;
 | 
						|
	unsigned long  st_mtime_nsec;
 | 
						|
	unsigned long  st_ctime;
 | 
						|
	unsigned long  st_ctime_nsec;
 | 
						|
	unsigned long  __unused4;
 | 
						|
	unsigned long  __unused5;
 | 
						|
};
 | 
						|
 | 
						|
/* This matches struct stat64 in glibc2.1, hence the absolutely
 | 
						|
 * insane amounts of padding around dev_t's.
 | 
						|
 */
 | 
						|
struct stat64 {
 | 
						|
	unsigned long long	st_dev;
 | 
						|
	unsigned char	__pad0[4];
 | 
						|
#define STAT64_HAS_BROKEN_ST_INO
 | 
						|
	unsigned long	__st_ino;
 | 
						|
 | 
						|
	unsigned int	st_mode;
 | 
						|
	unsigned int	st_nlink;
 | 
						|
 | 
						|
	unsigned long	st_uid;
 | 
						|
	unsigned long	st_gid;
 | 
						|
 | 
						|
	unsigned long long	st_rdev;
 | 
						|
	unsigned char	__pad3[4];
 | 
						|
 | 
						|
	long long	st_size;
 | 
						|
	unsigned long	st_blksize;
 | 
						|
 | 
						|
#if defined(__BYTE_ORDER) ? __BYTE_ORDER == __BIG_ENDIAN : defined(__BIG_ENDIAN)
 | 
						|
	unsigned long	__pad4;		/* future possible st_blocks high bits */
 | 
						|
	unsigned long	st_blocks;	/* Number 512-byte blocks allocated. */
 | 
						|
#elif defined(__BYTE_ORDER) ? __BYTE_ORDER == __LITTLE_ENDIAN : defined(__LITTLE_ENDIAN)
 | 
						|
	unsigned long	st_blocks;	/* Number 512-byte blocks allocated. */
 | 
						|
	unsigned long	__pad4;		/* future possible st_blocks high bits */
 | 
						|
#else
 | 
						|
#error no endian defined
 | 
						|
#endif
 | 
						|
	unsigned long	st_atime;
 | 
						|
	unsigned long	st_atime_nsec;
 | 
						|
 | 
						|
	unsigned long	st_mtime;
 | 
						|
	unsigned long	st_mtime_nsec;
 | 
						|
 | 
						|
	unsigned long	st_ctime;
 | 
						|
	unsigned long	st_ctime_nsec;
 | 
						|
 | 
						|
	unsigned long long	st_ino;
 | 
						|
};
 | 
						|
 | 
						|
#endif  /* _ASM_M32R_STAT_H */
 |