ARMv6 and greater introduced a new instruction ("bx") which can be used
to return from function calls.  Recent CPUs perform better when the
"bx lr" instruction is used rather than the "mov pc, lr" instruction,
and this sequence is strongly recommended to be used by the ARM
architecture manual (section A.4.1.1).
We provide a new macro "ret" with all its variants for the condition
code which will resolve to the appropriate instruction.
Rather than doing this piecemeal, and miss some instances, change all
the "mov pc" instances to use the new macro, with the exception of
the "movs" instruction and the kprobes code.  This allows us to detect
the "mov pc, lr" case and fix it up - and also gives us the possibility
of deploying this for other registers depending on the CPU selection.
Reported-by: Will Deacon <will.deacon@arm.com>
Tested-by: Stephen Warren <swarren@nvidia.com> # Tegra Jetson TK1
Tested-by: Robert Jarzmik <robert.jarzmik@free.fr> # mioa701_bootresume.S
Tested-by: Andrew Lunn <andrew@lunn.ch> # Kirkwood
Tested-by: Shawn Guo <shawn.guo@freescale.com>
Tested-by: Tony Lindgren <tony@atomide.com> # OMAPs
Tested-by: Gregory CLEMENT <gregory.clement@free-electrons.com> # Armada XP, 375, 385
Acked-by: Sekhar Nori <nsekhar@ti.com> # DaVinci
Acked-by: Christoffer Dall <christoffer.dall@linaro.org> # kvm/hyp
Acked-by: Haojian Zhuang <haojian.zhuang@gmail.com> # PXA3xx
Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> # Xen
Tested-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> # ARMv7M
Tested-by: Simon Horman <horms+renesas@verge.net.au> # Shmobile
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
		
	
			
		
			
				
	
	
		
			93 lines
		
	
	
	
		
			1.4 KiB
			
		
	
	
	
		
			ArmAsm
		
	
	
	
	
	
			
		
		
	
	
			93 lines
		
	
	
	
		
			1.4 KiB
			
		
	
	
	
		
			ArmAsm
		
	
	
	
	
	
/*
 | 
						|
 * relocate_kernel.S - put the kernel image in place to boot
 | 
						|
 */
 | 
						|
 | 
						|
#include <linux/linkage.h>
 | 
						|
#include <asm/assembler.h>
 | 
						|
#include <asm/kexec.h>
 | 
						|
 | 
						|
	.align	3	/* not needed for this code, but keeps fncpy() happy */
 | 
						|
 | 
						|
ENTRY(relocate_new_kernel)
 | 
						|
 | 
						|
	ldr	r0,kexec_indirection_page
 | 
						|
	ldr	r1,kexec_start_address
 | 
						|
 | 
						|
	/*
 | 
						|
	 * If there is no indirection page (we are doing crashdumps)
 | 
						|
	 * skip any relocation.
 | 
						|
	 */
 | 
						|
	cmp	r0, #0
 | 
						|
	beq	2f
 | 
						|
 | 
						|
0:	/* top, read another word for the indirection page */
 | 
						|
	ldr	r3, [r0],#4
 | 
						|
 | 
						|
	/* Is it a destination page. Put destination address to r4 */
 | 
						|
	tst	r3,#1,0
 | 
						|
	beq	1f
 | 
						|
	bic	r4,r3,#1
 | 
						|
	b	0b
 | 
						|
1:
 | 
						|
	/* Is it an indirection page */
 | 
						|
	tst	r3,#2,0
 | 
						|
	beq	1f
 | 
						|
	bic	r0,r3,#2
 | 
						|
	b	0b
 | 
						|
1:
 | 
						|
 | 
						|
	/* are we done ? */
 | 
						|
	tst	r3,#4,0
 | 
						|
	beq	1f
 | 
						|
	b	2f
 | 
						|
 | 
						|
1:
 | 
						|
	/* is it source ? */
 | 
						|
	tst	r3,#8,0
 | 
						|
	beq	0b
 | 
						|
	bic r3,r3,#8
 | 
						|
	mov r6,#1024
 | 
						|
9:
 | 
						|
	ldr r5,[r3],#4
 | 
						|
	str r5,[r4],#4
 | 
						|
	subs r6,r6,#1
 | 
						|
	bne 9b
 | 
						|
	b 0b
 | 
						|
 | 
						|
2:
 | 
						|
	/* Jump to relocated kernel */
 | 
						|
	mov lr,r1
 | 
						|
	mov r0,#0
 | 
						|
	ldr r1,kexec_mach_type
 | 
						|
	ldr r2,kexec_boot_atags
 | 
						|
 ARM(	ret lr	)
 | 
						|
 THUMB(	bx lr		)
 | 
						|
 | 
						|
	.align
 | 
						|
 | 
						|
	.globl kexec_start_address
 | 
						|
kexec_start_address:
 | 
						|
	.long	0x0
 | 
						|
 | 
						|
	.globl kexec_indirection_page
 | 
						|
kexec_indirection_page:
 | 
						|
	.long	0x0
 | 
						|
 | 
						|
	.globl kexec_mach_type
 | 
						|
kexec_mach_type:
 | 
						|
	.long	0x0
 | 
						|
 | 
						|
	/* phy addr of the atags for the new kernel */
 | 
						|
	.globl kexec_boot_atags
 | 
						|
kexec_boot_atags:
 | 
						|
	.long	0x0
 | 
						|
 | 
						|
ENDPROC(relocate_new_kernel)
 | 
						|
 | 
						|
relocate_new_kernel_end:
 | 
						|
 | 
						|
	.globl relocate_new_kernel_size
 | 
						|
relocate_new_kernel_size:
 | 
						|
	.long relocate_new_kernel_end - relocate_new_kernel
 | 
						|
 | 
						|
 |