In the media drivers, the v4l2 core knows about all submodules and calls into them from a common function. However this cannot work if the modules that get called are loadable and the core is built-in. In that case we get drivers/built-in.o: In function `set_type': drivers/media/v4l2-core/tuner-core.c:301: undefined reference to `tea5767_attach' drivers/media/v4l2-core/tuner-core.c:307: undefined reference to `tea5761_attach' drivers/media/v4l2-core/tuner-core.c:349: undefined reference to `tda9887_attach' drivers/media/v4l2-core/tuner-core.c:405: undefined reference to `xc4000_attach' This was working previously, until the IS_ENABLED() macro was used to replace the construct like #if defined(CONFIG_DVB_CX24110) || (defined(CONFIG_DVB_CX24110_MODULE) && defined(MODULE)) with the difference that the new code no longer checks whether it is being built as a loadable module itself. To fix this, this new patch adds an 'IS_REACHABLE' macro, which evaluates true in exactly the condition that was used previously. The downside of this is that this trades an obvious link error for a more subtle runtime failure, but it is clear that the change that introduced the link error was unintentional and it seems better to revert it for now. Also, a similar change was originally created by Trent Piepho and then reverted by teh change to the IS_ENABLED macro. Ideally Kconfig would be used to avoid the case of a broken dependency, or the code restructured in a way to turn around the dependency, but either way would require much larger changes here. Fixes:7b34be71db("[media] use IS_ENABLED() macro") See-also:c5dec9fb24("V4L/DVB (4751): Fix DBV_FE_CUSTOMISE for card drivers compiled into kernel") Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
		
			
				
	
	
		
			118 lines
		
	
	
	
		
			3 KiB
			
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			118 lines
		
	
	
	
		
			3 KiB
			
		
	
	
	
		
			C
		
	
	
	
	
	
/*
 | 
						|
    Driver for ST STV0299 demodulator
 | 
						|
 | 
						|
    Copyright (C) 2001-2002 Convergence Integrated Media GmbH
 | 
						|
	<ralph@convergence.de>,
 | 
						|
	<holger@convergence.de>,
 | 
						|
	<js@convergence.de>
 | 
						|
 | 
						|
 | 
						|
    Philips SU1278/SH
 | 
						|
 | 
						|
    Copyright (C) 2002 by Peter Schildmann <peter.schildmann@web.de>
 | 
						|
 | 
						|
 | 
						|
    LG TDQF-S001F
 | 
						|
 | 
						|
    Copyright (C) 2002 Felix Domke <tmbinc@elitedvb.net>
 | 
						|
		     & Andreas Oberritter <obi@linuxtv.org>
 | 
						|
 | 
						|
 | 
						|
    Support for Samsung TBMU24112IMB used on Technisat SkyStar2 rev. 2.6B
 | 
						|
 | 
						|
    Copyright (C) 2003 Vadim Catana <skystar@moldova.cc>:
 | 
						|
 | 
						|
    Support for Philips SU1278 on Technotrend hardware
 | 
						|
 | 
						|
    Copyright (C) 2004 Andrew de Quincey <adq_dvb@lidskialf.net>
 | 
						|
 | 
						|
    This program is free software; you can redistribute it and/or modify
 | 
						|
    it under the terms of the GNU General Public License as published by
 | 
						|
    the Free Software Foundation; either version 2 of the License, or
 | 
						|
    (at your option) any later version.
 | 
						|
 | 
						|
    This program is distributed in the hope that it will be useful,
 | 
						|
    but WITHOUT ANY WARRANTY; without even the implied warranty of
 | 
						|
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 | 
						|
    GNU General Public License for more details.
 | 
						|
 | 
						|
    You should have received a copy of the GNU General Public License
 | 
						|
    along with this program; if not, write to the Free Software
 | 
						|
    Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
 | 
						|
 | 
						|
*/
 | 
						|
 | 
						|
#ifndef STV0299_H
 | 
						|
#define STV0299_H
 | 
						|
 | 
						|
#include <linux/dvb/frontend.h>
 | 
						|
#include "dvb_frontend.h"
 | 
						|
 | 
						|
#define STV0299_LOCKOUTPUT_0  0
 | 
						|
#define STV0299_LOCKOUTPUT_1  1
 | 
						|
#define STV0299_LOCKOUTPUT_CF 2
 | 
						|
#define STV0299_LOCKOUTPUT_LK 3
 | 
						|
 | 
						|
#define STV0299_VOLT13_OP0 0
 | 
						|
#define STV0299_VOLT13_OP1 1
 | 
						|
 | 
						|
struct stv0299_config
 | 
						|
{
 | 
						|
	/* the demodulator's i2c address */
 | 
						|
	u8 demod_address;
 | 
						|
 | 
						|
	/* inittab - array of pairs of values.
 | 
						|
	 * First of each pair is the register, second is the value.
 | 
						|
	 * List should be terminated with an 0xff, 0xff pair.
 | 
						|
	 */
 | 
						|
	const u8* inittab;
 | 
						|
 | 
						|
	/* master clock to use */
 | 
						|
	u32 mclk;
 | 
						|
 | 
						|
	/* does the inversion require inversion? */
 | 
						|
	u8 invert:1;
 | 
						|
 | 
						|
	/* Skip reinitialisation? */
 | 
						|
	u8 skip_reinit:1;
 | 
						|
 | 
						|
	/* LOCK OUTPUT setting */
 | 
						|
	u8 lock_output:2;
 | 
						|
 | 
						|
	/* Is 13v controlled by OP0 or OP1? */
 | 
						|
	u8 volt13_op0_op1:1;
 | 
						|
 | 
						|
	/* Turn-off OP0? */
 | 
						|
	u8 op0_off:1;
 | 
						|
 | 
						|
	/* minimum delay before retuning */
 | 
						|
	int min_delay_ms;
 | 
						|
 | 
						|
	/* Set the symbol rate */
 | 
						|
	int (*set_symbol_rate)(struct dvb_frontend *fe, u32 srate, u32 ratio);
 | 
						|
 | 
						|
	/* Set device param to start dma */
 | 
						|
	int (*set_ts_params)(struct dvb_frontend *fe, int is_punctured);
 | 
						|
};
 | 
						|
 | 
						|
#if IS_REACHABLE(CONFIG_DVB_STV0299)
 | 
						|
extern struct dvb_frontend *stv0299_attach(const struct stv0299_config *config,
 | 
						|
					   struct i2c_adapter *i2c);
 | 
						|
#else
 | 
						|
static inline struct dvb_frontend *stv0299_attach(const struct stv0299_config *config,
 | 
						|
					   struct i2c_adapter *i2c)
 | 
						|
{
 | 
						|
	printk(KERN_WARNING "%s: driver disabled by Kconfig\n", __func__);
 | 
						|
	return NULL;
 | 
						|
}
 | 
						|
#endif // CONFIG_DVB_STV0299
 | 
						|
 | 
						|
static inline int stv0299_writereg(struct dvb_frontend *fe, u8 reg, u8 val) {
 | 
						|
	int r = 0;
 | 
						|
	u8 buf[] = {reg, val};
 | 
						|
	if (fe->ops.write)
 | 
						|
		r = fe->ops.write(fe, buf, 2);
 | 
						|
	return r;
 | 
						|
}
 | 
						|
 | 
						|
#endif // STV0299_H
 |