5a9ee0be33
The functions tipc_port_get_ports() and tipc_port_reinit() scan over all sockets/ports to access each of them. This is done by using a dedicated linked list, 'tipc_socks' where all sockets are members. The list is in turn protected by a spinlock, 'port_list_lock', while each socket is locked by using port_lock at the moment of access. In order to reduce complexity and risk of deadlock, we want to get rid of the linked list and the accompanying spinlock. This is what we do in this commit. Instead of the linked list, we use the port registry to scan across the sockets. We also add usage of bh_lock_sock() inside the scope of port_lock in both functions, as a preparation for the complete removal of port_lock. Finally, we move the functions from port.c to socket.c, and rename them to tipc_sk_sock_show() and tipc_sk_reinit() repectively. Signed-off-by: Jon Maloy <jon.maloy@ericsson.com> Reviewed-by: Erik Hugne <erik.hugne@ericsson.com> Reviewed-by: Ying Xue <ying.xue@windriver.com> Signed-off-by: David S. Miller <davem@davemloft.net>
123 lines
3.8 KiB
C
123 lines
3.8 KiB
C
/*
|
|
* net/tipc/port.c: TIPC port code
|
|
*
|
|
* Copyright (c) 1992-2007, 2014, Ericsson AB
|
|
* Copyright (c) 2004-2008, 2010-2013, Wind River Systems
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions are met:
|
|
*
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
* documentation and/or other materials provided with the distribution.
|
|
* 3. Neither the names of the copyright holders nor the names of its
|
|
* contributors may be used to endorse or promote products derived from
|
|
* this software without specific prior written permission.
|
|
*
|
|
* Alternatively, this software may be distributed under the terms of the
|
|
* GNU General Public License ("GPL") version 2 as published by the Free
|
|
* Software Foundation.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
|
|
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
|
|
* ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE
|
|
* LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
|
|
* CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
|
|
* SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
|
|
* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
|
|
* CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
|
|
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
|
|
* POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#include "core.h"
|
|
#include "config.h"
|
|
#include "port.h"
|
|
#include "name_table.h"
|
|
#include "socket.h"
|
|
|
|
#define MAX_REJECT_SIZE 1024
|
|
|
|
/**
|
|
* tipc_port_peer_msg - verify message was sent by connected port's peer
|
|
*
|
|
* Handles cases where the node's network address has changed from
|
|
* the default of <0.0.0> to its configured setting.
|
|
*/
|
|
int tipc_port_peer_msg(struct tipc_port *p_ptr, struct tipc_msg *msg)
|
|
{
|
|
u32 peernode;
|
|
u32 orignode;
|
|
|
|
if (msg_origport(msg) != tipc_port_peerport(p_ptr))
|
|
return 0;
|
|
|
|
orignode = msg_orignode(msg);
|
|
peernode = tipc_port_peernode(p_ptr);
|
|
return (orignode == peernode) ||
|
|
(!orignode && (peernode == tipc_own_addr)) ||
|
|
(!peernode && (orignode == tipc_own_addr));
|
|
}
|
|
|
|
int tipc_publish(struct tipc_port *p_ptr, unsigned int scope,
|
|
struct tipc_name_seq const *seq)
|
|
{
|
|
struct publication *publ;
|
|
u32 key;
|
|
|
|
if (p_ptr->connected)
|
|
return -EINVAL;
|
|
key = p_ptr->ref + p_ptr->pub_count + 1;
|
|
if (key == p_ptr->ref)
|
|
return -EADDRINUSE;
|
|
|
|
publ = tipc_nametbl_publish(seq->type, seq->lower, seq->upper,
|
|
scope, p_ptr->ref, key);
|
|
if (publ) {
|
|
list_add(&publ->pport_list, &p_ptr->publications);
|
|
p_ptr->pub_count++;
|
|
p_ptr->published = 1;
|
|
return 0;
|
|
}
|
|
return -EINVAL;
|
|
}
|
|
|
|
int tipc_withdraw(struct tipc_port *p_ptr, unsigned int scope,
|
|
struct tipc_name_seq const *seq)
|
|
{
|
|
struct publication *publ;
|
|
struct publication *tpubl;
|
|
int res = -EINVAL;
|
|
|
|
if (!seq) {
|
|
list_for_each_entry_safe(publ, tpubl,
|
|
&p_ptr->publications, pport_list) {
|
|
tipc_nametbl_withdraw(publ->type, publ->lower,
|
|
publ->ref, publ->key);
|
|
}
|
|
res = 0;
|
|
} else {
|
|
list_for_each_entry_safe(publ, tpubl,
|
|
&p_ptr->publications, pport_list) {
|
|
if (publ->scope != scope)
|
|
continue;
|
|
if (publ->type != seq->type)
|
|
continue;
|
|
if (publ->lower != seq->lower)
|
|
continue;
|
|
if (publ->upper != seq->upper)
|
|
break;
|
|
tipc_nametbl_withdraw(publ->type, publ->lower,
|
|
publ->ref, publ->key);
|
|
res = 0;
|
|
break;
|
|
}
|
|
}
|
|
if (list_empty(&p_ptr->publications))
|
|
p_ptr->published = 0;
|
|
return res;
|
|
}
|