If an attacker can cause a controlled kernel stack overflow, overwriting the restart block is a very juicy exploit target. This is because the restart_block is held in the same memory allocation as the kernel stack. Moving the restart block to struct task_struct prevents this exploit by making the restart_block harder to locate. Note that there are other fields in thread_info that are also easy targets, at least on some architectures. It's also a decent simplification, since the restart code is more or less identical on all architectures. [james.hogan@imgtec.com: metag: align thread_info::supervisor_stack] Signed-off-by: Andy Lutomirski <luto@amacapital.net> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: "H. Peter Anvin" <hpa@zytor.com> Cc: Ingo Molnar <mingo@kernel.org> Cc: Kees Cook <keescook@chromium.org> Cc: David Miller <davem@davemloft.net> Acked-by: Richard Weinberger <richard@nod.at> Cc: Richard Henderson <rth@twiddle.net> Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru> Cc: Matt Turner <mattst88@gmail.com> Cc: Vineet Gupta <vgupta@synopsys.com> Cc: Russell King <rmk@arm.linux.org.uk> Cc: Catalin Marinas <catalin.marinas@arm.com> Cc: Will Deacon <will.deacon@arm.com> Cc: Haavard Skinnemoen <hskinnemoen@gmail.com> Cc: Hans-Christian Egtvedt <egtvedt@samfundet.no> Cc: Steven Miao <realmz6@gmail.com> Cc: Mark Salter <msalter@redhat.com> Cc: Aurelien Jacquiot <a-jacquiot@ti.com> Cc: Mikael Starvik <starvik@axis.com> Cc: Jesper Nilsson <jesper.nilsson@axis.com> Cc: David Howells <dhowells@redhat.com> Cc: Richard Kuo <rkuo@codeaurora.org> Cc: "Luck, Tony" <tony.luck@intel.com> Cc: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Michal Simek <monstr@monstr.eu> Cc: Ralf Baechle <ralf@linux-mips.org> Cc: Jonas Bonn <jonas@southpole.se> Cc: "James E.J. Bottomley" <jejb@parisc-linux.org> Cc: Helge Deller <deller@gmx.de> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: Paul Mackerras <paulus@samba.org> Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc) Tested-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc) Cc: Martin Schwidefsky <schwidefsky@de.ibm.com> Cc: Heiko Carstens <heiko.carstens@de.ibm.com> Cc: Chen Liqin <liqin.linux@gmail.com> Cc: Lennox Wu <lennox.wu@gmail.com> Cc: Chris Metcalf <cmetcalf@ezchip.com> Cc: Guan Xuetao <gxt@mprc.pku.edu.cn> Cc: Chris Zankel <chris@zankel.net> Cc: Max Filippov <jcmvbkbc@gmail.com> Cc: Oleg Nesterov <oleg@redhat.com> Cc: Guenter Roeck <linux@roeck-us.net> Signed-off-by: James Hogan <james.hogan@imgtec.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
		
			
				
	
	
		
			60 lines
		
	
	
	
		
			2.5 KiB
			
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			60 lines
		
	
	
	
		
			2.5 KiB
			
		
	
	
	
		
			C
		
	
	
	
	
	
/*
 | 
						|
 * This program is used to generate definitions needed by
 | 
						|
 * assembly language modules.
 | 
						|
 *
 | 
						|
 * We use the technique used in the OSF Mach kernel code:
 | 
						|
 * generate asm statements containing #defines,
 | 
						|
 * compile this file to assembler, and then extract the
 | 
						|
 * #defines from the assembly-language output.
 | 
						|
 */
 | 
						|
 | 
						|
#include <linux/stddef.h>
 | 
						|
#include <linux/types.h>
 | 
						|
#include <linux/mm.h>
 | 
						|
#include <linux/kbuild.h>
 | 
						|
#include <linux/suspend.h>
 | 
						|
 | 
						|
#include <asm/thread_info.h>
 | 
						|
#include <asm/suspend.h>
 | 
						|
 | 
						|
int main(void)
 | 
						|
{
 | 
						|
	/* offsets into the thread_info struct */
 | 
						|
	DEFINE(TI_TASK,		offsetof(struct thread_info, task));
 | 
						|
	DEFINE(TI_EXEC_DOMAIN,	offsetof(struct thread_info, exec_domain));
 | 
						|
	DEFINE(TI_FLAGS,	offsetof(struct thread_info, flags));
 | 
						|
	DEFINE(TI_CPU,		offsetof(struct thread_info, cpu));
 | 
						|
	DEFINE(TI_PRE_COUNT,	offsetof(struct thread_info, preempt_count));
 | 
						|
	DEFINE(TI_SIZE,		sizeof(struct thread_info));
 | 
						|
 | 
						|
#ifdef CONFIG_HIBERNATION
 | 
						|
	DEFINE(PBE_ADDRESS, offsetof(struct pbe, address));
 | 
						|
	DEFINE(PBE_ORIG_ADDRESS, offsetof(struct pbe, orig_address));
 | 
						|
	DEFINE(PBE_NEXT, offsetof(struct pbe, next));
 | 
						|
	DEFINE(SWSUSP_ARCH_REGS_SIZE, sizeof(struct swsusp_arch_regs));
 | 
						|
#endif
 | 
						|
 | 
						|
	DEFINE(SH_SLEEP_MODE, offsetof(struct sh_sleep_data, mode));
 | 
						|
	DEFINE(SH_SLEEP_SF_PRE, offsetof(struct sh_sleep_data, sf_pre));
 | 
						|
	DEFINE(SH_SLEEP_SF_POST, offsetof(struct sh_sleep_data, sf_post));
 | 
						|
	DEFINE(SH_SLEEP_RESUME, offsetof(struct sh_sleep_data, resume));
 | 
						|
	DEFINE(SH_SLEEP_VBR, offsetof(struct sh_sleep_data, vbr));
 | 
						|
	DEFINE(SH_SLEEP_SPC, offsetof(struct sh_sleep_data, spc));
 | 
						|
	DEFINE(SH_SLEEP_SR, offsetof(struct sh_sleep_data, sr));
 | 
						|
	DEFINE(SH_SLEEP_SP, offsetof(struct sh_sleep_data, sp));
 | 
						|
	DEFINE(SH_SLEEP_BASE_ADDR, offsetof(struct sh_sleep_data, addr));
 | 
						|
	DEFINE(SH_SLEEP_BASE_DATA, offsetof(struct sh_sleep_data, data));
 | 
						|
	DEFINE(SH_SLEEP_REG_STBCR, offsetof(struct sh_sleep_regs, stbcr));
 | 
						|
	DEFINE(SH_SLEEP_REG_BAR, offsetof(struct sh_sleep_regs, bar));
 | 
						|
	DEFINE(SH_SLEEP_REG_PTEH, offsetof(struct sh_sleep_regs, pteh));
 | 
						|
	DEFINE(SH_SLEEP_REG_PTEL, offsetof(struct sh_sleep_regs, ptel));
 | 
						|
	DEFINE(SH_SLEEP_REG_TTB, offsetof(struct sh_sleep_regs, ttb));
 | 
						|
	DEFINE(SH_SLEEP_REG_TEA, offsetof(struct sh_sleep_regs, tea));
 | 
						|
	DEFINE(SH_SLEEP_REG_MMUCR, offsetof(struct sh_sleep_regs, mmucr));
 | 
						|
	DEFINE(SH_SLEEP_REG_PTEA, offsetof(struct sh_sleep_regs, ptea));
 | 
						|
	DEFINE(SH_SLEEP_REG_PASCR, offsetof(struct sh_sleep_regs, pascr));
 | 
						|
	DEFINE(SH_SLEEP_REG_IRMCR, offsetof(struct sh_sleep_regs, irmcr));
 | 
						|
	DEFINE(SH_SLEEP_REG_CCR, offsetof(struct sh_sleep_regs, ccr));
 | 
						|
	DEFINE(SH_SLEEP_REG_RAMCR, offsetof(struct sh_sleep_regs, ramcr));
 | 
						|
	return 0;
 | 
						|
}
 |