ARMv6 and greater introduced a new instruction ("bx") which can be used
to return from function calls.  Recent CPUs perform better when the
"bx lr" instruction is used rather than the "mov pc, lr" instruction,
and this sequence is strongly recommended to be used by the ARM
architecture manual (section A.4.1.1).
We provide a new macro "ret" with all its variants for the condition
code which will resolve to the appropriate instruction.
Rather than doing this piecemeal, and miss some instances, change all
the "mov pc" instances to use the new macro, with the exception of
the "movs" instruction and the kprobes code.  This allows us to detect
the "mov pc, lr" case and fix it up - and also gives us the possibility
of deploying this for other registers depending on the CPU selection.
Reported-by: Will Deacon <will.deacon@arm.com>
Tested-by: Stephen Warren <swarren@nvidia.com> # Tegra Jetson TK1
Tested-by: Robert Jarzmik <robert.jarzmik@free.fr> # mioa701_bootresume.S
Tested-by: Andrew Lunn <andrew@lunn.ch> # Kirkwood
Tested-by: Shawn Guo <shawn.guo@freescale.com>
Tested-by: Tony Lindgren <tony@atomide.com> # OMAPs
Tested-by: Gregory CLEMENT <gregory.clement@free-electrons.com> # Armada XP, 375, 385
Acked-by: Sekhar Nori <nsekhar@ti.com> # DaVinci
Acked-by: Christoffer Dall <christoffer.dall@linaro.org> # kvm/hyp
Acked-by: Haojian Zhuang <haojian.zhuang@gmail.com> # PXA3xx
Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> # Xen
Tested-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> # ARMv7M
Tested-by: Simon Horman <horms+renesas@verge.net.au> # Shmobile
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
		
	
			
		
			
				
	
	
		
			138 lines
		
	
	
	
		
			2.3 KiB
			
		
	
	
	
		
			ArmAsm
		
	
	
	
	
	
			
		
		
	
	
			138 lines
		
	
	
	
		
			2.3 KiB
			
		
	
	
	
		
			ArmAsm
		
	
	
	
	
	
/*
 | 
						|
 *  linux/arch/arm/kernel/debug.S
 | 
						|
 *
 | 
						|
 *  Copyright (C) 1994-1999 Russell King
 | 
						|
 *
 | 
						|
 * This program is free software; you can redistribute it and/or modify
 | 
						|
 * it under the terms of the GNU General Public License version 2 as
 | 
						|
 * published by the Free Software Foundation.
 | 
						|
 *
 | 
						|
 *  32-bit debugging code
 | 
						|
 */
 | 
						|
#include <linux/linkage.h>
 | 
						|
#include <asm/assembler.h>
 | 
						|
 | 
						|
		.text
 | 
						|
 | 
						|
/*
 | 
						|
 * Some debugging routines (useful if you've got MM problems and
 | 
						|
 * printk isn't working).  For DEBUGGING ONLY!!!  Do not leave
 | 
						|
 * references to these in a production kernel!
 | 
						|
 */
 | 
						|
 | 
						|
#if !defined(CONFIG_DEBUG_SEMIHOSTING)
 | 
						|
#include CONFIG_DEBUG_LL_INCLUDE
 | 
						|
#endif
 | 
						|
 | 
						|
#ifdef CONFIG_MMU
 | 
						|
		.macro	addruart_current, rx, tmp1, tmp2
 | 
						|
		addruart	\tmp1, \tmp2, \rx
 | 
						|
		mrc		p15, 0, \rx, c1, c0
 | 
						|
		tst		\rx, #1
 | 
						|
		moveq		\rx, \tmp1
 | 
						|
		movne		\rx, \tmp2
 | 
						|
		.endm
 | 
						|
 | 
						|
#else /* !CONFIG_MMU */
 | 
						|
		.macro	addruart_current, rx, tmp1, tmp2
 | 
						|
		addruart	\rx, \tmp1
 | 
						|
		.endm
 | 
						|
 | 
						|
#endif /* CONFIG_MMU */
 | 
						|
 | 
						|
/*
 | 
						|
 * Useful debugging routines
 | 
						|
 */
 | 
						|
ENTRY(printhex8)
 | 
						|
		mov	r1, #8
 | 
						|
		b	printhex
 | 
						|
ENDPROC(printhex8)
 | 
						|
 | 
						|
ENTRY(printhex4)
 | 
						|
		mov	r1, #4
 | 
						|
		b	printhex
 | 
						|
ENDPROC(printhex4)
 | 
						|
 | 
						|
ENTRY(printhex2)
 | 
						|
		mov	r1, #2
 | 
						|
printhex:	adr	r2, hexbuf
 | 
						|
		add	r3, r2, r1
 | 
						|
		mov	r1, #0
 | 
						|
		strb	r1, [r3]
 | 
						|
1:		and	r1, r0, #15
 | 
						|
		mov	r0, r0, lsr #4
 | 
						|
		cmp	r1, #10
 | 
						|
		addlt	r1, r1, #'0'
 | 
						|
		addge	r1, r1, #'a' - 10
 | 
						|
		strb	r1, [r3, #-1]!
 | 
						|
		teq	r3, r2
 | 
						|
		bne	1b
 | 
						|
		mov	r0, r2
 | 
						|
		b	printascii
 | 
						|
ENDPROC(printhex2)
 | 
						|
 | 
						|
hexbuf:		.space 16
 | 
						|
 | 
						|
		.ltorg
 | 
						|
 | 
						|
#ifndef CONFIG_DEBUG_SEMIHOSTING
 | 
						|
 | 
						|
ENTRY(printascii)
 | 
						|
		addruart_current r3, r1, r2
 | 
						|
		b	2f
 | 
						|
1:		waituart r2, r3
 | 
						|
		senduart r1, r3
 | 
						|
		busyuart r2, r3
 | 
						|
		teq	r1, #'\n'
 | 
						|
		moveq	r1, #'\r'
 | 
						|
		beq	1b
 | 
						|
2:		teq	r0, #0
 | 
						|
		ldrneb	r1, [r0], #1
 | 
						|
		teqne	r1, #0
 | 
						|
		bne	1b
 | 
						|
		ret	lr
 | 
						|
ENDPROC(printascii)
 | 
						|
 | 
						|
ENTRY(printch)
 | 
						|
		addruart_current r3, r1, r2
 | 
						|
		mov	r1, r0
 | 
						|
		mov	r0, #0
 | 
						|
		b	1b
 | 
						|
ENDPROC(printch)
 | 
						|
 | 
						|
#ifdef CONFIG_MMU
 | 
						|
ENTRY(debug_ll_addr)
 | 
						|
		addruart r2, r3, ip
 | 
						|
		str	r2, [r0]
 | 
						|
		str	r3, [r1]
 | 
						|
		ret	lr
 | 
						|
ENDPROC(debug_ll_addr)
 | 
						|
#endif
 | 
						|
 | 
						|
#else
 | 
						|
 | 
						|
ENTRY(printascii)
 | 
						|
		mov	r1, r0
 | 
						|
		mov	r0, #0x04		@ SYS_WRITE0
 | 
						|
	ARM(	svc	#0x123456	)
 | 
						|
	THUMB(	svc	#0xab		)
 | 
						|
		ret	lr
 | 
						|
ENDPROC(printascii)
 | 
						|
 | 
						|
ENTRY(printch)
 | 
						|
		adr	r1, hexbuf
 | 
						|
		strb	r0, [r1]
 | 
						|
		mov	r0, #0x03		@ SYS_WRITEC
 | 
						|
	ARM(	svc	#0x123456	)
 | 
						|
	THUMB(	svc	#0xab		)
 | 
						|
		ret	lr
 | 
						|
ENDPROC(printch)
 | 
						|
 | 
						|
ENTRY(debug_ll_addr)
 | 
						|
		mov	r2, #0
 | 
						|
		str	r2, [r0]
 | 
						|
		str	r2, [r1]
 | 
						|
		ret	lr
 | 
						|
ENDPROC(debug_ll_addr)
 | 
						|
 | 
						|
#endif
 |