This kind of memcpy() is error-prone. Its replacement with a struct assignment is prefered because it's type-safe and much easier to read. Found by coccinelle. Hand patched and reviewed. Tested by compilation only. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ identifier struct_name; struct struct_name to; struct struct_name from; expression E; @@ -memcpy(&(to), &(from), E); +to = from; // </smpl> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com> Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> |
||
|---|---|---|
| .. | ||
| Kconfig | ||
| Makefile | ||
| philips.txt | ||
| pwc-ctrl.c | ||
| pwc-dec1.c | ||
| pwc-dec1.h | ||
| pwc-dec23.c | ||
| pwc-dec23.h | ||
| pwc-if.c | ||
| pwc-kiara.c | ||
| pwc-kiara.h | ||
| pwc-misc.c | ||
| pwc-nala.h | ||
| pwc-timon.c | ||
| pwc-timon.h | ||
| pwc-uncompress.c | ||
| pwc-v4l.c | ||
| pwc.h | ||