 988cd7afb3
			
		
	
	
	988cd7afb3
	
	
	
		
			
			kernfs_addrm_cxt and the accompanying kernfs_addrm_start/finish() were
added because there were operations which should be performed outside
kernfs_mutex after adding and removing kernfs_nodes.  The necessary
operations were recorded in kernfs_addrm_cxt and performed by
kernfs_addrm_finish(); however, after the recent changes which
relocated deactivation and unmapping so that they're performed
directly during removal, the only operation kernfs_addrm_finish()
performs is kernfs_put(), which can be moved inside the removal path
too.
This patch moves the kernfs_put() of the base ref to __kernfs_remove()
and remove kernfs_addrm_cxt and kernfs_addrm_start/finish().
* kernfs_add_one() is updated to grab and release kernfs_mutex itself.
  sysfs_addrm_start/finish() invocations around it are removed from
  all users.
* __kernfs_remove() puts an unlinked node directly instead of chaining
  it to kernfs_addrm_cxt.  Its callers are updated to grab and release
  kernfs_mutex instead of calling kernfs_addrm_start/finish() around
  it.
v2: Rebased on top of "kernfs: associate a new kernfs_node with its
    parent on creation" which dropped @parent from kernfs_add_one().
Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
		
	
			
		
			
				
	
	
		
			147 lines
		
	
	
	
		
			3.3 KiB
			
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			147 lines
		
	
	
	
		
			3.3 KiB
			
		
	
	
	
		
			C
		
	
	
	
	
	
| /*
 | |
|  * fs/kernfs/symlink.c - kernfs symlink implementation
 | |
|  *
 | |
|  * Copyright (c) 2001-3 Patrick Mochel
 | |
|  * Copyright (c) 2007 SUSE Linux Products GmbH
 | |
|  * Copyright (c) 2007, 2013 Tejun Heo <tj@kernel.org>
 | |
|  *
 | |
|  * This file is released under the GPLv2.
 | |
|  */
 | |
| 
 | |
| #include <linux/fs.h>
 | |
| #include <linux/gfp.h>
 | |
| #include <linux/namei.h>
 | |
| 
 | |
| #include "kernfs-internal.h"
 | |
| 
 | |
| /**
 | |
|  * kernfs_create_link - create a symlink
 | |
|  * @parent: directory to create the symlink in
 | |
|  * @name: name of the symlink
 | |
|  * @target: target node for the symlink to point to
 | |
|  *
 | |
|  * Returns the created node on success, ERR_PTR() value on error.
 | |
|  */
 | |
| struct kernfs_node *kernfs_create_link(struct kernfs_node *parent,
 | |
| 				       const char *name,
 | |
| 				       struct kernfs_node *target)
 | |
| {
 | |
| 	struct kernfs_node *kn;
 | |
| 	int error;
 | |
| 
 | |
| 	kn = kernfs_new_node(parent, name, S_IFLNK|S_IRWXUGO, KERNFS_LINK);
 | |
| 	if (!kn)
 | |
| 		return ERR_PTR(-ENOMEM);
 | |
| 
 | |
| 	if (kernfs_ns_enabled(parent))
 | |
| 		kn->ns = target->ns;
 | |
| 	kn->symlink.target_kn = target;
 | |
| 	kernfs_get(target);	/* ref owned by symlink */
 | |
| 
 | |
| 	error = kernfs_add_one(kn);
 | |
| 	if (!error)
 | |
| 		return kn;
 | |
| 
 | |
| 	kernfs_put(kn);
 | |
| 	return ERR_PTR(error);
 | |
| }
 | |
| 
 | |
| static int kernfs_get_target_path(struct kernfs_node *parent,
 | |
| 				  struct kernfs_node *target, char *path)
 | |
| {
 | |
| 	struct kernfs_node *base, *kn;
 | |
| 	char *s = path;
 | |
| 	int len = 0;
 | |
| 
 | |
| 	/* go up to the root, stop at the base */
 | |
| 	base = parent;
 | |
| 	while (base->parent) {
 | |
| 		kn = target->parent;
 | |
| 		while (kn->parent && base != kn)
 | |
| 			kn = kn->parent;
 | |
| 
 | |
| 		if (base == kn)
 | |
| 			break;
 | |
| 
 | |
| 		strcpy(s, "../");
 | |
| 		s += 3;
 | |
| 		base = base->parent;
 | |
| 	}
 | |
| 
 | |
| 	/* determine end of target string for reverse fillup */
 | |
| 	kn = target;
 | |
| 	while (kn->parent && kn != base) {
 | |
| 		len += strlen(kn->name) + 1;
 | |
| 		kn = kn->parent;
 | |
| 	}
 | |
| 
 | |
| 	/* check limits */
 | |
| 	if (len < 2)
 | |
| 		return -EINVAL;
 | |
| 	len--;
 | |
| 	if ((s - path) + len > PATH_MAX)
 | |
| 		return -ENAMETOOLONG;
 | |
| 
 | |
| 	/* reverse fillup of target string from target to base */
 | |
| 	kn = target;
 | |
| 	while (kn->parent && kn != base) {
 | |
| 		int slen = strlen(kn->name);
 | |
| 
 | |
| 		len -= slen;
 | |
| 		strncpy(s + len, kn->name, slen);
 | |
| 		if (len)
 | |
| 			s[--len] = '/';
 | |
| 
 | |
| 		kn = kn->parent;
 | |
| 	}
 | |
| 
 | |
| 	return 0;
 | |
| }
 | |
| 
 | |
| static int kernfs_getlink(struct dentry *dentry, char *path)
 | |
| {
 | |
| 	struct kernfs_node *kn = dentry->d_fsdata;
 | |
| 	struct kernfs_node *parent = kn->parent;
 | |
| 	struct kernfs_node *target = kn->symlink.target_kn;
 | |
| 	int error;
 | |
| 
 | |
| 	mutex_lock(&kernfs_mutex);
 | |
| 	error = kernfs_get_target_path(parent, target, path);
 | |
| 	mutex_unlock(&kernfs_mutex);
 | |
| 
 | |
| 	return error;
 | |
| }
 | |
| 
 | |
| static void *kernfs_iop_follow_link(struct dentry *dentry, struct nameidata *nd)
 | |
| {
 | |
| 	int error = -ENOMEM;
 | |
| 	unsigned long page = get_zeroed_page(GFP_KERNEL);
 | |
| 	if (page) {
 | |
| 		error = kernfs_getlink(dentry, (char *) page);
 | |
| 		if (error < 0)
 | |
| 			free_page((unsigned long)page);
 | |
| 	}
 | |
| 	nd_set_link(nd, error ? ERR_PTR(error) : (char *)page);
 | |
| 	return NULL;
 | |
| }
 | |
| 
 | |
| static void kernfs_iop_put_link(struct dentry *dentry, struct nameidata *nd,
 | |
| 				void *cookie)
 | |
| {
 | |
| 	char *page = nd_get_link(nd);
 | |
| 	if (!IS_ERR(page))
 | |
| 		free_page((unsigned long)page);
 | |
| }
 | |
| 
 | |
| const struct inode_operations kernfs_symlink_iops = {
 | |
| 	.setxattr	= kernfs_iop_setxattr,
 | |
| 	.removexattr	= kernfs_iop_removexattr,
 | |
| 	.getxattr	= kernfs_iop_getxattr,
 | |
| 	.listxattr	= kernfs_iop_listxattr,
 | |
| 	.readlink	= generic_readlink,
 | |
| 	.follow_link	= kernfs_iop_follow_link,
 | |
| 	.put_link	= kernfs_iop_put_link,
 | |
| 	.setattr	= kernfs_iop_setattr,
 | |
| 	.getattr	= kernfs_iop_getattr,
 | |
| 	.permission	= kernfs_iop_permission,
 | |
| };
 |