sysfs assumed 0755 for all newly created directories and kernfs inherited it. This assumption is unnecessarily restrictive and inconsistent with kernfs_create_file[_ns](). This patch adds @mode parameter to kernfs_create_dir[_ns]() and update uses in sysfs accordingly. Among others, this will be useful for implementations of the planned ->mkdir() method. This patch doesn't introduce any behavior differences. Signed-off-by: Tejun Heo <tj@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
		
			
				
	
	
		
			141 lines
		
	
	
	
		
			3.6 KiB
			
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			141 lines
		
	
	
	
		
			3.6 KiB
			
		
	
	
	
		
			C
		
	
	
	
	
	
/*
 | 
						|
 * fs/sysfs/dir.c - sysfs core and dir operation implementation
 | 
						|
 *
 | 
						|
 * Copyright (c) 2001-3 Patrick Mochel
 | 
						|
 * Copyright (c) 2007 SUSE Linux Products GmbH
 | 
						|
 * Copyright (c) 2007 Tejun Heo <teheo@suse.de>
 | 
						|
 *
 | 
						|
 * This file is released under the GPLv2.
 | 
						|
 *
 | 
						|
 * Please see Documentation/filesystems/sysfs.txt for more information.
 | 
						|
 */
 | 
						|
 | 
						|
#undef DEBUG
 | 
						|
 | 
						|
#include <linux/fs.h>
 | 
						|
#include <linux/kobject.h>
 | 
						|
#include <linux/slab.h>
 | 
						|
#include "sysfs.h"
 | 
						|
 | 
						|
DEFINE_SPINLOCK(sysfs_symlink_target_lock);
 | 
						|
 | 
						|
/**
 | 
						|
 *	sysfs_pathname - return full path to sysfs dirent
 | 
						|
 *	@kn: kernfs_node whose path we want
 | 
						|
 *	@path: caller allocated buffer of size PATH_MAX
 | 
						|
 *
 | 
						|
 *	Gives the name "/" to the sysfs_root entry; any path returned
 | 
						|
 *	is relative to wherever sysfs is mounted.
 | 
						|
 */
 | 
						|
static char *sysfs_pathname(struct kernfs_node *kn, char *path)
 | 
						|
{
 | 
						|
	if (kn->parent) {
 | 
						|
		sysfs_pathname(kn->parent, path);
 | 
						|
		strlcat(path, "/", PATH_MAX);
 | 
						|
	}
 | 
						|
	strlcat(path, kn->name, PATH_MAX);
 | 
						|
	return path;
 | 
						|
}
 | 
						|
 | 
						|
void sysfs_warn_dup(struct kernfs_node *parent, const char *name)
 | 
						|
{
 | 
						|
	char *path;
 | 
						|
 | 
						|
	path = kzalloc(PATH_MAX, GFP_KERNEL);
 | 
						|
	if (path) {
 | 
						|
		sysfs_pathname(parent, path);
 | 
						|
		strlcat(path, "/", PATH_MAX);
 | 
						|
		strlcat(path, name, PATH_MAX);
 | 
						|
	}
 | 
						|
 | 
						|
	WARN(1, KERN_WARNING "sysfs: cannot create duplicate filename '%s'\n",
 | 
						|
	     path ? path : name);
 | 
						|
 | 
						|
	kfree(path);
 | 
						|
}
 | 
						|
 | 
						|
/**
 | 
						|
 * sysfs_create_dir_ns - create a directory for an object with a namespace tag
 | 
						|
 * @kobj: object we're creating directory for
 | 
						|
 * @ns: the namespace tag to use
 | 
						|
 */
 | 
						|
int sysfs_create_dir_ns(struct kobject *kobj, const void *ns)
 | 
						|
{
 | 
						|
	struct kernfs_node *parent, *kn;
 | 
						|
 | 
						|
	BUG_ON(!kobj);
 | 
						|
 | 
						|
	if (kobj->parent)
 | 
						|
		parent = kobj->parent->sd;
 | 
						|
	else
 | 
						|
		parent = sysfs_root_kn;
 | 
						|
 | 
						|
	if (!parent)
 | 
						|
		return -ENOENT;
 | 
						|
 | 
						|
	kn = kernfs_create_dir_ns(parent, kobject_name(kobj),
 | 
						|
				  S_IRWXU | S_IRUGO | S_IXUGO, kobj, ns);
 | 
						|
	if (IS_ERR(kn)) {
 | 
						|
		if (PTR_ERR(kn) == -EEXIST)
 | 
						|
			sysfs_warn_dup(parent, kobject_name(kobj));
 | 
						|
		return PTR_ERR(kn);
 | 
						|
	}
 | 
						|
 | 
						|
	kobj->sd = kn;
 | 
						|
	return 0;
 | 
						|
}
 | 
						|
 | 
						|
/**
 | 
						|
 *	sysfs_remove_dir - remove an object's directory.
 | 
						|
 *	@kobj:	object.
 | 
						|
 *
 | 
						|
 *	The only thing special about this is that we remove any files in
 | 
						|
 *	the directory before we remove the directory, and we've inlined
 | 
						|
 *	what used to be sysfs_rmdir() below, instead of calling separately.
 | 
						|
 */
 | 
						|
void sysfs_remove_dir(struct kobject *kobj)
 | 
						|
{
 | 
						|
	struct kernfs_node *kn = kobj->sd;
 | 
						|
 | 
						|
	/*
 | 
						|
	 * In general, kboject owner is responsible for ensuring removal
 | 
						|
	 * doesn't race with other operations and sysfs doesn't provide any
 | 
						|
	 * protection; however, when @kobj is used as a symlink target, the
 | 
						|
	 * symlinking entity usually doesn't own @kobj and thus has no
 | 
						|
	 * control over removal.  @kobj->sd may be removed anytime
 | 
						|
	 * and symlink code may end up dereferencing an already freed node.
 | 
						|
	 *
 | 
						|
	 * sysfs_symlink_target_lock synchronizes @kobj->sd
 | 
						|
	 * disassociation against symlink operations so that symlink code
 | 
						|
	 * can safely dereference @kobj->sd.
 | 
						|
	 */
 | 
						|
	spin_lock(&sysfs_symlink_target_lock);
 | 
						|
	kobj->sd = NULL;
 | 
						|
	spin_unlock(&sysfs_symlink_target_lock);
 | 
						|
 | 
						|
	if (kn) {
 | 
						|
		WARN_ON_ONCE(kernfs_type(kn) != KERNFS_DIR);
 | 
						|
		kernfs_remove(kn);
 | 
						|
	}
 | 
						|
}
 | 
						|
 | 
						|
int sysfs_rename_dir_ns(struct kobject *kobj, const char *new_name,
 | 
						|
			const void *new_ns)
 | 
						|
{
 | 
						|
	struct kernfs_node *parent = kobj->sd->parent;
 | 
						|
 | 
						|
	return kernfs_rename_ns(kobj->sd, parent, new_name, new_ns);
 | 
						|
}
 | 
						|
 | 
						|
int sysfs_move_dir_ns(struct kobject *kobj, struct kobject *new_parent_kobj,
 | 
						|
		      const void *new_ns)
 | 
						|
{
 | 
						|
	struct kernfs_node *kn = kobj->sd;
 | 
						|
	struct kernfs_node *new_parent;
 | 
						|
 | 
						|
	BUG_ON(!kn->parent);
 | 
						|
	new_parent = new_parent_kobj && new_parent_kobj->sd ?
 | 
						|
		new_parent_kobj->sd : sysfs_root_kn;
 | 
						|
 | 
						|
	return kernfs_rename_ns(kn, new_parent, kn->name, new_ns);
 | 
						|
}
 |