d53e57d039
Each call to tui_progress__update() would forcibly refresh the entire screen. This is somewhat inefficient and causes noticable flickering during the startup of perf-report, especially on large/slow terminals. It looks like the force-refresh in tui_progress__update() serves no purpose other than to clear the screen so that the progress bar of a previous operation does not subsume that of a subsequent operation. But we can do just that in a much more efficient manner by clearing only the region that a previous progress bar may have occupied before repainting the new progress bar. Then the force-refresh could be removed with no change in visuals. This patch disables the slow force-refresh in tui_progress__update() and instead calls SLsmg_fill_region() on the entire area that the progress bar may occupy before repainting it. This change makes the startup of perf-report much faster and appear much "smoother". It turns out that this was a big bottleneck in the startup speed of perf-report -- with this patch, perf-report starts up ~2x faster (1.1s vs 0.55s) on my machines. (These numbers were measured by running "time perf report" on an 8MB perf.data and pressing 'q' immediately.) Signed-off-by: Patrick Palka <patrick@parcs.ath.cx> Acked-by: Ingo Molnar <mingo@kernel.org> Cc: Ingo Molnar <mingo@kernel.org> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Link: http://lkml.kernel.org/r/1382747149-9716-1-git-send-email-patrick@parcs.ath.cx Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
44 lines
1 KiB
C
44 lines
1 KiB
C
#include "../cache.h"
|
|
#include "../progress.h"
|
|
#include "../libslang.h"
|
|
#include "../ui.h"
|
|
#include "tui.h"
|
|
#include "../browser.h"
|
|
|
|
static void tui_progress__update(struct ui_progress *p)
|
|
{
|
|
int bar, y;
|
|
/*
|
|
* FIXME: We should have a per UI backend way of showing progress,
|
|
* stdio will just show a percentage as NN%, etc.
|
|
*/
|
|
if (use_browser <= 0)
|
|
return;
|
|
|
|
if (p->total == 0)
|
|
return;
|
|
|
|
ui__refresh_dimensions(false);
|
|
pthread_mutex_lock(&ui__lock);
|
|
y = SLtt_Screen_Rows / 2 - 2;
|
|
SLsmg_set_color(0);
|
|
SLsmg_draw_box(y, 0, 3, SLtt_Screen_Cols);
|
|
SLsmg_gotorc(y++, 1);
|
|
SLsmg_write_string((char *)p->title);
|
|
SLsmg_fill_region(y, 1, 1, SLtt_Screen_Cols - 2, ' ');
|
|
SLsmg_set_color(HE_COLORSET_SELECTED);
|
|
bar = ((SLtt_Screen_Cols - 2) * p->curr) / p->total;
|
|
SLsmg_fill_region(y, 1, 1, bar, ' ');
|
|
SLsmg_refresh();
|
|
pthread_mutex_unlock(&ui__lock);
|
|
}
|
|
|
|
static struct ui_progress_ops tui_progress__ops =
|
|
{
|
|
.update = tui_progress__update,
|
|
};
|
|
|
|
void tui_progress__init(void)
|
|
{
|
|
ui_progress__ops = &tui_progress__ops;
|
|
}
|