forge/linux-pinenote
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
linux-pinenote/drivers/bus
History
Bjorn Helgaas e1d9749730 MIPS: Remove "weak" from mips_cdmm_phys_base() declaration 
Weak header file declarations are error-prone because they make every
definition weak, and the linker chooses one based on link order (see
10629d711e ("PCI: Remove __weak annotation from pcibios_get_phb_of_node
decl")).

mips_cdmm_phys_base() is defined only in arch/mips/mti-malta/malta-memory.c
so there's no problem with multiple definitions.  But it works better to
have a weak default implementation and allow a strong function to override
it.  Then we don't have to test whether a definition is present, and if
there are ever multiple strong definitions, we get a link error instead of
calling a random definition.

Add a weak mips_cdmm_phys_base() definition and remove the weak annotation
from the declaration in arch/mips/include/asm/cdmm.h.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: James Hogan <james.hogan@imgtec.com>
Cc: Andrew Bresticker <abrestic@chromium.org>
Cc: linux-mips@linux-mips.org
Cc: linux-kernel@vger.kernel.org
Patchwork: https://patchwork.linux-mips.org/patch/10688/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
2015-09-03 12:07:39 +02:00
..
arm-cci.c arm-cci: Add aliases for PMU events 2015-05-29 16:43:52 +02:00
arm-ccn.c bus: arm-ccn: Use hrtimer_start() again 2015-05-13 18:18:00 +02:00
brcmstb_gisb.c bus: brcmstb_gisb: Honor the "big-endian" and "native-endian" DT properties 2015-05-28 21:00:20 -07:00
imx-weim.c bus: imx-weim: improve error handling upon child probe-failure 2015-03-02 21:47:59 +08:00
Kconfig arm-cci: Add CCI-500 PMU support 2015-05-29 16:43:51 +02:00
Makefile ARM: SoC driver updates for v4.1 2015-04-22 09:18:17 -07:00
mips_cdmm.c MIPS: Remove "weak" from mips_cdmm_phys_base() declaration 2015-09-03 12:07:39 +02:00
mvebu-mbus.c bus: mvebu-mbus: add mv_mbus_dram_info_nooverlap() 2015-05-28 12:21:08 +02:00
omap-ocp2scp.c bus: ocp2scp: SYNC2 value should be changed to 0x6 2015-03-26 10:48:11 -07:00
omap_l3_noc.c Merge branches 'pm-sleep' and 'pm-runtime' 2015-06-19 01:18:02 +02:00
omap_l3_noc.h bus: omap_l3_noc: Fix master id address decoding for OMAP5 2015-05-04 10:21:01 -07:00
omap_l3_smx.c genirq: Remove the deprecated 'IRQF_DISABLED' request_irq() flag entirely 2015-03-05 20:53:06 +01:00
omap_l3_smx.h
simple-pm-bus.c drivers: bus: Add Simple Power-Managed Bus Driver 2015-02-24 06:36:18 +09:00
vexpress-config.c ARM: vexpress: refine dependencies for new code 2014-05-26 21:26:52 +02:00