 00a158be83
			
		
	
	
	00a158be83
	
	
	
		
			
			This patch checks if i_goal is either zero or if doesn't exist within any rgrp (i.e gfs2_blk2rgrpd() returns NULL). If so, it assigns the ip->i_no_addr block as the i_goal. There are two scenarios where a bad i_goal can result in a -EBADSLT error. 1. Attempting to allocate to an existing inode: Control reaches gfs2_inplace_reserve() and ip->i_goal is bad. We need to fix i_goal here. 2. A new inode is created in a directory whose i_goal is hosed: In this case, the parent dir's i_goal is copied onto the new inode. Since the new inode is not yet created, the ip->i_no_addr field is invalid and so, the fix in gfs2_inplace_reserve() as per 1) won't work in this scenario. We need to catch and fix it sooner in the parent dir itself (gfs2_create_inode()), before it is copied to the new inode. Signed-off-by: Abhi Das <adas@redhat.com> Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
		
			
				
	
	
		
			84 lines
		
	
	
	
		
			3.2 KiB
			
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			84 lines
		
	
	
	
		
			3.2 KiB
			
		
	
	
	
		
			C
		
	
	
	
	
	
| /*
 | |
|  * Copyright (C) Sistina Software, Inc.  1997-2003 All rights reserved.
 | |
|  * Copyright (C) 2004-2008 Red Hat, Inc.  All rights reserved.
 | |
|  *
 | |
|  * This copyrighted material is made available to anyone wishing to use,
 | |
|  * modify, copy, or redistribute it subject to the terms and conditions
 | |
|  * of the GNU General Public License version 2.
 | |
|  */
 | |
| 
 | |
| #ifndef __RGRP_DOT_H__
 | |
| #define __RGRP_DOT_H__
 | |
| 
 | |
| #include <linux/slab.h>
 | |
| #include <linux/uaccess.h>
 | |
| 
 | |
| /* Since each block in the file system is represented by two bits in the
 | |
|  * bitmap, one 64-bit word in the bitmap will represent 32 blocks.
 | |
|  * By reserving 32 blocks at a time, we can optimize / shortcut how we search
 | |
|  * through the bitmaps by looking a word at a time.
 | |
|  */
 | |
| #define RGRP_RSRV_MINBYTES 8
 | |
| #define RGRP_RSRV_MINBLKS ((u32)(RGRP_RSRV_MINBYTES * GFS2_NBBY))
 | |
| 
 | |
| struct gfs2_rgrpd;
 | |
| struct gfs2_sbd;
 | |
| struct gfs2_holder;
 | |
| 
 | |
| extern void gfs2_rgrp_verify(struct gfs2_rgrpd *rgd);
 | |
| 
 | |
| extern struct gfs2_rgrpd *gfs2_blk2rgrpd(struct gfs2_sbd *sdp, u64 blk, bool exact);
 | |
| extern struct gfs2_rgrpd *gfs2_rgrpd_get_first(struct gfs2_sbd *sdp);
 | |
| extern struct gfs2_rgrpd *gfs2_rgrpd_get_next(struct gfs2_rgrpd *rgd);
 | |
| 
 | |
| extern void gfs2_clear_rgrpd(struct gfs2_sbd *sdp);
 | |
| extern int gfs2_rindex_update(struct gfs2_sbd *sdp);
 | |
| extern void gfs2_free_clones(struct gfs2_rgrpd *rgd);
 | |
| extern int gfs2_rgrp_go_lock(struct gfs2_holder *gh);
 | |
| extern void gfs2_rgrp_go_unlock(struct gfs2_holder *gh);
 | |
| 
 | |
| extern struct gfs2_alloc *gfs2_alloc_get(struct gfs2_inode *ip);
 | |
| 
 | |
| #define GFS2_AF_ORLOV 1
 | |
| extern int gfs2_inplace_reserve(struct gfs2_inode *ip, const struct gfs2_alloc_parms *ap);
 | |
| extern void gfs2_inplace_release(struct gfs2_inode *ip);
 | |
| 
 | |
| extern int gfs2_alloc_blocks(struct gfs2_inode *ip, u64 *bn, unsigned int *n,
 | |
| 			     bool dinode, u64 *generation);
 | |
| 
 | |
| extern int gfs2_rs_alloc(struct gfs2_inode *ip);
 | |
| extern void gfs2_rs_deltree(struct gfs2_blkreserv *rs);
 | |
| extern void gfs2_rs_delete(struct gfs2_inode *ip, atomic_t *wcount);
 | |
| extern void __gfs2_free_blocks(struct gfs2_inode *ip, u64 bstart, u32 blen, int meta);
 | |
| extern void gfs2_free_meta(struct gfs2_inode *ip, u64 bstart, u32 blen);
 | |
| extern void gfs2_free_di(struct gfs2_rgrpd *rgd, struct gfs2_inode *ip);
 | |
| extern void gfs2_unlink_di(struct inode *inode);
 | |
| extern int gfs2_check_blk_type(struct gfs2_sbd *sdp, u64 no_addr,
 | |
| 			       unsigned int type);
 | |
| 
 | |
| struct gfs2_rgrp_list {
 | |
| 	unsigned int rl_rgrps;
 | |
| 	unsigned int rl_space;
 | |
| 	struct gfs2_rgrpd **rl_rgd;
 | |
| 	struct gfs2_holder *rl_ghs;
 | |
| };
 | |
| 
 | |
| extern void gfs2_rlist_add(struct gfs2_inode *ip, struct gfs2_rgrp_list *rlist,
 | |
| 			   u64 block);
 | |
| extern void gfs2_rlist_alloc(struct gfs2_rgrp_list *rlist, unsigned int state);
 | |
| extern void gfs2_rlist_free(struct gfs2_rgrp_list *rlist);
 | |
| extern u64 gfs2_ri_total(struct gfs2_sbd *sdp);
 | |
| extern void gfs2_rgrp_dump(struct seq_file *seq, const struct gfs2_glock *gl);
 | |
| extern int gfs2_rgrp_send_discards(struct gfs2_sbd *sdp, u64 offset,
 | |
| 				   struct buffer_head *bh,
 | |
| 				   const struct gfs2_bitmap *bi, unsigned minlen, u64 *ptrimmed);
 | |
| extern int gfs2_fitrim(struct file *filp, void __user *argp);
 | |
| 
 | |
| /* This is how to tell if a reservation is in the rgrp tree: */
 | |
| static inline bool gfs2_rs_active(struct gfs2_blkreserv *rs)
 | |
| {
 | |
| 	return rs && !RB_EMPTY_NODE(&rs->rs_node);
 | |
| }
 | |
| 
 | |
| extern void check_and_update_goal(struct gfs2_inode *ip);
 | |
| #endif /* __RGRP_DOT_H__ */
 |