Meelis Roos reported that kernels built with gcc-4.9 do not boot, we eventually narrowed this down to only impacting machines using UltraSPARC-III and derivitive cpus. The crash happens right when the first user process is spawned: [ 54.451346] Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000004 [ 54.451346] [ 54.571516] CPU: 1 PID: 1 Comm: init Not tainted 3.16.0-rc2-00211-gd7933ab #96 [ 54.666431] Call Trace: [ 54.698453] [0000000000762f8c] panic+0xb0/0x224 [ 54.759071] [000000000045cf68] do_exit+0x948/0x960 [ 54.823123] [000000000042cbc0] fault_in_user_windows+0xe0/0x100 [ 54.902036] [0000000000404ad0] __handle_user_windows+0x0/0x10 [ 54.978662] Press Stop-A (L1-A) to return to the boot prom [ 55.050713] ---[ end Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000004 Further investigation showed that compiling only per_cpu_patch() with an older compiler fixes the boot. Detailed analysis showed that the function is not being miscompiled by gcc-4.9, but it is using a different register allocation ordering. With the gcc-4.9 compiled function, something during the code patching causes some of the %i* input registers to get corrupted. Perhaps we have a TLB miss path into the firmware that is deep enough to cause a register window spill and subsequent restore when we get back from the TLB miss trap. Let's plug this up by doing two things: 1) Stop using the firmware stack for client interface calls into the firmware. Just use the kernel's stack. 2) As soon as we can, call into a new function "start_early_boot()" to put a one-register-window buffer between the firmware's deepest stack frame and the top-most initial kernel one. Reported-by: Meelis Roos <mroos@linux.ee> Tested-by: Meelis Roos <mroos@linux.ee> Signed-off-by: David S. Miller <davem@davemloft.net>
		
			
				
	
	
		
			68 lines
		
	
	
	
		
			1.4 KiB
			
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			68 lines
		
	
	
	
		
			1.4 KiB
			
		
	
	
	
		
			C
		
	
	
	
	
	
/*
 | 
						|
 *	Just a place holder. 
 | 
						|
 */
 | 
						|
#ifndef _SPARC_SETUP_H
 | 
						|
#define _SPARC_SETUP_H
 | 
						|
 | 
						|
#include <linux/interrupt.h>
 | 
						|
 | 
						|
#include <uapi/asm/setup.h>
 | 
						|
 | 
						|
extern char reboot_command[];
 | 
						|
 | 
						|
#ifdef CONFIG_SPARC32
 | 
						|
/* The CPU that was used for booting
 | 
						|
 * Only sun4d + leon may have boot_cpu_id != 0
 | 
						|
 */
 | 
						|
extern unsigned char boot_cpu_id;
 | 
						|
 | 
						|
extern unsigned long empty_zero_page;
 | 
						|
 | 
						|
extern int serial_console;
 | 
						|
static inline int con_is_present(void)
 | 
						|
{
 | 
						|
	return serial_console ? 0 : 1;
 | 
						|
}
 | 
						|
 | 
						|
/* from irq_32.c */
 | 
						|
extern volatile unsigned char *fdc_status;
 | 
						|
extern char *pdma_vaddr;
 | 
						|
extern unsigned long pdma_size;
 | 
						|
extern volatile int doing_pdma;
 | 
						|
 | 
						|
/* This is software state */
 | 
						|
extern char *pdma_base;
 | 
						|
extern unsigned long pdma_areasize;
 | 
						|
 | 
						|
int sparc_floppy_request_irq(unsigned int irq, irq_handler_t irq_handler);
 | 
						|
 | 
						|
/* setup_32.c */
 | 
						|
extern unsigned long cmdline_memory_size;
 | 
						|
 | 
						|
/* devices.c */
 | 
						|
void __init device_scan(void);
 | 
						|
 | 
						|
/* unaligned_32.c */
 | 
						|
unsigned long safe_compute_effective_address(struct pt_regs *, unsigned int);
 | 
						|
 | 
						|
#endif
 | 
						|
 | 
						|
#ifdef CONFIG_SPARC64
 | 
						|
void __init start_early_boot(void);
 | 
						|
 | 
						|
/* unaligned_64.c */
 | 
						|
int handle_ldf_stq(u32 insn, struct pt_regs *regs);
 | 
						|
void handle_ld_nf(u32 insn, struct pt_regs *regs);
 | 
						|
 | 
						|
/* init_64.c */
 | 
						|
extern atomic_t dcpage_flushes;
 | 
						|
extern atomic_t dcpage_flushes_xcall;
 | 
						|
 | 
						|
extern int sysctl_tsb_ratio;
 | 
						|
#endif
 | 
						|
 | 
						|
void sun_do_break(void);
 | 
						|
extern int stop_a_enabled;
 | 
						|
extern int scons_pwroff;
 | 
						|
 | 
						|
#endif /* _SPARC_SETUP_H */
 |