 aacd9289af
			
		
	
	
	aacd9289af
	
	
	
		
			
			We must try harder to get unique (addr, port) pairs when
doing port autoselection for sockets with SO_REUSEADDR
option set.
We achieve this by adding a relaxation parameter to
inet_csk_bind_conflict. When 'relax' parameter is off
we return a conflict whenever the current searched
pair (addr, port) is not unique.
This tries to address the problems reported in patch:
	8d238b25b1
	Revert "tcp: bind() fix when many ports are bound"
Tests where ran for creating and binding(0) many sockets
on 100 IPs. The results are, on average:
	* 60000 sockets, 600 ports / IP:
		* 0.210 s, 620 (IP, port) duplicates without patch
		* 0.219 s, no duplicates with patch
	* 100000 sockets, 1000 ports / IP:
		* 0.371 s, 1720 duplicates without patch
		* 0.373 s, no duplicates with patch
	* 200000 sockets, 2000 ports / IP:
		* 0.766 s, 6900 duplicates without patch
		* 0.768 s, no duplicates with patch
	* 500000 sockets, 5000 ports / IP:
		* 2.227 s, 41500 duplicates without patch
		* 2.284 s, no duplicates with patch
Signed-off-by: Alex Copot <alex.mihai.c@gmail.com>
Signed-off-by: Daniel Baluta <dbaluta@ixiacom.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
		
	
			
		
			
				
	
	
		
			45 lines
		
	
	
	
		
			1.4 KiB
			
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			45 lines
		
	
	
	
		
			1.4 KiB
			
		
	
	
	
		
			C
		
	
	
	
	
	
| /*
 | |
|  * NET		Generic infrastructure for INET6 connection oriented protocols.
 | |
|  *
 | |
|  * Authors:	Many people, see the TCPv6 sources
 | |
|  *
 | |
|  * 		From code originally in TCPv6
 | |
|  *
 | |
|  *		This program is free software; you can redistribute it and/or
 | |
|  *		modify it under the terms of the GNU General Public License
 | |
|  *		as published by the Free Software Foundation; either version
 | |
|  *		2 of the License, or (at your option) any later version.
 | |
|  */
 | |
| #ifndef _INET6_CONNECTION_SOCK_H
 | |
| #define _INET6_CONNECTION_SOCK_H
 | |
| 
 | |
| #include <linux/types.h>
 | |
| 
 | |
| struct in6_addr;
 | |
| struct inet_bind_bucket;
 | |
| struct request_sock;
 | |
| struct sk_buff;
 | |
| struct sock;
 | |
| struct sockaddr;
 | |
| 
 | |
| extern int inet6_csk_bind_conflict(const struct sock *sk,
 | |
| 				   const struct inet_bind_bucket *tb, bool relax);
 | |
| 
 | |
| extern struct dst_entry* inet6_csk_route_req(struct sock *sk,
 | |
| 					     const struct request_sock *req);
 | |
| 
 | |
| extern struct request_sock *inet6_csk_search_req(const struct sock *sk,
 | |
| 						 struct request_sock ***prevp,
 | |
| 						 const __be16 rport,
 | |
| 						 const struct in6_addr *raddr,
 | |
| 						 const struct in6_addr *laddr,
 | |
| 						 const int iif);
 | |
| 
 | |
| extern void inet6_csk_reqsk_queue_hash_add(struct sock *sk,
 | |
| 					   struct request_sock *req,
 | |
| 					   const unsigned long timeout);
 | |
| 
 | |
| extern void inet6_csk_addr2sockaddr(struct sock *sk, struct sockaddr *uaddr);
 | |
| 
 | |
| extern int inet6_csk_xmit(struct sk_buff *skb, struct flowi *fl);
 | |
| #endif /* _INET6_CONNECTION_SOCK_H */
 |