 f687f3263e
			
		
	
	
	f687f3263e
	
	
	
		
			
			In scan_async_group() if the size parameter is negative, the sasd pointer
will be used uninitialised:
drivers/media/platform/soc_camera/soc_camera.c: In function "soc_camera_host_register":
drivers/media/platform/soc_camera/soc_camera.c:1514:55: warning: "sasd" may
be used uninitialized in this function [-Wmaybe-uninitialized]
    sasd->asd.match.i2c.adapter_id, sasd->asd.match.i2c.address);
                                                       ^
drivers/media/platform/soc_camera/soc_camera.c:1464:34: note: "sasd" was
declared here
  struct soc_camera_async_subdev *sasd;
Fix this by making "size" and the array, from which it is assigned unsigned.
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
		
	
			
		
			
				
	
	
		
			29 lines
		
	
	
	
		
			866 B
			
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			29 lines
		
	
	
	
		
			866 B
			
		
	
	
	
		
			C
		
	
	
	
	
	
| #ifndef __ASM_SH_MOBILE_CEU_H__
 | |
| #define __ASM_SH_MOBILE_CEU_H__
 | |
| 
 | |
| #define SH_CEU_FLAG_USE_8BIT_BUS	(1 << 0) /* use  8bit bus width */
 | |
| #define SH_CEU_FLAG_USE_16BIT_BUS	(1 << 1) /* use 16bit bus width */
 | |
| #define SH_CEU_FLAG_HSYNC_LOW		(1 << 2) /* default High if possible */
 | |
| #define SH_CEU_FLAG_VSYNC_LOW		(1 << 3) /* default High if possible */
 | |
| #define SH_CEU_FLAG_LOWER_8BIT		(1 << 4) /* default upper 8bit */
 | |
| 
 | |
| struct device;
 | |
| struct resource;
 | |
| 
 | |
| struct sh_mobile_ceu_companion {
 | |
| 	u32		num_resources;
 | |
| 	struct resource	*resource;
 | |
| 	int		id;
 | |
| 	void		*platform_data;
 | |
| };
 | |
| 
 | |
| struct sh_mobile_ceu_info {
 | |
| 	unsigned long flags;
 | |
| 	int max_width;
 | |
| 	int max_height;
 | |
| 	struct sh_mobile_ceu_companion *csi2;
 | |
| 	struct v4l2_async_subdev **asd;	/* Flat array, arranged in groups */
 | |
| 	unsigned int *asd_sizes;	/* 0-terminated array pf asd group sizes */
 | |
| };
 | |
| 
 | |
| #endif /* __ASM_SH_MOBILE_CEU_H__ */
 |