7d8d9f6705
The hw cursor is relatively adept at triggering underflows, which manifest as a "blue flash" (since blue is configured as the underflow color). Juggle a few things around to tighten up the timing for setting cursor registers in DONE irq. And most importantly, don't ever disable the hw cursor. Instead flip it to a blank/empty cursor. This seems far more reliable, as even simply clearing the cursor-enable bit (with no other updates in previous/ following frames) can in some cases cause underflow. v1: original v2: add missing locking spotted by Micah Cc: Micah Richert <richert@braincorporation.com> Signed-off-by: Rob Clark <robdclark@gmail.com>
93 lines
2.5 KiB
C
93 lines
2.5 KiB
C
/*
|
|
* Copyright (C) 2013 Red Hat
|
|
* Author: Rob Clark <robdclark@gmail.com>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify it
|
|
* under the terms of the GNU General Public License version 2 as published by
|
|
* the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it will be useful, but WITHOUT
|
|
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
|
|
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
|
|
* more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along with
|
|
* this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
|
|
#include "msm_drv.h"
|
|
#include "mdp4_kms.h"
|
|
|
|
void mdp4_set_irqmask(struct mdp_kms *mdp_kms, uint32_t irqmask)
|
|
{
|
|
mdp4_write(to_mdp4_kms(mdp_kms), REG_MDP4_INTR_ENABLE, irqmask);
|
|
}
|
|
|
|
static void mdp4_irq_error_handler(struct mdp_irq *irq, uint32_t irqstatus)
|
|
{
|
|
DRM_ERROR("errors: %08x\n", irqstatus);
|
|
}
|
|
|
|
void mdp4_irq_preinstall(struct msm_kms *kms)
|
|
{
|
|
struct mdp4_kms *mdp4_kms = to_mdp4_kms(to_mdp_kms(kms));
|
|
mdp4_write(mdp4_kms, REG_MDP4_INTR_CLEAR, 0xffffffff);
|
|
}
|
|
|
|
int mdp4_irq_postinstall(struct msm_kms *kms)
|
|
{
|
|
struct mdp_kms *mdp_kms = to_mdp_kms(kms);
|
|
struct mdp4_kms *mdp4_kms = to_mdp4_kms(mdp_kms);
|
|
struct mdp_irq *error_handler = &mdp4_kms->error_handler;
|
|
|
|
error_handler->irq = mdp4_irq_error_handler;
|
|
error_handler->irqmask = MDP4_IRQ_PRIMARY_INTF_UDERRUN |
|
|
MDP4_IRQ_EXTERNAL_INTF_UDERRUN;
|
|
|
|
mdp_irq_register(mdp_kms, error_handler);
|
|
|
|
return 0;
|
|
}
|
|
|
|
void mdp4_irq_uninstall(struct msm_kms *kms)
|
|
{
|
|
struct mdp4_kms *mdp4_kms = to_mdp4_kms(to_mdp_kms(kms));
|
|
mdp4_write(mdp4_kms, REG_MDP4_INTR_ENABLE, 0x00000000);
|
|
}
|
|
|
|
irqreturn_t mdp4_irq(struct msm_kms *kms)
|
|
{
|
|
struct mdp_kms *mdp_kms = to_mdp_kms(kms);
|
|
struct mdp4_kms *mdp4_kms = to_mdp4_kms(mdp_kms);
|
|
struct drm_device *dev = mdp4_kms->dev;
|
|
struct msm_drm_private *priv = dev->dev_private;
|
|
unsigned int id;
|
|
uint32_t status;
|
|
|
|
status = mdp4_read(mdp4_kms, REG_MDP4_INTR_STATUS);
|
|
mdp4_write(mdp4_kms, REG_MDP4_INTR_CLEAR, status);
|
|
|
|
VERB("status=%08x", status);
|
|
|
|
mdp_dispatch_irqs(mdp_kms, status);
|
|
|
|
for (id = 0; id < priv->num_crtcs; id++)
|
|
if (status & mdp4_crtc_vblank(priv->crtcs[id]))
|
|
drm_handle_vblank(dev, id);
|
|
|
|
return IRQ_HANDLED;
|
|
}
|
|
|
|
int mdp4_enable_vblank(struct msm_kms *kms, struct drm_crtc *crtc)
|
|
{
|
|
mdp_update_vblank_mask(to_mdp_kms(kms),
|
|
mdp4_crtc_vblank(crtc), true);
|
|
return 0;
|
|
}
|
|
|
|
void mdp4_disable_vblank(struct msm_kms *kms, struct drm_crtc *crtc)
|
|
{
|
|
mdp_update_vblank_mask(to_mdp_kms(kms),
|
|
mdp4_crtc_vblank(crtc), false);
|
|
}
|